Branch: refs/heads/smoke-me/khw-env
Home: https://github.com/Perl/perl5
Commit: 083b9b8b48563bb7c057a161b24b684063d604f2
https://github.com/Perl/perl5/commit/083b9b8b48563bb7c057a161b24b684063d604f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: fbe3557610a09c8790ba61a6a414ce9c30cb488d
https://github.com/Perl/perl5/commit/fbe3557610a09c8790ba61a6a414ce9c30cb488d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 34995b0050811b8184ae57a0a60e855fbb457108
https://github.com/Perl/perl5/commit/34995b0050811b8184ae57a0a60e855fbb457108
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: fdf71082124fe548d5fd2fa34741b0ef2489bd51
https://github.com/Perl/perl5/commit/fdf71082124fe548d5fd2fa34741b0ef2489bd51
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: eeaf63849b2192555ed8c0746c9c2e0dc7f0667c
https://github.com/Perl/perl5/commit/eeaf63849b2192555ed8c0746c9c2e0dc7f0667c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 608b801e9aabb19bea18388a664ea917b8881b77
https://github.com/Perl/perl5/commit/608b801e9aabb19bea18388a664ea917b8881b77
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: e2ecd0d2dc62f19d9e62a1a8fb00b050a142556c
https://github.com/Perl/perl5/commit/e2ecd0d2dc62f19d9e62a1a8fb00b050a142556c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: d5a2a5c7702aa766c80fa0211e6342dc8709795a
https://github.com/Perl/perl5/commit/d5a2a5c7702aa766c80fa0211e6342dc8709795a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 600b01318d9ca54628e5bc8ebd82d4ad00715c69
https://github.com/Perl/perl5/commit/600b01318d9ca54628e5bc8ebd82d4ad00715c69
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 78cc860080b4e22b4b16d1e891bb1243013adcf8
https://github.com/Perl/perl5/commit/78cc860080b4e22b4b16d1e891bb1243013adcf8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 889f7c1e5b441d456440a9009f92045d07d5c377
https://github.com/Perl/perl5/commit/889f7c1e5b441d456440a9009f92045d07d5c377
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 4f117174213bb5a843c4409cf57d744295952388
https://github.com/Perl/perl5/commit/4f117174213bb5a843c4409cf57d744295952388
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 30d1e37aac9f035d4e0743092f8c01ea1d65baf1
https://github.com/Perl/perl5/commit/30d1e37aac9f035d4e0743092f8c01ea1d65baf1
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: be34d79576059aff7d3b4bb67c654548e86efc2f
https://github.com/Perl/perl5/commit/be34d79576059aff7d3b4bb67c654548e86efc2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 7834857602331345e4e75ee5426c09dbbf09c64f
https://github.com/Perl/perl5/commit/7834857602331345e4e75ee5426c09dbbf09c64f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 12e1902553eb6584364d06edc82280ae2be77473
https://github.com/Perl/perl5/commit/12e1902553eb6584364d06edc82280ae2be77473
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 5591a84e29d520d1f2233c9d3314e918b0ddd69d
https://github.com/Perl/perl5/commit/5591a84e29d520d1f2233c9d3314e918b0ddd69d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: bf0b25f0c8cd9eb939d9262805154fde55a2b0ec
https://github.com/Perl/perl5/commit/bf0b25f0c8cd9eb939d9262805154fde55a2b0ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: f5e5a19349e612fda3d6d8b9b4405be73966645c
https://github.com/Perl/perl5/commit/f5e5a19349e612fda3d6d8b9b4405be73966645c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: d877dd21b60137147daf7ac19cef48fc019780cb
https://github.com/Perl/perl5/commit/d877dd21b60137147daf7ac19cef48fc019780cb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: b780b821de8d588eaab63528cda79ee4a294361d
https://github.com/Perl/perl5/commit/b780b821de8d588eaab63528cda79ee4a294361d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 33d130143b9eb2029edb44c0ac8f64448ecabc83
https://github.com/Perl/perl5/commit/33d130143b9eb2029edb44c0ac8f64448ecabc83
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 3178d6cf06e8b4dc6f7e85321cc1205f9509daa8
https://github.com/Perl/perl5/commit/3178d6cf06e8b4dc6f7e85321cc1205f9509daa8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: ee02e3fa4137d8b433e8063f9dd3eb6c5f3330a0
https://github.com/Perl/perl5/commit/ee02e3fa4137d8b433e8063f9dd3eb6c5f3330a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 624f4e7f5048c205238eaba48de24c559be0f348
https://github.com/Perl/perl5/commit/624f4e7f5048c205238eaba48de24c559be0f348
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 664962e8d7bed01c97c83068840b2936f17bf369
https://github.com/Perl/perl5/commit/664962e8d7bed01c97c83068840b2936f17bf369
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 77bd6388cf75d32e9bb5a194bd88eda62159a077
https://github.com/Perl/perl5/commit/77bd6388cf75d32e9bb5a194bd88eda62159a077
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 7c78beb63ee2e851661bb4d571466cc0df031352
https://github.com/Perl/perl5/commit/7c78beb63ee2e851661bb4d571466cc0df031352
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: a01cbcc5f73ec2c109e2141cb75b6cdbe8ef4874
https://github.com/Perl/perl5/commit/a01cbcc5f73ec2c109e2141cb75b6cdbe8ef4874
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 77c43802329740a782d898fff9fe098dc9c699a7
https://github.com/Perl/perl5/commit/77c43802329740a782d898fff9fe098dc9c699a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 2d6071e424a93955eb2509dbc73c5600193b3faa
https://github.com/Perl/perl5/commit/2d6071e424a93955eb2509dbc73c5600193b3faa
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 185dd85b0df71c63f575085fcfed5cd5afdd164d
https://github.com/Perl/perl5/commit/185dd85b0df71c63f575085fcfed5cd5afdd164d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 52d0cc24148f257ef1e0456d171e1a61babf5830
https://github.com/Perl/perl5/commit/52d0cc24148f257ef1e0456d171e1a61babf5830
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 8451502a978384d0e500da35e9e1592e6121a4c8
https://github.com/Perl/perl5/commit/8451502a978384d0e500da35e9e1592e6121a4c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: ff705b317e977d2d87fdb2625b7791b2b4e0c7ce
https://github.com/Perl/perl5/commit/ff705b317e977d2d87fdb2625b7791b2b4e0c7ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 01aaada6a01d7fa796a11e339f2f998ec019a2f6
https://github.com/Perl/perl5/commit/01aaada6a01d7fa796a11e339f2f998ec019a2f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: b1a6f2c81697e2f202d6db84f9c9732c26e8e4eb
https://github.com/Perl/perl5/commit/b1a6f2c81697e2f202d6db84f9c9732c26e8e4eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 169ddc0996810d17ccfa4d3887bcab118c7057b4
https://github.com/Perl/perl5/commit/169ddc0996810d17ccfa4d3887bcab118c7057b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 5fa8f9ca6e7a55a775c14722f9a166c81f4e6199
https://github.com/Perl/perl5/commit/5fa8f9ca6e7a55a775c14722f9a166c81f4e6199
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 508a43fd824c4d3a48908eb3572dc39a3bde085f
https://github.com/Perl/perl5/commit/508a43fd824c4d3a48908eb3572dc39a3bde085f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: e5ca6e82d8fdf6f5df3d6c2ff466abca16eb7306
https://github.com/Perl/perl5/commit/e5ca6e82d8fdf6f5df3d6c2ff466abca16eb7306
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 36972e66c2141c5e9f342572e107492989aed9d5
https://github.com/Perl/perl5/commit/36972e66c2141c5e9f342572e107492989aed9d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 5540631fd1b3d4e6eada88ef68430fd8cc55f692
https://github.com/Perl/perl5/commit/5540631fd1b3d4e6eada88ef68430fd8cc55f692
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 9adff0688b5699e25fcd115aa565192486b729d4
https://github.com/Perl/perl5/commit/9adff0688b5699e25fcd115aa565192486b729d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 12643f49dd97ad53cde9840c6b57953d2b980e6f
https://github.com/Perl/perl5/commit/12643f49dd97ad53cde9840c6b57953d2b980e6f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: fa99b9b9d02d5558bfeca45fd68251f2cc52834a
https://github.com/Perl/perl5/commit/fa99b9b9d02d5558bfeca45fd68251f2cc52834a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 5229d5db840e48c78754cb4ec757726d420c07d4
https://github.com/Perl/perl5/commit/5229d5db840e48c78754cb4ec757726d420c07d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: afd30734e14e8ccb87d2a93db2f67709c53408bc
https://github.com/Perl/perl5/commit/afd30734e14e8ccb87d2a93db2f67709c53408bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 56160b8afc7f8347ca8880d8bb979b22d11f532d
https://github.com/Perl/perl5/commit/56160b8afc7f8347ca8880d8bb979b22d11f532d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 30cadc7ac72c11f615f91f05ae38f46011112a18
https://github.com/Perl/perl5/commit/30cadc7ac72c11f615f91f05ae38f46011112a18
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 2af9f58ee2c1fa8aa34dbea2156ee153ae1f6954
https://github.com/Perl/perl5/commit/2af9f58ee2c1fa8aa34dbea2156ee153ae1f6954
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: a95f47432db12487e3b4d82346455928adaa7eba
https://github.com/Perl/perl5/commit/a95f47432db12487e3b4d82346455928adaa7eba
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 4ff02591d626417865e13f0a5d504e30d8136fc6
https://github.com/Perl/perl5/commit/4ff02591d626417865e13f0a5d504e30d8136fc6
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 80894411e1ed751674e4020b7fc21bed10c42cb0
https://github.com/Perl/perl5/commit/80894411e1ed751674e4020b7fc21bed10c42cb0
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: bc77d011c738a34c650ba1997aaf011ac8cfbb44
https://github.com/Perl/perl5/commit/bc77d011c738a34c650ba1997aaf011ac8cfbb44
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: d4731eebc67250d55bf70c380a0ae8b073d4ae84
https://github.com/Perl/perl5/commit/d4731eebc67250d55bf70c380a0ae8b073d4ae84
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 8b428367049fc3cf62bdbc6542383acbc5e6b3c5
https://github.com/Perl/perl5/commit/8b428367049fc3cf62bdbc6542383acbc5e6b3c5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: c6cff72d27b8db6ff44f30c7f7b43ab2779ae6cc
https://github.com/Perl/perl5/commit/c6cff72d27b8db6ff44f30c7f7b43ab2779ae6cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: d5d5975b985b46f65fc051c48dc24dc8f4ddc73c
https://github.com/Perl/perl5/commit/d5d5975b985b46f65fc051c48dc24dc8f4ddc73c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 273adce3743556fd9dd4bca7d734beabdd1cc1c3
https://github.com/Perl/perl5/commit/273adce3743556fd9dd4bca7d734beabdd1cc1c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 3b8373aee1428678b5f369fc14d4343abf76b8eb
https://github.com/Perl/perl5/commit/3b8373aee1428678b5f369fc14d4343abf76b8eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 71b7910ee6d6eca8e657949cea4c4d4aea8413eb
https://github.com/Perl/perl5/commit/71b7910ee6d6eca8e657949cea4c4d4aea8413eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: ab418414238193a5026cc72d66d6a1a97be29a59
https://github.com/Perl/perl5/commit/ab418414238193a5026cc72d66d6a1a97be29a59
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 7b938d96f858effda504ccbcecc7c57169eb29b8
https://github.com/Perl/perl5/commit/7b938d96f858effda504ccbcecc7c57169eb29b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: d921614cb4614ba659a92dd531435bdf2121d86b
https://github.com/Perl/perl5/commit/d921614cb4614ba659a92dd531435bdf2121d86b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 3d36053427cde13b9b608301adfb8f21cfe02d18
https://github.com/Perl/perl5/commit/3d36053427cde13b9b608301adfb8f21cfe02d18
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: a4cbf848fed970af147d8db7668687b563b96af5
https://github.com/Perl/perl5/commit/a4cbf848fed970af147d8db7668687b563b96af5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: a8974ccef7633114113336a42b574c8414b036b5
https://github.com/Perl/perl5/commit/a8974ccef7633114113336a42b574c8414b036b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 89b8affd7b674f69dae4395b05b9db115cb4b240
https://github.com/Perl/perl5/commit/89b8affd7b674f69dae4395b05b9db115cb4b240
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: ac71dd494f8a5794e2c0d90926ff210550faf728
https://github.com/Perl/perl5/commit/ac71dd494f8a5794e2c0d90926ff210550faf728
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 8fc27bd42beefd2ff912b49e6d2fb7116ff5fbca
https://github.com/Perl/perl5/commit/8fc27bd42beefd2ff912b49e6d2fb7116ff5fbca
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 99287d45f265bad665ba4261319e6dd95fd90bb5
https://github.com/Perl/perl5/commit/99287d45f265bad665ba4261319e6dd95fd90bb5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: feaf9d2b1a8f350b314d2206089eadf4af7d82f6
https://github.com/Perl/perl5/commit/feaf9d2b1a8f350b314d2206089eadf4af7d82f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 083c32f2d2034a7f8eb25d8941017c46e6888bde
https://github.com/Perl/perl5/commit/083c32f2d2034a7f8eb25d8941017c46e6888bde
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 0ce4f2b56b87f80b620a342809170e7b61b3313e
https://github.com/Perl/perl5/commit/0ce4f2b56b87f80b620a342809170e7b61b3313e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: edc4fc8e51af0a44bce75d95dc02c17cab9efd18
https://github.com/Perl/perl5/commit/edc4fc8e51af0a44bce75d95dc02c17cab9efd18
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 1f0970c0c9e08c5341f46527492ab97b631f05b5
https://github.com/Perl/perl5/commit/1f0970c0c9e08c5341f46527492ab97b631f05b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 24871a9304a86a2e349ec16a4f9169c1be2f855f
https://github.com/Perl/perl5/commit/24871a9304a86a2e349ec16a4f9169c1be2f855f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 3bb9a97816fdced51b307a5aac6f8d0a158b9976
https://github.com/Perl/perl5/commit/3bb9a97816fdced51b307a5aac6f8d0a158b9976
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: dd206763afc436639654446283c00959229c000a
https://github.com/Perl/perl5/commit/dd206763afc436639654446283c00959229c000a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 6d6bc4ef3bdbab3eabfcd7b0a71f178385e304c8
https://github.com/Perl/perl5/commit/6d6bc4ef3bdbab3eabfcd7b0a71f178385e304c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 297c0022f39f1f0ff031bb2c9953dc5c241ca35e
https://github.com/Perl/perl5/commit/297c0022f39f1f0ff031bb2c9953dc5c241ca35e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: dc02553746cc03a99a3702f401aebc228413d458
https://github.com/Perl/perl5/commit/dc02553746cc03a99a3702f401aebc228413d458
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 34ccfda6938debd2a129f697ea569370af60428a
https://github.com/Perl/perl5/commit/34ccfda6938debd2a129f697ea569370af60428a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: d22b6e7f9fbbed2f60a81407be3308e0f7756bd9
https://github.com/Perl/perl5/commit/d22b6e7f9fbbed2f60a81407be3308e0f7756bd9
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: ca07e04e07cd210f81929ed1579a609700b27eab
https://github.com/Perl/perl5/commit/ca07e04e07cd210f81929ed1579a609700b27eab
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 99d311bdda0910291f548761335a3c216e41f006
https://github.com/Perl/perl5/commit/99d311bdda0910291f548761335a3c216e41f006
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: d7db3a1eeff41f9b707eef36867f23b6c8be4eac
https://github.com/Perl/perl5/commit/d7db3a1eeff41f9b707eef36867f23b6c8be4eac
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 31a43acafbb9572d7daaf003770adf257a7f822f
https://github.com/Perl/perl5/commit/31a43acafbb9572d7daaf003770adf257a7f822f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: dc603e954ee9b53174edcecb2ebc7b59f20352f1
https://github.com/Perl/perl5/commit/dc603e954ee9b53174edcecb2ebc7b59f20352f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 18aaf65dfba0b91d716a8db69431a504e83b268b
https://github.com/Perl/perl5/commit/18aaf65dfba0b91d716a8db69431a504e83b268b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 7966f51a30e602256807fc84f5b9ddc2dbbe32a7
https://github.com/Perl/perl5/commit/7966f51a30e602256807fc84f5b9ddc2dbbe32a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 29448b10fdd40ed89ea8860da0d07f498ddcf3c4
https://github.com/Perl/perl5/commit/29448b10fdd40ed89ea8860da0d07f498ddcf3c4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 4b76f7be1110aa68a14c47af079e3f4d0b6f9727
https://github.com/Perl/perl5/commit/4b76f7be1110aa68a14c47af079e3f4d0b6f9727
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: ee218460f4fdef630fe449663a2947170c79a681
https://github.com/Perl/perl5/commit/ee218460f4fdef630fe449663a2947170c79a681
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: b511aa92cb8b94eb77f810e4d933455f53e129cf
https://github.com/Perl/perl5/commit/b511aa92cb8b94eb77f810e4d933455f53e129cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 84952b9aa396ee19cfaf8e2614b1a072d75b45ab
https://github.com/Perl/perl5/commit/84952b9aa396ee19cfaf8e2614b1a072d75b45ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 870c35ad8e5c03f851ef8f4a8767e697cb8a0721
https://github.com/Perl/perl5/commit/870c35ad8e5c03f851ef8f4a8767e697cb8a0721
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 06c8472b18b086c692d575ba569ade7a4a288171
https://github.com/Perl/perl5/commit/06c8472b18b086c692d575ba569ade7a4a288171
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 2248641fe21f1c4812f452bab4f92063cb847a74
https://github.com/Perl/perl5/commit/2248641fe21f1c4812f452bab4f92063cb847a74
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: 76b7bac9e4a2145c9fdd38eb4633472a9a0d46df
https://github.com/Perl/perl5/commit/76b7bac9e4a2145c9fdd38eb4633472a9a0d46df
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 3ff421748781405371b2890a3a7eddab2a662ca5
https://github.com/Perl/perl5/commit/3ff421748781405371b2890a3a7eddab2a662ca5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 236920b77dcede5cc9cd20868264748a5b89bc3a
https://github.com/Perl/perl5/commit/236920b77dcede5cc9cd20868264748a5b89bc3a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 6770f0d804d520b5cf3bb0746a139f8fa7c403cd
https://github.com/Perl/perl5/commit/6770f0d804d520b5cf3bb0746a139f8fa7c403cd
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 58a54f43b25048f5ae53ce323f883c2d29791538
https://github.com/Perl/perl5/commit/58a54f43b25048f5ae53ce323f883c2d29791538
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 2f7ee88c7e6b8638ae1a15435dc1767745d41d69
https://github.com/Perl/perl5/commit/2f7ee88c7e6b8638ae1a15435dc1767745d41d69
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 58f512a9d74a586922be53544991417f0998e12c
https://github.com/Perl/perl5/commit/58f512a9d74a586922be53544991417f0998e12c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 25f7ca37b3f41e596b7c2acafda2a8ed9ea0b4a0
https://github.com/Perl/perl5/commit/25f7ca37b3f41e596b7c2acafda2a8ed9ea0b4a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: ae3ee68fa6860bd2ba4e63dc9892e72760daabd1
https://github.com/Perl/perl5/commit/ae3ee68fa6860bd2ba4e63dc9892e72760daabd1
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: eef50ebb1f64e2e177cbcb32babd479af891482e
https://github.com/Perl/perl5/commit/eef50ebb1f64e2e177cbcb32babd479af891482e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: cc81471b38e35bbc0015489217eb14010afbba10
https://github.com/Perl/perl5/commit/cc81471b38e35bbc0015489217eb14010afbba10
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 3b24eeeb4c73300e386f3f631cf2cb5cf58e9c9e
https://github.com/Perl/perl5/commit/3b24eeeb4c73300e386f3f631cf2cb5cf58e9c9e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 7e458aecdf3be6c81add94da37ce9d0544797343
https://github.com/Perl/perl5/commit/7e458aecdf3be6c81add94da37ce9d0544797343
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: b3702068625bccb7e5f1b3d004dd20e9dceef881
https://github.com/Perl/perl5/commit/b3702068625bccb7e5f1b3d004dd20e9dceef881
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: fe23483f3f479e9734bd23f99a83344a59de2ca7
https://github.com/Perl/perl5/commit/fe23483f3f479e9734bd23f99a83344a59de2ca7
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 49c45f84d45adf78938941078e61f72e9438c12f
https://github.com/Perl/perl5/commit/49c45f84d45adf78938941078e61f72e9438c12f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: fe622e32f858e0e94368053ac2a31d96f0d536ef
https://github.com/Perl/perl5/commit/fe622e32f858e0e94368053ac2a31d96f0d536ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: 5f8424384af0cf796bc6395ff997f35e61362242
https://github.com/Perl/perl5/commit/5f8424384af0cf796bc6395ff997f35e61362242
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 7269376380bf000e241c79803e3af17b69b76bdb
https://github.com/Perl/perl5/commit/7269376380bf000e241c79803e3af17b69b76bdb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 5a9a364048a33ff722a94d1ed869e0caaee1c110
https://github.com/Perl/perl5/commit/5a9a364048a33ff722a94d1ed869e0caaee1c110
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: b887d600d406e1de0fa7af30b8a0dabb54712584
https://github.com/Perl/perl5/commit/b887d600d406e1de0fa7af30b8a0dabb54712584
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 456d6010b0e9741a6c73ee983f1a6aab864bfabf
https://github.com/Perl/perl5/commit/456d6010b0e9741a6c73ee983f1a6aab864bfabf
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 3bca6b230ba8a15266e6c65ca34403f8a28afb2f
https://github.com/Perl/perl5/commit/3bca6b230ba8a15266e6c65ca34403f8a28afb2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 17782bc2b88732faa7f2b2cf8e0a5c0f35ae9082
https://github.com/Perl/perl5/commit/17782bc2b88732faa7f2b2cf8e0a5c0f35ae9082
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: c996c67701fda1490b92270f1ef5a507751ce5b8
https://github.com/Perl/perl5/commit/c996c67701fda1490b92270f1ef5a507751ce5b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 29d4645578d44f8f025d04a96bbb095adad6a251
https://github.com/Perl/perl5/commit/29d4645578d44f8f025d04a96bbb095adad6a251
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 726f2d04695e707c68a3bbad241cda12ec4bdb97
https://github.com/Perl/perl5/commit/726f2d04695e707c68a3bbad241cda12ec4bdb97
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: deb47b6d50638b648a985b657ee2862b4619aebc
https://github.com/Perl/perl5/commit/deb47b6d50638b648a985b657ee2862b4619aebc
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: 7479b0adc0775eb6a0e6aaa40ed7c465db7a4d65
https://github.com/Perl/perl5/commit/7479b0adc0775eb6a0e6aaa40ed7c465db7a4d65
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: d4bce9e3def5e49686e0ab54727287e51e215db8
https://github.com/Perl/perl5/commit/d4bce9e3def5e49686e0ab54727287e51e215db8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: 0088710fda8ecb4b85436a9f78dfa92ed9aaaeda
https://github.com/Perl/perl5/commit/0088710fda8ecb4b85436a9f78dfa92ed9aaaeda
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: 6108e70eb067b8115b4e0575340d634be42e53c0
https://github.com/Perl/perl5/commit/6108e70eb067b8115b4e0575340d634be42e53c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: 8747de3f87b770741e950f078befc848946afaec
https://github.com/Perl/perl5/commit/8747de3f87b770741e950f078befc848946afaec
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: b9ce4f4620482deabbdb8385d82805a3a7dfcdaf
https://github.com/Perl/perl5/commit/b9ce4f4620482deabbdb8385d82805a3a7dfcdaf
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: 2add8d3d892597df09180a0c59a79d0f99b74a2e
https://github.com/Perl/perl5/commit/2add8d3d892597df09180a0c59a79d0f99b74a2e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: 7a02277cb4a84879536cb723b4f95cfc55034a9d
https://github.com/Perl/perl5/commit/7a02277cb4a84879536cb723b4f95cfc55034a9d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: 845a1514eee7a4f5be770906982aba7c1cf5ea71
https://github.com/Perl/perl5/commit/845a1514eee7a4f5be770906982aba7c1cf5ea71
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: 659eabbaf33dc7e25fe34a511fc66cc880d97619
https://github.com/Perl/perl5/commit/659eabbaf33dc7e25fe34a511fc66cc880d97619
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: c7e0b8f706dae29ada79c247340bba5e951a4dda
https://github.com/Perl/perl5/commit/c7e0b8f706dae29ada79c247340bba5e951a4dda
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: fb3dfd1199c9a6e15c3e5f51c3da615651d97ed4
https://github.com/Perl/perl5/commit/fb3dfd1199c9a6e15c3e5f51c3da615651d97ed4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: cd29bac90ac2f20992f4ddfd36dcc50de3561cbb
https://github.com/Perl/perl5/commit/cd29bac90ac2f20992f4ddfd36dcc50de3561cbb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: d27d01938f23153aec4ab256697cc92f19d181d0
https://github.com/Perl/perl5/commit/d27d01938f23153aec4ab256697cc92f19d181d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 93a78e00b2a10f0acae6df64d0e3490ce438b26b
https://github.com/Perl/perl5/commit/93a78e00b2a10f0acae6df64d0e3490ce438b26b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 9940a7c520c268aa8474243baea6885a526960db
https://github.com/Perl/perl5/commit/9940a7c520c268aa8474243baea6885a526960db
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: lib/locale.t: debug
Commit: 99e4cf25e69412a9e2932a320388075883705ea7
https://github.com/Perl/perl5/commit/99e4cf25e69412a9e2932a320388075883705ea7
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 1152f07f31934079762bb3672ee8dab95e1e1768
https://github.com/Perl/perl5/commit/1152f07f31934079762bb3672ee8dab95e1e1768
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 451ba8515451e88bd2dc88880e17bf1100330fd0
https://github.com/Perl/perl5/commit/451ba8515451e88bd2dc88880e17bf1100330fd0
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: ad565dc6fd652396d04312bf2a6de492df82e83b
https://github.com/Perl/perl5/commit/ad565dc6fd652396d04312bf2a6de492df82e83b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 3bbce6ea803219a3101c4b895ba9f5832c81c29d
https://github.com/Perl/perl5/commit/3bbce6ea803219a3101c4b895ba9f5832c81c29d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 026bf8bca660a1f1c1183d7621be878cffbe070d
https://github.com/Perl/perl5/commit/026bf8bca660a1f1c1183d7621be878cffbe070d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: ac83c9c2e676b29e073e04e560e6a29c7c16775d
https://github.com/Perl/perl5/commit/ac83c9c2e676b29e073e04e560e6a29c7c16775d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 5cc63084c2cabd666ed453dd4e94166565df55c8
https://github.com/Perl/perl5/commit/5cc63084c2cabd666ed453dd4e94166565df55c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: d0090aed211f4561ac0542a6ca20e101d4db8f1e
https://github.com/Perl/perl5/commit/d0090aed211f4561ac0542a6ca20e101d4db8f1e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: ae3cacf45bc8b516e76d857a383f8897ff407f71
https://github.com/Perl/perl5/commit/ae3cacf45bc8b516e76d857a383f8897ff407f71
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 4c20b8be1fd37c69d77e7ce038136035a330ce2c
https://github.com/Perl/perl5/commit/4c20b8be1fd37c69d77e7ce038136035a330ce2c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 86738637087cbf243eedde823e5203908a2d91a7
https://github.com/Perl/perl5/commit/86738637087cbf243eedde823e5203908a2d91a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: e90c296899f63f89eb7b8c33e9da7bd06c54bbf4
https://github.com/Perl/perl5/commit/e90c296899f63f89eb7b8c33e9da7bd06c54bbf4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 880f6a1be8135565b7fce9c97286a270e6b66461
https://github.com/Perl/perl5/commit/880f6a1be8135565b7fce9c97286a270e6b66461
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: c85644efd3f905c23dd42c7b8a5faf350ddcf943
https://github.com/Perl/perl5/commit/c85644efd3f905c23dd42c7b8a5faf350ddcf943
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 32fdb35fe240cc766decaeb717c72fcdd6bc8e02
https://github.com/Perl/perl5/commit/32fdb35fe240cc766decaeb717c72fcdd6bc8e02
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: c30a695e1d9f8bd54faa50798e0ea789a10a1ae8
https://github.com/Perl/perl5/commit/c30a695e1d9f8bd54faa50798e0ea789a10a1ae8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 9ba4e86b03865f11a789fd6266e9ceac653c4d33
https://github.com/Perl/perl5/commit/9ba4e86b03865f11a789fd6266e9ceac653c4d33
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: a63ea3518165484c57a66cf0f01459f9efe1fb33
https://github.com/Perl/perl5/commit/a63ea3518165484c57a66cf0f01459f9efe1fb33
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 2ab0e854b7c1b9dd6b63be1f709e64e2cf213ccb
https://github.com/Perl/perl5/commit/2ab0e854b7c1b9dd6b63be1f709e64e2cf213ccb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 9a856d901e446336fce368e622c4ccef23f6480f
https://github.com/Perl/perl5/commit/9a856d901e446336fce368e622c4ccef23f6480f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 1dcf3f1a1ffacecba0b4340a105468ea9d8525f2
https://github.com/Perl/perl5/commit/1dcf3f1a1ffacecba0b4340a105468ea9d8525f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 5fb449f6968ac58befe53ca37a7e21aab86b8848
https://github.com/Perl/perl5/commit/5fb449f6968ac58befe53ca37a7e21aab86b8848
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 99d53ef4db1a1b46e7e4b933970b1cf3886db3f2
https://github.com/Perl/perl5/commit/99d53ef4db1a1b46e7e4b933970b1cf3886db3f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: 4c634b664e25f29e98f562954b492feca270c675
https://github.com/Perl/perl5/commit/4c634b664e25f29e98f562954b492feca270c675
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: fa9e80fb0098d658b1970ae5554cff6e243a9f7b
https://github.com/Perl/perl5/commit/fa9e80fb0098d658b1970ae5554cff6e243a9f7b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: b88553a9932a69fbc72c99e42a305003ab4e346e
https://github.com/Perl/perl5/commit/b88553a9932a69fbc72c99e42a305003ab4e346e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: b9157b774a4dd7aa6e0ed115336643400abb7360
https://github.com/Perl/perl5/commit/b9157b774a4dd7aa6e0ed115336643400abb7360
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 876beee08bc1d9628c374a6e7d97dbe14e03f795
https://github.com/Perl/perl5/commit/876beee08bc1d9628c374a6e7d97dbe14e03f795
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: a734ef4fcd46d5a45bb3a171d08b67c26bc9ca05
https://github.com/Perl/perl5/commit/a734ef4fcd46d5a45bb3a171d08b67c26bc9ca05
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: c0636f2eb86b668f1920082a94aeac1734e4f340
https://github.com/Perl/perl5/commit/c0636f2eb86b668f1920082a94aeac1734e4f340
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: dde3d1023ae898f3bd452fbe4054637d0ff625bb
https://github.com/Perl/perl5/commit/dde3d1023ae898f3bd452fbe4054637d0ff625bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: bac5520ba9548a07b2ba298926aff0d069e953b0
https://github.com/Perl/perl5/commit/bac5520ba9548a07b2ba298926aff0d069e953b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 54fc6b518a5eb24bd23b1863696406f75b043345
https://github.com/Perl/perl5/commit/54fc6b518a5eb24bd23b1863696406f75b043345
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 1f2c150f1b654d1e4566652cc3c92189df54302c
https://github.com/Perl/perl5/commit/1f2c150f1b654d1e4566652cc3c92189df54302c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 5b1ed4b104f231fcefa55d7a3f0ddcf1c5a4901e
https://github.com/Perl/perl5/commit/5b1ed4b104f231fcefa55d7a3f0ddcf1c5a4901e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 1e8a0fddd66e2e1a2242d81cb89dc99ef3bcb367
https://github.com/Perl/perl5/commit/1e8a0fddd66e2e1a2242d81cb89dc99ef3bcb367
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 53eba435fe185339fc25b1aacc42c066f378cd72
https://github.com/Perl/perl5/commit/53eba435fe185339fc25b1aacc42c066f378cd72
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: c35b0b81b28842c793f10d416db583c435522dee
https://github.com/Perl/perl5/commit/c35b0b81b28842c793f10d416db583c435522dee
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 317f0c4918c2920b4f74c04ffacfb0ff36f869b0
https://github.com/Perl/perl5/commit/317f0c4918c2920b4f74c04ffacfb0ff36f869b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: de5f97590e742186c9d69be32f39ce2a98f083db
https://github.com/Perl/perl5/commit/de5f97590e742186c9d69be32f39ce2a98f083db
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: f55675c3e885967ccdc655b35038d8724ecd3382
https://github.com/Perl/perl5/commit/f55675c3e885967ccdc655b35038d8724ecd3382
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 0c55bbb6f3d95cfe33c6df2680796c32da724d41
https://github.com/Perl/perl5/commit/0c55bbb6f3d95cfe33c6df2680796c32da724d41
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: cec107da55775c379f9d3571c4ffa2d17fdc1cf8
https://github.com/Perl/perl5/commit/cec107da55775c379f9d3571c4ffa2d17fdc1cf8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 8be165970a0f970a62139d47c4b0993761e8b06b
https://github.com/Perl/perl5/commit/8be165970a0f970a62139d47c4b0993761e8b06b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: c52ff00943ed9fed414e41b5fbe4849818c141cd
https://github.com/Perl/perl5/commit/c52ff00943ed9fed414e41b5fbe4849818c141cd
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: e3e04c0a179b47e95d38a7c6d36c8c394dd506ba
https://github.com/Perl/perl5/commit/e3e04c0a179b47e95d38a7c6d36c8c394dd506ba
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 0f48590cff66746ef7b6096ab39a7caf8731535c
https://github.com/Perl/perl5/commit/0f48590cff66746ef7b6096ab39a7caf8731535c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 953af0c2bd501a34d90eea2ffd38dc86396cda39
https://github.com/Perl/perl5/commit/953af0c2bd501a34d90eea2ffd38dc86396cda39
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 9e04154b0feb9015dce14bf1308c49d9cb250c9b
https://github.com/Perl/perl5/commit/9e04154b0feb9015dce14bf1308c49d9cb250c9b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: ccd97f027c7151ae89921a5e22161a0e1db63490
https://github.com/Perl/perl5/commit/ccd97f027c7151ae89921a5e22161a0e1db63490
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: dcddbf6fed5164ec1833a193ab34b775f4bd0744
https://github.com/Perl/perl5/commit/dcddbf6fed5164ec1833a193ab34b775f4bd0744
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 4e87c16afc8d0b427355ae335c6739d46db59deb
https://github.com/Perl/perl5/commit/4e87c16afc8d0b427355ae335c6739d46db59deb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 599c8cf627b68cda29a7e87396ee0a7181d5d981
https://github.com/Perl/perl5/commit/599c8cf627b68cda29a7e87396ee0a7181d5d981
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: 711555ff9ab6957e323bc02fbf8ae0a1d52009c5
https://github.com/Perl/perl5/commit/711555ff9ab6957e323bc02fbf8ae0a1d52009c5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: ad798ce5680ba552de1ce2d6875d4702072ac98b
https://github.com/Perl/perl5/commit/ad798ce5680ba552de1ce2d6875d4702072ac98b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: d97df397507b341164d8d6932096eb708cec54ad
https://github.com/Perl/perl5/commit/d97df397507b341164d8d6932096eb708cec54ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: cfe61db6fdaf5f666eea71280e3677e6aa1620f9
https://github.com/Perl/perl5/commit/cfe61db6fdaf5f666eea71280e3677e6aa1620f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 16dfcb4b29612b804a8df58cf094d4fa3875a99a
https://github.com/Perl/perl5/commit/16dfcb4b29612b804a8df58cf094d4fa3875a99a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 957adf0cb5e0b400e25167ca67d773f8a8cd0582
https://github.com/Perl/perl5/commit/957adf0cb5e0b400e25167ca67d773f8a8cd0582
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 356a3a7276ddbf5943afca8b43371826ca36548b
https://github.com/Perl/perl5/commit/356a3a7276ddbf5943afca8b43371826ca36548b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: d17fc76f69938c5d169654a34587b669fb7800ef
https://github.com/Perl/perl5/commit/d17fc76f69938c5d169654a34587b669fb7800ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 2f30c24771cc0d3055ad8391bfc82ae79351e75d
https://github.com/Perl/perl5/commit/2f30c24771cc0d3055ad8391bfc82ae79351e75d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 57ed4bb6bc926b5ab749aea4aa53e6d008e3a8a2
https://github.com/Perl/perl5/commit/57ed4bb6bc926b5ab749aea4aa53e6d008e3a8a2
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 6d866e5804529eed15e7784fd040b74b3a02d679
https://github.com/Perl/perl5/commit/6d866e5804529eed15e7784fd040b74b3a02d679
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: ed31d8ec8a2f1ccb6962658967853da16cb79038
https://github.com/Perl/perl5/commit/ed31d8ec8a2f1ccb6962658967853da16cb79038
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: c01b2adf99fc7dc9609a0f1662faaf7f93d29ae5
https://github.com/Perl/perl5/commit/c01b2adf99fc7dc9609a0f1662faaf7f93d29ae5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: fd43c87a455a709fdf5f018b7f85ab142fca0d72
https://github.com/Perl/perl5/commit/fd43c87a455a709fdf5f018b7f85ab142fca0d72
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 15a23c3ed484d872c224c590794e59215f1569de
https://github.com/Perl/perl5/commit/15a23c3ed484d872c224c590794e59215f1569de
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: b48b06606e63ba4dea6b3f578f2aa65c07461a24
https://github.com/Perl/perl5/commit/b48b06606e63ba4dea6b3f578f2aa65c07461a24
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 45e3c1ae1513d242fbb14d3956be321618d382ef
https://github.com/Perl/perl5/commit/45e3c1ae1513d242fbb14d3956be321618d382ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: abc2e2726396d4995e2095fe80bc5310c466b2e1
https://github.com/Perl/perl5/commit/abc2e2726396d4995e2095fe80bc5310c466b2e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: b7118a7f5702a41fa2b2714781a0f6585846ab8f
https://github.com/Perl/perl5/commit/b7118a7f5702a41fa2b2714781a0f6585846ab8f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: c0c16d82fc64c1eed97d5de0dbe1b5a25627d12d
https://github.com/Perl/perl5/commit/c0c16d82fc64c1eed97d5de0dbe1b5a25627d12d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: e39a9e943653bff649078c3064d799fc4cdf2b26
https://github.com/Perl/perl5/commit/e39a9e943653bff649078c3064d799fc4cdf2b26
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: 45f92a4cf401c69a852e641885a46301b9a6f5e4
https://github.com/Perl/perl5/commit/45f92a4cf401c69a852e641885a46301b9a6f5e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: 9a7b3efb72839f902e6a459bbf9060cb92aeedc7
https://github.com/Perl/perl5/commit/9a7b3efb72839f902e6a459bbf9060cb92aeedc7
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: 4a6447170c683dc8c62baad34e025dd98c4b45da
https://github.com/Perl/perl5/commit/4a6447170c683dc8c62baad34e025dd98c4b45da
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: 91e1bf667f05b90fa93d8d02f79d69f006402c9d
https://github.com/Perl/perl5/commit/91e1bf667f05b90fa93d8d02f79d69f006402c9d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: 119ea474bca298eb61ed111a0886b626be9b5478
https://github.com/Perl/perl5/commit/119ea474bca298eb61ed111a0886b626be9b5478
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: 227d227fb0cf3dc836d70d6560fd9b0eeab5d9d6
https://github.com/Perl/perl5/commit/227d227fb0cf3dc836d70d6560fd9b0eeab5d9d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: eab9a7bb6ad84d4db069d72e4abe677af7b9fbcc
https://github.com/Perl/perl5/commit/eab9a7bb6ad84d4db069d72e4abe677af7b9fbcc
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: 923790028b2f130cbc34e01b8a4a8f6fe3d4d8e8
https://github.com/Perl/perl5/commit/923790028b2f130cbc34e01b8a4a8f6fe3d4d8e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 0ea5e54218f6770a22bf3473e9558781d062d2fa
https://github.com/Perl/perl5/commit/0ea5e54218f6770a22bf3473e9558781d062d2fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: fd00c01db156cdf80a4a77f05ccaf7a6f1bbe7ce
https://github.com/Perl/perl5/commit/fd00c01db156cdf80a4a77f05ccaf7a6f1bbe7ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: f044f3aa3f3189a638c7fb3795b71c6aa4d0c88a
https://github.com/Perl/perl5/commit/f044f3aa3f3189a638c7fb3795b71c6aa4d0c88a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: 8045f049af82bcd1bc58a1284a310daaaa5fbf4c
https://github.com/Perl/perl5/commit/8045f049af82bcd1bc58a1284a310daaaa5fbf4c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: ca4ff0e42cdbd9b72cf48761090de29fa40c831e
https://github.com/Perl/perl5/commit/ca4ff0e42cdbd9b72cf48761090de29fa40c831e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: eb86648b7190e8c5d1f01b152db61d951daac1d3
https://github.com/Perl/perl5/commit/eb86648b7190e8c5d1f01b152db61d951daac1d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: 4af0618e8c639428a872f3d59238e983028c5fac
https://github.com/Perl/perl5/commit/4af0618e8c639428a872f3d59238e983028c5fac
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: 1b7723bc1fc244740bf5fa21ff213a994b7ae8be
https://github.com/Perl/perl5/commit/1b7723bc1fc244740bf5fa21ff213a994b7ae8be
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: e929744787160e87559f69b46e36328e362e045e
https://github.com/Perl/perl5/commit/e929744787160e87559f69b46e36328e362e045e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: 333447828e943ef0447c8055112fce7e6eb0e684
https://github.com/Perl/perl5/commit/333447828e943ef0447c8055112fce7e6eb0e684
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: 217e9f7cd40be8ddd6c7acfd5d0040e19a5600f0
https://github.com/Perl/perl5/commit/217e9f7cd40be8ddd6c7acfd5d0040e19a5600f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: 023b7dab249d155a0fc71e464fab27a46dd13357
https://github.com/Perl/perl5/commit/023b7dab249d155a0fc71e464fab27a46dd13357
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: 31d68b7d38b71b39a33803c2a06e74b374cc141d
https://github.com/Perl/perl5/commit/31d68b7d38b71b39a33803c2a06e74b374cc141d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: e716c87785ace7eed2120161a8d4c45c5823016b
https://github.com/Perl/perl5/commit/e716c87785ace7eed2120161a8d4c45c5823016b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads debugging
Commit: e0ee7603acfdd422c942895956ff37304448c14a
https://github.com/Perl/perl5/commit/e0ee7603acfdd422c942895956ff37304448c14a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: e1d7d7c0cbc16e03532aa1dd241eefadb07fec25
https://github.com/Perl/perl5/commit/e1d7d7c0cbc16e03532aa1dd241eefadb07fec25
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: edd19b18d4e5ee3f9c901c338a33208ed53e13c1
https://github.com/Perl/perl5/commit/edd19b18d4e5ee3f9c901c338a33208ed53e13c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg,thread_init Revamp sync_locale, switch_to_global_locale
f
Commit: 329f05da8a65a52a20a4557a6f89a4e7eaf0623d
https://github.com/Perl/perl5/commit/329f05da8a65a52a20a4557a6f89a4e7eaf0623d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv duplicate clones
These variables are already cloned when creating a thread
Commit: 36b34f87d052d3e438732a132e1724f29b882401
https://github.com/Perl/perl5/commit/36b34f87d052d3e438732a132e1724f29b882401
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv redundant clause
If threaded locales are being used, basic locales are too. No need to
check both
Commit: 9752b4e5fe36b263a4ed9d978866e465c42b7024
https://github.com/Perl/perl5/commit/9752b4e5fe36b263a4ed9d978866e465c42b7024
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
M lib/locale.t
Log Message:
-----------
Fix isspace() handling on AIX
This box incorrectly thinks the NBSP is a graphic on many locales.
Overriding that makes these locales behave like proper POSIX ones.
Commit: ae566ac4332613ec5c8ace66488f2026002b3062
https://github.com/Perl/perl5/commit/ae566ac4332613ec5c8ace66488f2026002b3062
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: White-space only
Replace leading tabs with spaces
Commit: 1a24a11b2c786609dac68c94ecf00c03ada23e03
https://github.com/Perl/perl5/commit/1a24a11b2c786609dac68c94ecf00c03ada23e03
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M hints/cygwin.sh
Log Message:
-----------
XXX check if really necessary after everything: Don't use POSIX 2008 locale
This has been found to be buggy leading to dying inside the newlocale()
in S_emulate_setlocale_i()
Commit: 21c6ad0e703bb7f420c29596c6b4c9363cb21484
https://github.com/Perl/perl5/commit/21c6ad0e703bb7f420c29596c6b4c9363cb21484
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t: Use I18N::Langinfo, not POSIX::localeconv()
Now that Langinfo is ported to every box, it requires less work than
localeconv(), and offers more choices. This commit changes to use it,
and for more info when debugging, gets some additional info from it.
Commit: 669febc5ad288997a91b3fc09cb0502cbcfa4454
https://github.com/Perl/perl5/commit/669febc5ad288997a91b3fc09cb0502cbcfa4454
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX cygwin debugging small macro buf
Commit: 4d78f2d4e50c82188db62b6f81852e601cc6802e
https://github.com/Perl/perl5/commit/4d78f2d4e50c82188db62b6f81852e601cc6802e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Avoid unnecessary calls to set_numeric_standard()
Prior to this commit, set_numeric_standard() was called unconditionally,
and it could decide if it should do anything or not. But the variable
that indicates this is available to the caller, so by testing it, it can
avoid the call, which is most likely the case.
Commit: 845d5e45ec0c92faea071557bd0fe133d7570882
https://github.com/Perl/perl5/commit/845d5e45ec0c92faea071557bd0fe133d7570882
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging trace across all files
Commit: c349c7e5ab8071f2ad4ad927e982c89750f843e4
https://github.com/Perl/perl5/commit/c349c7e5ab8071f2ad4ad927e982c89750f843e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Use internal querylocale on Linux
XXX Need to bisect to see where this goes bad
XXX Is effectively a no-op due to other debugging code
Commit: 921651a307ee2a1fe92ffdfdb9689529dd8c92be
https://github.com/Perl/perl5/commit/921651a307ee2a1fe92ffdfdb9689529dd8c92be
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M handy.h
M iperlsys.h
M locale.c
M perl.h
M pod/perllocale.pod
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: 5eadbf404d9310125159b27908be6e5242de059c
https://github.com/Perl/perl5/commit/5eadbf404d9310125159b27908be6e5242de059c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: b8433b9e0f92270d40c01fe4352842b97c7d670c
https://github.com/Perl/perl5/commit/b8433b9e0f92270d40c01fe4352842b97c7d670c
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/t/Langinfo.t
M ext/POSIX/POSIX.xs
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
35
Compare: https://github.com/Perl/perl5/compare/083b9b8b4856%5E...b8433b9e0f92
