Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 9307dea35c86c6b20ce57fa4f5e8f9c8dd49f1c0
https://github.com/Perl/perl5/commit/9307dea35c86c6b20ce57fa4f5e8f9c8dd49f1c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 474d53ab8e7adbfa8da8d5a35108b0d6ded407a6
https://github.com/Perl/perl5/commit/474d53ab8e7adbfa8da8d5a35108b0d6ded407a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: b33c209d7512a2a43c386c43f624f4d526cf39fe
https://github.com/Perl/perl5/commit/b33c209d7512a2a43c386c43f624f4d526cf39fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 41bb45cb96b04baf1d03d3ce545fb7c9033256a6
https://github.com/Perl/perl5/commit/41bb45cb96b04baf1d03d3ce545fb7c9033256a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: a892b7bd325bb6b943a40df552b9a902e90d1a88
https://github.com/Perl/perl5/commit/a892b7bd325bb6b943a40df552b9a902e90d1a88
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 55035ef6c6456fbc32109839a035e8ab90272372
https://github.com/Perl/perl5/commit/55035ef6c6456fbc32109839a035e8ab90272372
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: d4073027e677c5d97e0b77ea4e765b82bd4e7e7d
https://github.com/Perl/perl5/commit/d4073027e677c5d97e0b77ea4e765b82bd4e7e7d
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: eb7b8fac623ab18e584f1040eae456fba1e7970e
https://github.com/Perl/perl5/commit/eb7b8fac623ab18e584f1040eae456fba1e7970e
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 5c1f915cc2f215ad1e5cd76ba45f4705506088d9
https://github.com/Perl/perl5/commit/5c1f915cc2f215ad1e5cd76ba45f4705506088d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 8ddd3b555ef8dff13d4e056fea358665476305ac
https://github.com/Perl/perl5/commit/8ddd3b555ef8dff13d4e056fea358665476305ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 100db04b2a3bfac76f437d80b34defbe2d1a344a
https://github.com/Perl/perl5/commit/100db04b2a3bfac76f437d80b34defbe2d1a344a
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: e3be02521a34c8972c6aaf8478ff175e062526cf
https://github.com/Perl/perl5/commit/e3be02521a34c8972c6aaf8478ff175e062526cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 1885b7e0691621132dcf6634ffbc88e37472f950
https://github.com/Perl/perl5/commit/1885b7e0691621132dcf6634ffbc88e37472f950
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: ea55a493a85b8976e42ef165fd2e6266dd71bdc3
https://github.com/Perl/perl5/commit/ea55a493a85b8976e42ef165fd2e6266dd71bdc3
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 27fbad5f4e861633b83681b3d2d25b3199c50ab3
https://github.com/Perl/perl5/commit/27fbad5f4e861633b83681b3d2d25b3199c50ab3
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: b4b3fb73eb223193c41398c4a8c043708679136f
https://github.com/Perl/perl5/commit/b4b3fb73eb223193c41398c4a8c043708679136f
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 5bc0850e031f96b79648c55d926e373649661f04
https://github.com/Perl/perl5/commit/5bc0850e031f96b79648c55d926e373649661f04
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: b0ae5931e56235e098e510453f8eb399da2a4c31
https://github.com/Perl/perl5/commit/b0ae5931e56235e098e510453f8eb399da2a4c31
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: d21b857ae523b24154b25120a8bba4a904dcb943
https://github.com/Perl/perl5/commit/d21b857ae523b24154b25120a8bba4a904dcb943
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 59da2db1fd20da2f347e201a2cd5b9a5f663c5b8
https://github.com/Perl/perl5/commit/59da2db1fd20da2f347e201a2cd5b9a5f663c5b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: c8c0085e471238540941cf673e15f5915ab66dde
https://github.com/Perl/perl5/commit/c8c0085e471238540941cf673e15f5915ab66dde
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 03896c06477782bada9acb514e22a6800693e14f
https://github.com/Perl/perl5/commit/03896c06477782bada9acb514e22a6800693e14f
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 2e01023ac35a536d096d745ce594b7ffc284c690
https://github.com/Perl/perl5/commit/2e01023ac35a536d096d745ce594b7ffc284c690
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: c2cc2a38b78f4415b9ec202cff5b13ff29462f80
https://github.com/Perl/perl5/commit/c2cc2a38b78f4415b9ec202cff5b13ff29462f80
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: c0c22025af25762e011b59118c1deb585536c095
https://github.com/Perl/perl5/commit/c0c22025af25762e011b59118c1deb585536c095
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: bba2e368e962eb79db16a0555a61fddad4780336
https://github.com/Perl/perl5/commit/bba2e368e962eb79db16a0555a61fddad4780336
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 7e794f9456652da6f2736abf2a2046145f9d7908
https://github.com/Perl/perl5/commit/7e794f9456652da6f2736abf2a2046145f9d7908
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: aadcdd8f872a7808bc311f0df2902e1a1292fac5
https://github.com/Perl/perl5/commit/aadcdd8f872a7808bc311f0df2902e1a1292fac5
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 6dea051cdf8f85feff455467170119c82c4653e6
https://github.com/Perl/perl5/commit/6dea051cdf8f85feff455467170119c82c4653e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 886baa6830ea89bceba37121542d1f8f590f6967
https://github.com/Perl/perl5/commit/886baa6830ea89bceba37121542d1f8f590f6967
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 76cf44539833652951d3c73fc45dd99bc50492ec
https://github.com/Perl/perl5/commit/76cf44539833652951d3c73fc45dd99bc50492ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 9aaa26f91327a4ffe2ccfe2f63b899c09e4f9026
https://github.com/Perl/perl5/commit/9aaa26f91327a4ffe2ccfe2f63b899c09e4f9026
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: a2b4d835eacbd3f67189f7a2c179be0fbd439872
https://github.com/Perl/perl5/commit/a2b4d835eacbd3f67189f7a2c179be0fbd439872
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: cb3a359da465ae0b550e340b718c3002c98c8bb2
https://github.com/Perl/perl5/commit/cb3a359da465ae0b550e340b718c3002c98c8bb2
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 8d7c555628da5b5898b4ba54557533a05bf7ce5f
https://github.com/Perl/perl5/commit/8d7c555628da5b5898b4ba54557533a05bf7ce5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 1ae5c57084db38bb142592a4310221dcbb385946
https://github.com/Perl/perl5/commit/1ae5c57084db38bb142592a4310221dcbb385946
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: fb08f8f66d4e3c289f4ff8130275e49dd6f294e6
https://github.com/Perl/perl5/commit/fb08f8f66d4e3c289f4ff8130275e49dd6f294e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 8728c810e7c5cb588da0ce4043c34309290db6d7
https://github.com/Perl/perl5/commit/8728c810e7c5cb588da0ce4043c34309290db6d7
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 4ed3a47c39aceb524e7f0f1b30deba2dfe090282
https://github.com/Perl/perl5/commit/4ed3a47c39aceb524e7f0f1b30deba2dfe090282
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 72fb9d6528db195101f4b90d9d90cc2848a80612
https://github.com/Perl/perl5/commit/72fb9d6528db195101f4b90d9d90cc2848a80612
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 92764cc8b821bb2816a7a16cee1f6d56ebb79464
https://github.com/Perl/perl5/commit/92764cc8b821bb2816a7a16cee1f6d56ebb79464
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: be91f282a0999eac1ba45502970d9f8b230d1c25
https://github.com/Perl/perl5/commit/be91f282a0999eac1ba45502970d9f8b230d1c25
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 8ad34a618a487ac116901b8a2617c52c4151aeaf
https://github.com/Perl/perl5/commit/8ad34a618a487ac116901b8a2617c52c4151aeaf
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 7d95390fbd24a8d20e6fa60fa7e84ed28ef3cf1e
https://github.com/Perl/perl5/commit/7d95390fbd24a8d20e6fa60fa7e84ed28ef3cf1e
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 22076e861d7351a619636411fe142ec70e1afb41
https://github.com/Perl/perl5/commit/22076e861d7351a619636411fe142ec70e1afb41
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 96dbb22211662d59fd0b6f4f93ee95c978904109
https://github.com/Perl/perl5/commit/96dbb22211662d59fd0b6f4f93ee95c978904109
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: d950e91d1ce5b35005cf7e5046a51c288dbf86c9
https://github.com/Perl/perl5/commit/d950e91d1ce5b35005cf7e5046a51c288dbf86c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 928c018195356643b6858c050731f59e1e023104
https://github.com/Perl/perl5/commit/928c018195356643b6858c050731f59e1e023104
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 41954cc8299795329e2ef0545de116fe116e82b1
https://github.com/Perl/perl5/commit/41954cc8299795329e2ef0545de116fe116e82b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 9a612d26a3845d0f861a5325add7050e9edea417
https://github.com/Perl/perl5/commit/9a612d26a3845d0f861a5325add7050e9edea417
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 2c8a0929ea85ea41e5eae0569e449f4d5cfe7840
https://github.com/Perl/perl5/commit/2c8a0929ea85ea41e5eae0569e449f4d5cfe7840
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 9562ca7d62e2755540f87b14eaef5b00670f2536
https://github.com/Perl/perl5/commit/9562ca7d62e2755540f87b14eaef5b00670f2536
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: b7649df3aa7104caf74bd84d1616a793c6413221
https://github.com/Perl/perl5/commit/b7649df3aa7104caf74bd84d1616a793c6413221
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: a2a9031c475e954412f5ad78aa6c43d3a5c361a8
https://github.com/Perl/perl5/commit/a2a9031c475e954412f5ad78aa6c43d3a5c361a8
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: bf75134a62f412c936c38ed85d80a15703264f03
https://github.com/Perl/perl5/commit/bf75134a62f412c936c38ed85d80a15703264f03
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 6a9bfe63fb6efaa5411e60f4288bddb50f4e19b9
https://github.com/Perl/perl5/commit/6a9bfe63fb6efaa5411e60f4288bddb50f4e19b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 0ea03451013231d9479b2d8e5324ed214212cd82
https://github.com/Perl/perl5/commit/0ea03451013231d9479b2d8e5324ed214212cd82
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: 9a9b3415d13c2b422ca42bb9c48e26a10bfba18a
https://github.com/Perl/perl5/commit/9a9b3415d13c2b422ca42bb9c48e26a10bfba18a
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: a653e7bb44d28dc03eca90ac926821b367c32ee8
https://github.com/Perl/perl5/commit/a653e7bb44d28dc03eca90ac926821b367c32ee8
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 38f5ff5f1289e3f9ed6106d1cb41743c99b02728
https://github.com/Perl/perl5/commit/38f5ff5f1289e3f9ed6106d1cb41743c99b02728
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 4d954edfd94ac894a81e7829a4a6fb369010f379
https://github.com/Perl/perl5/commit/4d954edfd94ac894a81e7829a4a6fb369010f379
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: a37f12c61d67bdac512982a91be12c7d5cb28824
https://github.com/Perl/perl5/commit/a37f12c61d67bdac512982a91be12c7d5cb28824
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 0be7b5f56cf9168c563903e4f4548f4a98939fdc
https://github.com/Perl/perl5/commit/0be7b5f56cf9168c563903e4f4548f4a98939fdc
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 0d1483ad35ab6a6aab7f7c3b75c2a96b34c5e093
https://github.com/Perl/perl5/commit/0d1483ad35ab6a6aab7f7c3b75c2a96b34c5e093
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 746442f4de51a32077552caf71259c6ba43450e7
https://github.com/Perl/perl5/commit/746442f4de51a32077552caf71259c6ba43450e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 64c108ce1fa9e6742d188b818b28f3a0bba5fabd
https://github.com/Perl/perl5/commit/64c108ce1fa9e6742d188b818b28f3a0bba5fabd
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: b4bf44e572560e47eb7533bcea096fa54c1f3178
https://github.com/Perl/perl5/commit/b4bf44e572560e47eb7533bcea096fa54c1f3178
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 92598ca150496c75e47966cf3058cfe9cb2d5a31
https://github.com/Perl/perl5/commit/92598ca150496c75e47966cf3058cfe9cb2d5a31
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: e5e347f15e0cd904e8a6157f07c6fdcbc31dcb07
https://github.com/Perl/perl5/commit/e5e347f15e0cd904e8a6157f07c6fdcbc31dcb07
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 0845ce1d27a4858c9ae4ffc628fb47b58065a565
https://github.com/Perl/perl5/commit/0845ce1d27a4858c9ae4ffc628fb47b58065a565
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 553d17d3025192ad320928af486885942075d069
https://github.com/Perl/perl5/commit/553d17d3025192ad320928af486885942075d069
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 0e007ec56dd8e29dd578f04438adc119524105e3
https://github.com/Perl/perl5/commit/0e007ec56dd8e29dd578f04438adc119524105e3
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: 4e05a86c87ca469d8a67f9b3d4357791352fc1df
https://github.com/Perl/perl5/commit/4e05a86c87ca469d8a67f9b3d4357791352fc1df
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 6fc259fe3d8e072cd3319cb1b9b0556ad9eaa903
https://github.com/Perl/perl5/commit/6fc259fe3d8e072cd3319cb1b9b0556ad9eaa903
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 189838094f4fbb8007495c32e7e64367ca52e26c
https://github.com/Perl/perl5/commit/189838094f4fbb8007495c32e7e64367ca52e26c
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: f80382e4c8b9c2476431f792cd0153b85cbfc2f7
https://github.com/Perl/perl5/commit/f80382e4c8b9c2476431f792cd0153b85cbfc2f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: ea5c7fee6a331df500fff8f573d06bab8e279e14
https://github.com/Perl/perl5/commit/ea5c7fee6a331df500fff8f573d06bab8e279e14
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 015b147144c65746e25db2a50f4a3e08d5a93a4e
https://github.com/Perl/perl5/commit/015b147144c65746e25db2a50f4a3e08d5a93a4e
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 0f88bdeed081f25ab0f889a1bf7366db462d956b
https://github.com/Perl/perl5/commit/0f88bdeed081f25ab0f889a1bf7366db462d956b
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 7dcaf860ad3b283c1f721487766b0c16248695b6
https://github.com/Perl/perl5/commit/7dcaf860ad3b283c1f721487766b0c16248695b6
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 02e2435d8c2545de4be4abf2c27d8f47cfaa0004
https://github.com/Perl/perl5/commit/02e2435d8c2545de4be4abf2c27d8f47cfaa0004
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 338e9ac63e0d8a31678f3ece907e98839ae207ab
https://github.com/Perl/perl5/commit/338e9ac63e0d8a31678f3ece907e98839ae207ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: e1b9a8b5d64f49f4d7a43bbc74ba602f37971e96
https://github.com/Perl/perl5/commit/e1b9a8b5d64f49f4d7a43bbc74ba602f37971e96
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 6b80ca7177ffeae15417c51cfeb19969427f9af3
https://github.com/Perl/perl5/commit/6b80ca7177ffeae15417c51cfeb19969427f9af3
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: b410a838ecb2ea196c63aee63dbbb00811f39014
https://github.com/Perl/perl5/commit/b410a838ecb2ea196c63aee63dbbb00811f39014
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: df71c876fb766e7f160a133fb6b0eeb186fa5c36
https://github.com/Perl/perl5/commit/df71c876fb766e7f160a133fb6b0eeb186fa5c36
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 5cf6103e75fc7c43557b94c08c8979517ab245c2
https://github.com/Perl/perl5/commit/5cf6103e75fc7c43557b94c08c8979517ab245c2
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: f8a3bce3704d57eae153cce3cec366592ba69058
https://github.com/Perl/perl5/commit/f8a3bce3704d57eae153cce3cec366592ba69058
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 9eebaf9a5e809b7f142452929d282a649d6e1dbd
https://github.com/Perl/perl5/commit/9eebaf9a5e809b7f142452929d282a649d6e1dbd
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: a8b99bc8c90499930c7e77164365f6606a656c42
https://github.com/Perl/perl5/commit/a8b99bc8c90499930c7e77164365f6606a656c42
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 9d7bd50e9705395b99d3ef10a46d1ae9b21f8e04
https://github.com/Perl/perl5/commit/9d7bd50e9705395b99d3ef10a46d1ae9b21f8e04
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 0b3a6341745a44a32dc6036638af4fbf1448d9a9
https://github.com/Perl/perl5/commit/0b3a6341745a44a32dc6036638af4fbf1448d9a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 6ab0ebd0856001ff72e1594f78283993d8340dff
https://github.com/Perl/perl5/commit/6ab0ebd0856001ff72e1594f78283993d8340dff
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: fb40a79589a01280aa873f9b15f142356279356a
https://github.com/Perl/perl5/commit/fb40a79589a01280aa873f9b15f142356279356a
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: eeee5904bba128a2df8620d2478b5a9c31f3d3eb
https://github.com/Perl/perl5/commit/eeee5904bba128a2df8620d2478b5a9c31f3d3eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: 68657ef60d3555203abb92646a5aa6ade43a2ba6
https://github.com/Perl/perl5/commit/68657ef60d3555203abb92646a5aa6ade43a2ba6
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 9dd87c0d9a6266a735e11ee80fb5ca6299cab749
https://github.com/Perl/perl5/commit/9dd87c0d9a6266a735e11ee80fb5ca6299cab749
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 3ee5748c8b2566e34b1af2904cae33bdb71172c1
https://github.com/Perl/perl5/commit/3ee5748c8b2566e34b1af2904cae33bdb71172c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 115647700b004c2faa637a02354d15984babb381
https://github.com/Perl/perl5/commit/115647700b004c2faa637a02354d15984babb381
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: d5860ed5eec7af8d355c63b5bdf9468ea9992b9a
https://github.com/Perl/perl5/commit/d5860ed5eec7af8d355c63b5bdf9468ea9992b9a
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: c30a47eedb8cb84233bb2efaa206263b2af7fbbc
https://github.com/Perl/perl5/commit/c30a47eedb8cb84233bb2efaa206263b2af7fbbc
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: e4c897b3787f443c4559d8ee64df28ae38b2dc9d
https://github.com/Perl/perl5/commit/e4c897b3787f443c4559d8ee64df28ae38b2dc9d
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 88cf348cd03d1cbeff9671e4527adece9bb4a038
https://github.com/Perl/perl5/commit/88cf348cd03d1cbeff9671e4527adece9bb4a038
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 86438df7f3c7bd5320da340a66850a195f76fccc
https://github.com/Perl/perl5/commit/86438df7f3c7bd5320da340a66850a195f76fccc
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 56c4b7de86238e89346b0b33ac115322de61ff52
https://github.com/Perl/perl5/commit/56c4b7de86238e89346b0b33ac115322de61ff52
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: d76faf1845221782226c39eba0966c5dbdf4bf75
https://github.com/Perl/perl5/commit/d76faf1845221782226c39eba0966c5dbdf4bf75
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 699e9faff5353974c67dd8645ebd1db7f91b7122
https://github.com/Perl/perl5/commit/699e9faff5353974c67dd8645ebd1db7f91b7122
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: ac9f10836dd9cf97ba5e59f91766542eed48b220
https://github.com/Perl/perl5/commit/ac9f10836dd9cf97ba5e59f91766542eed48b220
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 5892d1acbe1e6649341fa0205d58d81377b626cc
https://github.com/Perl/perl5/commit/5892d1acbe1e6649341fa0205d58d81377b626cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 7f90f74e1f5d62877883e95b9b7d42e23b7e227e
https://github.com/Perl/perl5/commit/7f90f74e1f5d62877883e95b9b7d42e23b7e227e
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: ab020a5b3681970d16012b6f439322482ac7b5fc
https://github.com/Perl/perl5/commit/ab020a5b3681970d16012b6f439322482ac7b5fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 96e5efedb1f90db3728bf8cc59a404c3de3662ac
https://github.com/Perl/perl5/commit/96e5efedb1f90db3728bf8cc59a404c3de3662ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 9569aee7d356be5fd067255d3fb07f38de2f7524
https://github.com/Perl/perl5/commit/9569aee7d356be5fd067255d3fb07f38de2f7524
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: e76ba8313f5cfc1ea498aa2140cf30d7afb3c399
https://github.com/Perl/perl5/commit/e76ba8313f5cfc1ea498aa2140cf30d7afb3c399
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 7210b02aaa9dd2d015d856bce15b182d9b98187d
https://github.com/Perl/perl5/commit/7210b02aaa9dd2d015d856bce15b182d9b98187d
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: a74d4b0e93360d00520eaeddd1da23395046be61
https://github.com/Perl/perl5/commit/a74d4b0e93360d00520eaeddd1da23395046be61
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 7b192c0cd96c68434ef1418dc0602064d4054037
https://github.com/Perl/perl5/commit/7b192c0cd96c68434ef1418dc0602064d4054037
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: 54fbf055b264944d61885920c1cea5a532de58a3
https://github.com/Perl/perl5/commit/54fbf055b264944d61885920c1cea5a532de58a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 7f5ebd09e791d9bce87e60e48cab4735293b423c
https://github.com/Perl/perl5/commit/7f5ebd09e791d9bce87e60e48cab4735293b423c
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: ddc3f8f508c7b7d94e066d44f917c8e665d19b4d
https://github.com/Perl/perl5/commit/ddc3f8f508c7b7d94e066d44f917c8e665d19b4d
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 2d9a3a2907b286590e1dcfa136aaaf74c95dcbf9
https://github.com/Perl/perl5/commit/2d9a3a2907b286590e1dcfa136aaaf74c95dcbf9
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 9eab67e094cd543bcf8e2f289dcee37af56b95f9
https://github.com/Perl/perl5/commit/9eab67e094cd543bcf8e2f289dcee37af56b95f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 30b9c82744acb9eaa5d9301e665bd8c98f9d461a
https://github.com/Perl/perl5/commit/30b9c82744acb9eaa5d9301e665bd8c98f9d461a
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 35f2f027083dd9ca4b5a1ea8a64a1f2b7848614f
https://github.com/Perl/perl5/commit/35f2f027083dd9ca4b5a1ea8a64a1f2b7848614f
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: f92a92d335d3cb512c5f2ebf2d9312b567d10e25
https://github.com/Perl/perl5/commit/f92a92d335d3cb512c5f2ebf2d9312b567d10e25
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: bf1d57f41501d66f93ac3fb9e69129ff1b9a3686
https://github.com/Perl/perl5/commit/bf1d57f41501d66f93ac3fb9e69129ff1b9a3686
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 9d4f1251f894a4254581a096df8ac5ee3d32cd8d
https://github.com/Perl/perl5/commit/9d4f1251f894a4254581a096df8ac5ee3d32cd8d
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: f9904ad28e7d9976fef17b2789fa5db68251f72f
https://github.com/Perl/perl5/commit/f9904ad28e7d9976fef17b2789fa5db68251f72f
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: 87db8213ec1d8f0cff527217f237097eda6e6dff
https://github.com/Perl/perl5/commit/87db8213ec1d8f0cff527217f237097eda6e6dff
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: 990527a91cd7e1a8ce0835eb347fd11a9f7ad398
https://github.com/Perl/perl5/commit/990527a91cd7e1a8ce0835eb347fd11a9f7ad398
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: dda237a26d965fbfb71a2ed9ff1a8f07f1d908d8
https://github.com/Perl/perl5/commit/dda237a26d965fbfb71a2ed9ff1a8f07f1d908d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: baafc3bc479156eb9f64d73ff243009384906eb9
https://github.com/Perl/perl5/commit/baafc3bc479156eb9f64d73ff243009384906eb9
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: 3b039e531ae54a3e65f1baa45e082aa4d3df9997
https://github.com/Perl/perl5/commit/3b039e531ae54a3e65f1baa45e082aa4d3df9997
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: 98030f0f9db2aaf9f2922fb1937ceb978c8cad32
https://github.com/Perl/perl5/commit/98030f0f9db2aaf9f2922fb1937ceb978c8cad32
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: efbbc8d40674cae35e276deeddc70d80e6b49254
https://github.com/Perl/perl5/commit/efbbc8d40674cae35e276deeddc70d80e6b49254
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: 8a304292d35c7603d8fd80c365fb4b641a8d3474
https://github.com/Perl/perl5/commit/8a304292d35c7603d8fd80c365fb4b641a8d3474
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: cfc1f23be568d340a59a7325ded295b3ee086ac9
https://github.com/Perl/perl5/commit/cfc1f23be568d340a59a7325ded295b3ee086ac9
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: 4a7b9c9f6eae865edd31fd9570a341bc68293198
https://github.com/Perl/perl5/commit/4a7b9c9f6eae865edd31fd9570a341bc68293198
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 514acfb0a19e84c98ea72ca58c25c0f20fc6833f
https://github.com/Perl/perl5/commit/514acfb0a19e84c98ea72ca58c25c0f20fc6833f
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: a8c5b1318bf1513258248157c0da90a72e9e1269
https://github.com/Perl/perl5/commit/a8c5b1318bf1513258248157c0da90a72e9e1269
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 1bd7052900728a3dd514f03fe955d922732dae87
https://github.com/Perl/perl5/commit/1bd7052900728a3dd514f03fe955d922732dae87
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 3736aea0bc2227993d99088f8fd46913ee22c3c0
https://github.com/Perl/perl5/commit/3736aea0bc2227993d99088f8fd46913ee22c3c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 362932eea41b3da13bc9ff3f8f78b1729db4bb57
https://github.com/Perl/perl5/commit/362932eea41b3da13bc9ff3f8f78b1729db4bb57
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: c06c4c2ba383bff5bdf1e87455259230eead964f
https://github.com/Perl/perl5/commit/c06c4c2ba383bff5bdf1e87455259230eead964f
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: lib/locale.t: debug
Commit: e3d82fbe20105540dfadb4fbe6eb4829425e5942
https://github.com/Perl/perl5/commit/e3d82fbe20105540dfadb4fbe6eb4829425e5942
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 56f89dc0834eb7ef1c1ae29232e0537d78c0faba
https://github.com/Perl/perl5/commit/56f89dc0834eb7ef1c1ae29232e0537d78c0faba
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: e1a251f5594e22daaad6a5e41b777166c81b15aa
https://github.com/Perl/perl5/commit/e1a251f5594e22daaad6a5e41b777166c81b15aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 59f8f8aceab79d70c84e05bd15bccb0c7f1b442e
https://github.com/Perl/perl5/commit/59f8f8aceab79d70c84e05bd15bccb0c7f1b442e
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: b0e27d9876d98cff31bbb836aca0c0a1bd0e2771
https://github.com/Perl/perl5/commit/b0e27d9876d98cff31bbb836aca0c0a1bd0e2771
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 0f71fd725331388b3f5f8bbc536a630c0461f4cc
https://github.com/Perl/perl5/commit/0f71fd725331388b3f5f8bbc536a630c0461f4cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 55cbf1c431a3619a427c50fb74f158578bd6842b
https://github.com/Perl/perl5/commit/55cbf1c431a3619a427c50fb74f158578bd6842b
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 38c1284072e658ebea738cc4b18b71c05a2a8904
https://github.com/Perl/perl5/commit/38c1284072e658ebea738cc4b18b71c05a2a8904
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: d2f8fb2f9b51961e821c1f3bff3e1cb955df6249
https://github.com/Perl/perl5/commit/d2f8fb2f9b51961e821c1f3bff3e1cb955df6249
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 36ffe39a5ee2e54077d5a42cf7fc06a767a91472
https://github.com/Perl/perl5/commit/36ffe39a5ee2e54077d5a42cf7fc06a767a91472
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 4ca47376595bcc83edad02c92eba0a2c6f0f3dd1
https://github.com/Perl/perl5/commit/4ca47376595bcc83edad02c92eba0a2c6f0f3dd1
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 3624a5b33b6663147d4ffc21fe478a463b64c014
https://github.com/Perl/perl5/commit/3624a5b33b6663147d4ffc21fe478a463b64c014
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 5de592a9bc1a931140032f63cb3527aad0e52501
https://github.com/Perl/perl5/commit/5de592a9bc1a931140032f63cb3527aad0e52501
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 59f136896569421a5afe2ba27e349afdb38c5d2e
https://github.com/Perl/perl5/commit/59f136896569421a5afe2ba27e349afdb38c5d2e
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 9f284ad5cc6dd7ebedc7035fa9a0c4800ff96d9f
https://github.com/Perl/perl5/commit/9f284ad5cc6dd7ebedc7035fa9a0c4800ff96d9f
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 39491f4e58ad5ac82a6d58315126bb579ee5b203
https://github.com/Perl/perl5/commit/39491f4e58ad5ac82a6d58315126bb579ee5b203
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 89b13674d174b43147558cc2bf549fce6a3f2517
https://github.com/Perl/perl5/commit/89b13674d174b43147558cc2bf549fce6a3f2517
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: a8ce532c7aed87477ca2b16251325c9e863753d6
https://github.com/Perl/perl5/commit/a8ce532c7aed87477ca2b16251325c9e863753d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 6c2d574c1b54f9255c1edac0b32cb58445552fbc
https://github.com/Perl/perl5/commit/6c2d574c1b54f9255c1edac0b32cb58445552fbc
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: ca270589d467541337ed5bccd24fea565f7ad5df
https://github.com/Perl/perl5/commit/ca270589d467541337ed5bccd24fea565f7ad5df
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: f528c3c49532a38b56048b9b70d0f94ae549aff4
https://github.com/Perl/perl5/commit/f528c3c49532a38b56048b9b70d0f94ae549aff4
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 81e09bfde351c170c07a18b78590dd8ce8c79ab4
https://github.com/Perl/perl5/commit/81e09bfde351c170c07a18b78590dd8ce8c79ab4
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 5847b13cc814569809bac0a44141752b58ffd824
https://github.com/Perl/perl5/commit/5847b13cc814569809bac0a44141752b58ffd824
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: bab148682b195317229aa0eba718db26276d1915
https://github.com/Perl/perl5/commit/bab148682b195317229aa0eba718db26276d1915
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: 9c4b369fd203d1385be5687358d215af4ad4a869
https://github.com/Perl/perl5/commit/9c4b369fd203d1385be5687358d215af4ad4a869
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 30a198a1a2b5bacfa9aa0a34a63544f530116229
https://github.com/Perl/perl5/commit/30a198a1a2b5bacfa9aa0a34a63544f530116229
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 01bc836cead980b3496b233c6746a30600afcce7
https://github.com/Perl/perl5/commit/01bc836cead980b3496b233c6746a30600afcce7
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 11f599c8aeff8c6ad57542bb1d86e45bdb9c0f33
https://github.com/Perl/perl5/commit/11f599c8aeff8c6ad57542bb1d86e45bdb9c0f33
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: a272ad39fd26ced508ebff5e72de63e3b2211700
https://github.com/Perl/perl5/commit/a272ad39fd26ced508ebff5e72de63e3b2211700
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: dfdec8f482c5a380845f36384c31fdf372ce4b52
https://github.com/Perl/perl5/commit/dfdec8f482c5a380845f36384c31fdf372ce4b52
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 4ca13c0735dc6a65d56e744eb8a6f324d89dc424
https://github.com/Perl/perl5/commit/4ca13c0735dc6a65d56e744eb8a6f324d89dc424
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 2100fe41b5f911a42e7d8e56ec32e82530407d6e
https://github.com/Perl/perl5/commit/2100fe41b5f911a42e7d8e56ec32e82530407d6e
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: a278e30da3a73ba614ae571da7f9f7cc47007e55
https://github.com/Perl/perl5/commit/a278e30da3a73ba614ae571da7f9f7cc47007e55
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 27a575ce001697747106bbda44969cdcbacd40a4
https://github.com/Perl/perl5/commit/27a575ce001697747106bbda44969cdcbacd40a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 00ed24df606c7a1a2b406b40a6cd322d2bf5f767
https://github.com/Perl/perl5/commit/00ed24df606c7a1a2b406b40a6cd322d2bf5f767
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: a7ee350e76d0118b4e9440edbba09e43d573eccc
https://github.com/Perl/perl5/commit/a7ee350e76d0118b4e9440edbba09e43d573eccc
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: e88da08aaa1f46b74b32863ae93e00e398c2c955
https://github.com/Perl/perl5/commit/e88da08aaa1f46b74b32863ae93e00e398c2c955
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: f07d9ae9096edca8e44c643ea211f6dfdae89872
https://github.com/Perl/perl5/commit/f07d9ae9096edca8e44c643ea211f6dfdae89872
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: bfcaf2ae2744643dc17ff72580636614a725cf52
https://github.com/Perl/perl5/commit/bfcaf2ae2744643dc17ff72580636614a725cf52
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: bd4e3edbb24d60269ba068c760d463ed3a121037
https://github.com/Perl/perl5/commit/bd4e3edbb24d60269ba068c760d463ed3a121037
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 434ea105cdb6bfa62760b5e9b3fd9242646fc9d6
https://github.com/Perl/perl5/commit/434ea105cdb6bfa62760b5e9b3fd9242646fc9d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 35470a8ef57bd596eb99a7ce84af9f5a2ad0340e
https://github.com/Perl/perl5/commit/35470a8ef57bd596eb99a7ce84af9f5a2ad0340e
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: e22d61422f199b1df8cd4a7074afb9d1d221eef2
https://github.com/Perl/perl5/commit/e22d61422f199b1df8cd4a7074afb9d1d221eef2
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: b4322b805b13aae39acda8b5042d89c132a32e44
https://github.com/Perl/perl5/commit/b4322b805b13aae39acda8b5042d89c132a32e44
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 6a478cf35d532608162d0f309788ec767938bc5f
https://github.com/Perl/perl5/commit/6a478cf35d532608162d0f309788ec767938bc5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 8d0e5cb3147ed2eb541441e67c280e42b09f7a47
https://github.com/Perl/perl5/commit/8d0e5cb3147ed2eb541441e67c280e42b09f7a47
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 0d5eec7af54a1b78b4f728c6e5cb694d87fbb17e
https://github.com/Perl/perl5/commit/0d5eec7af54a1b78b4f728c6e5cb694d87fbb17e
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 55f02ca1f1b7f66e328392a9ebed1b2f933f65aa
https://github.com/Perl/perl5/commit/55f02ca1f1b7f66e328392a9ebed1b2f933f65aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 95b3ef7d2a413ecbd87b1ddf52452eca443d5dd6
https://github.com/Perl/perl5/commit/95b3ef7d2a413ecbd87b1ddf52452eca443d5dd6
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 86c1f6c320a1883c0a42712ddd4b38aca5eae6bb
https://github.com/Perl/perl5/commit/86c1f6c320a1883c0a42712ddd4b38aca5eae6bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: d765dda10039c66481379a5381508f6e6e6048f9
https://github.com/Perl/perl5/commit/d765dda10039c66481379a5381508f6e6e6048f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: a11851ceb5e91daa75cf1c4909159307de5a0286
https://github.com/Perl/perl5/commit/a11851ceb5e91daa75cf1c4909159307de5a0286
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: c3c959e521564d76ff209a700c0ee8c38623232d
https://github.com/Perl/perl5/commit/c3c959e521564d76ff209a700c0ee8c38623232d
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: c371615dc3046d5f9d9c73c81ea352df4b0f1575
https://github.com/Perl/perl5/commit/c371615dc3046d5f9d9c73c81ea352df4b0f1575
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: ce69330906dbeb0b0c511876d3007ad63c30e0c8
https://github.com/Perl/perl5/commit/ce69330906dbeb0b0c511876d3007ad63c30e0c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 526c62c71b114efd55351df0158860b5c9b5cab0
https://github.com/Perl/perl5/commit/526c62c71b114efd55351df0158860b5c9b5cab0
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 4d637908b58cf153f512bb22292c401df34a408a
https://github.com/Perl/perl5/commit/4d637908b58cf153f512bb22292c401df34a408a
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 6cb8e3472f575d13a008e5a6fea14f1897922122
https://github.com/Perl/perl5/commit/6cb8e3472f575d13a008e5a6fea14f1897922122
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 013351a53185d47b0d10edb552d7580c3d6edb73
https://github.com/Perl/perl5/commit/013351a53185d47b0d10edb552d7580c3d6edb73
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 61b9d1e8669f932df6db35723a530e1cb9dc19c5
https://github.com/Perl/perl5/commit/61b9d1e8669f932df6db35723a530e1cb9dc19c5
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: c1b5810656c807ce3439ac03d8978c201e27be69
https://github.com/Perl/perl5/commit/c1b5810656c807ce3439ac03d8978c201e27be69
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: bc93fc45272f9fc44019964f6ad85eb0444f55ee
https://github.com/Perl/perl5/commit/bc93fc45272f9fc44019964f6ad85eb0444f55ee
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 7f65c53552feebb65965e3c59a831108874f20df
https://github.com/Perl/perl5/commit/7f65c53552feebb65965e3c59a831108874f20df
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 12224baa6ba93115eeb25ee6cf0739d9d352b4d4
https://github.com/Perl/perl5/commit/12224baa6ba93115eeb25ee6cf0739d9d352b4d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: d89bebab4dd1801963c0a6804b627fcc4d7c024b
https://github.com/Perl/perl5/commit/d89bebab4dd1801963c0a6804b627fcc4d7c024b
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: baeabbbd2b697730101388a6bb8e9414dd4f6fed
https://github.com/Perl/perl5/commit/baeabbbd2b697730101388a6bb8e9414dd4f6fed
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 60d14a9d4b9a9c5c8a2e11235de1dab91a26cb59
https://github.com/Perl/perl5/commit/60d14a9d4b9a9c5c8a2e11235de1dab91a26cb59
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: f8ae5162e58292234cfe2233e2acee8d90df7526
https://github.com/Perl/perl5/commit/f8ae5162e58292234cfe2233e2acee8d90df7526
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 5449d3cdbfcbde997a8f2d3ccc89c14f825907ec
https://github.com/Perl/perl5/commit/5449d3cdbfcbde997a8f2d3ccc89c14f825907ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 2842f83147eea12a12a6bfa21db80eba4aef3f3a
https://github.com/Perl/perl5/commit/2842f83147eea12a12a6bfa21db80eba4aef3f3a
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 665f94a9ef9aab0aa8df72e291cb76105d42d4c2
https://github.com/Perl/perl5/commit/665f94a9ef9aab0aa8df72e291cb76105d42d4c2
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 538fa71154c88f44d05c92c9635f6948697f587c
https://github.com/Perl/perl5/commit/538fa71154c88f44d05c92c9635f6948697f587c
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: f73400cad3c9c7d73f652983822bc8f8ce643285
https://github.com/Perl/perl5/commit/f73400cad3c9c7d73f652983822bc8f8ce643285
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 1147261fb12bdac5055d40cefe2d4918006f28ab
https://github.com/Perl/perl5/commit/1147261fb12bdac5055d40cefe2d4918006f28ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: f99f8324656a3f4034b6feafaa754b54dd077a79
https://github.com/Perl/perl5/commit/f99f8324656a3f4034b6feafaa754b54dd077a79
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: 7217ee69a02fc5c4173fddd4e75bf47e83c2787b
https://github.com/Perl/perl5/commit/7217ee69a02fc5c4173fddd4e75bf47e83c2787b
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: 152913e8550c674bb45cd390f4f81e44cd26ebee
https://github.com/Perl/perl5/commit/152913e8550c674bb45cd390f4f81e44cd26ebee
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: 421dffb4c231109ae50687bf35d9326ab4c36baf
https://github.com/Perl/perl5/commit/421dffb4c231109ae50687bf35d9326ab4c36baf
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: b9514c968097c04aa229d1138747dbf283a78d77
https://github.com/Perl/perl5/commit/b9514c968097c04aa229d1138747dbf283a78d77
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: b2a2eaf2474aa2c506397ca023bb6e54a30e891c
https://github.com/Perl/perl5/commit/b2a2eaf2474aa2c506397ca023bb6e54a30e891c
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: c99848f20c0652663a66397311a17cc3f523efa6
https://github.com/Perl/perl5/commit/c99848f20c0652663a66397311a17cc3f523efa6
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: 1eda0b2c7310e13937d53bdca9d244c7eb3a1eb9
https://github.com/Perl/perl5/commit/1eda0b2c7310e13937d53bdca9d244c7eb3a1eb9
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: ecc9e6c62448753592f2ad118d159435bc7e829d
https://github.com/Perl/perl5/commit/ecc9e6c62448753592f2ad118d159435bc7e829d
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 8ec761fb22b27b492d8ebc2fe60aec7fc808db58
https://github.com/Perl/perl5/commit/8ec761fb22b27b492d8ebc2fe60aec7fc808db58
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 9c0360b77e8d521d79b4859b3fcd0b7129ec72c2
https://github.com/Perl/perl5/commit/9c0360b77e8d521d79b4859b3fcd0b7129ec72c2
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: 575a11751e52ebfc2c41269537c09a7b2ea82ee1
https://github.com/Perl/perl5/commit/575a11751e52ebfc2c41269537c09a7b2ea82ee1
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: cc26f2bed9609b6b90805bb0a9f55380153701e2
https://github.com/Perl/perl5/commit/cc26f2bed9609b6b90805bb0a9f55380153701e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: 523c50e368150bb4836574ab6575f9b438304f13
https://github.com/Perl/perl5/commit/523c50e368150bb4836574ab6575f9b438304f13
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: aa2f05a50c1c7551b37005cff62ccc3a29e3d8b1
https://github.com/Perl/perl5/commit/aa2f05a50c1c7551b37005cff62ccc3a29e3d8b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: c8a2d99909f8427eef6849dad22ea598acd47390
https://github.com/Perl/perl5/commit/c8a2d99909f8427eef6849dad22ea598acd47390
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: ac84d2a984133a87c0cc7cd0dc9c3ded48f07a9a
https://github.com/Perl/perl5/commit/ac84d2a984133a87c0cc7cd0dc9c3ded48f07a9a
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: 3847f5222dbdc08553ed5206ca550029495fc543
https://github.com/Perl/perl5/commit/3847f5222dbdc08553ed5206ca550029495fc543
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: 287681ee969a2044b1bbf80db891ade4939a5fc6
https://github.com/Perl/perl5/commit/287681ee969a2044b1bbf80db891ade4939a5fc6
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: 433826b1344740b80b43ac021355b88a28faaae2
https://github.com/Perl/perl5/commit/433826b1344740b80b43ac021355b88a28faaae2
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: 00ecb005b26a97be85ed42fde40ce70494d25509
https://github.com/Perl/perl5/commit/00ecb005b26a97be85ed42fde40ce70494d25509
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: d27807c64ee8bc67d273671469b4bc6487263c70
https://github.com/Perl/perl5/commit/d27807c64ee8bc67d273671469b4bc6487263c70
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 438539eb59b090386dfe9d6425de18eefdacc6ff
https://github.com/Perl/perl5/commit/438539eb59b090386dfe9d6425de18eefdacc6ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads debugging
Commit: 2f0efe84591e0d714a41060039adbea0e1947053
https://github.com/Perl/perl5/commit/2f0efe84591e0d714a41060039adbea0e1947053
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: 126e12f5d658afae3439eb6a95bd3c916851e45e
https://github.com/Perl/perl5/commit/126e12f5d658afae3439eb6a95bd3c916851e45e
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: 413a8ab8c796604bf1838b6a241caccb3c8839c9
https://github.com/Perl/perl5/commit/413a8ab8c796604bf1838b6a241caccb3c8839c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg,thread_init Revamp sync_locale, switch_to_global_locale
f
Commit: f8c02919df25f5b0f76a5a04231187a0eae4f484
https://github.com/Perl/perl5/commit/f8c02919df25f5b0f76a5a04231187a0eae4f484
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv duplicate clones
These variables are already cloned when creating a thread
Commit: 5839059a981818058119d076141a6650353a6df4
https://github.com/Perl/perl5/commit/5839059a981818058119d076141a6650353a6df4
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv redundant clause
If threaded locales are being used, basic locales are too. No need to
check both
Commit: 5c660314fd735f761527025be3403bdd7df29b63
https://github.com/Perl/perl5/commit/5c660314fd735f761527025be3403bdd7df29b63
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
M lib/locale.t
Log Message:
-----------
Fix isspace() handling on AIX
This box incorrectly thinks the NBSP is a graphic on many locales.
Overriding that makes these locales behave like proper POSIX ones.
Commit: 3ef21a57435317c79fe6d26f3974c21d887eb307
https://github.com/Perl/perl5/commit/3ef21a57435317c79fe6d26f3974c21d887eb307
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: White-space only
Replace leading tabs with spaces
Commit: cc9381952e9730df1bc48a4c4d5984b0d8e976f2
https://github.com/Perl/perl5/commit/cc9381952e9730df1bc48a4c4d5984b0d8e976f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M hints/cygwin.sh
Log Message:
-----------
XXX check if really necessary after everything: Don't use POSIX 2008 locale
This has been found to be buggy leading to dying inside the newlocale()
in S_emulate_setlocale_i()
Commit: 5c3e621fdb3782091904360caafb7ae142fa47a7
https://github.com/Perl/perl5/commit/5c3e621fdb3782091904360caafb7ae142fa47a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t: Use I18N::Langinfo, not POSIX::localeconv()
Now that Langinfo is ported to every box, it requires less work than
localeconv(), and offers more choices. This commit changes to use it,
and for more info when debugging, gets some additional info from it.
Commit: 95de422698abc2ab50eca13ae97713cb81f8376a
https://github.com/Perl/perl5/commit/95de422698abc2ab50eca13ae97713cb81f8376a
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX cygwin debugging small macro buf
Commit: c0a516f2145869aa64993afc08fab74c13cb7a93
https://github.com/Perl/perl5/commit/c0a516f2145869aa64993afc08fab74c13cb7a93
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Avoid unnecessary calls to set_numeric_standard()
Prior to this commit, set_numeric_standard() was called unconditionally,
and it could decide if it should do anything or not. But the variable
that indicates this is available to the caller, so by testing it, it can
avoid the call, which is most likely the case.
Commit: d7163c5af345e250bde08483af65be3faedeabda
https://github.com/Perl/perl5/commit/d7163c5af345e250bde08483af65be3faedeabda
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging trace across all files
Commit: 70ded52d39100f359ac259000eae4af2e9597460
https://github.com/Perl/perl5/commit/70ded52d39100f359ac259000eae4af2e9597460
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Use internal querylocale on Linux
XXX Need to bisect to see where this goes bad
XXX Is effectively a no-op due to other debugging code
Commit: f21fbd70cf04dd422d3effb75247f303a8eabde4
https://github.com/Perl/perl5/commit/f21fbd70cf04dd422d3effb75247f303a8eabde4
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M handy.h
M iperlsys.h
M locale.c
M perl.h
M pod/perllocale.pod
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: 118c83307c9cff500a9ae80cf7d095c50fffe5db
https://github.com/Perl/perl5/commit/118c83307c9cff500a9ae80cf7d095c50fffe5db
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 0381d0d0073aee806512fe8647a7a9a831df41e8
https://github.com/Perl/perl5/commit/0381d0d0073aee806512fe8647a7a9a831df41e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-20 (Tue, 20 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/t/Langinfo.t
M ext/POSIX/POSIX.xs
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
36
Compare: https://github.com/Perl/perl5/compare/1f7f82a46d0f...0381d0d0073a
