Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 342f8139fa260a6c833ea11ac7fe1320b8f2cf7e
https://github.com/Perl/perl5/commit/342f8139fa260a6c833ea11ac7fe1320b8f2cf7e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 0ec1c4d773307779bdd5025e650c682340c23615
https://github.com/Perl/perl5/commit/0ec1c4d773307779bdd5025e650c682340c23615
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: feb4642881a924f7b28a85245e02e2871e3f9481
https://github.com/Perl/perl5/commit/feb4642881a924f7b28a85245e02e2871e3f9481
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: c9e2c09c7accb3c4d5e6e427a1906529238d92ae
https://github.com/Perl/perl5/commit/c9e2c09c7accb3c4d5e6e427a1906529238d92ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: b2ea1e4ae32c76cade6e85e844ed47de888de2f7
https://github.com/Perl/perl5/commit/b2ea1e4ae32c76cade6e85e844ed47de888de2f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: c9643760d8077191d18192edc5e6bbf86c34606b
https://github.com/Perl/perl5/commit/c9643760d8077191d18192edc5e6bbf86c34606b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 78ffbdb5cf0158bcea322ce0cf5c88358c9047ad
https://github.com/Perl/perl5/commit/78ffbdb5cf0158bcea322ce0cf5c88358c9047ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 38ed0429543404c5a978e1721647578873f22904
https://github.com/Perl/perl5/commit/38ed0429543404c5a978e1721647578873f22904
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 7430ab71df9ebd039b38c7d23d8d5579cb2b0963
https://github.com/Perl/perl5/commit/7430ab71df9ebd039b38c7d23d8d5579cb2b0963
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 2adfd7b552b76bfd533d4c2a37572f98081a5fea
https://github.com/Perl/perl5/commit/2adfd7b552b76bfd533d4c2a37572f98081a5fea
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 209733ed871932778919464687af2f8170769b83
https://github.com/Perl/perl5/commit/209733ed871932778919464687af2f8170769b83
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 1fbdb3a28b63632ab0ac19f90c1da058931c60e0
https://github.com/Perl/perl5/commit/1fbdb3a28b63632ab0ac19f90c1da058931c60e0
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 6bf051bb3e357d34abd167ae88e19134af852c7c
https://github.com/Perl/perl5/commit/6bf051bb3e357d34abd167ae88e19134af852c7c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 72f88c5e216e61843a0ea218f368675fb4ec0661
https://github.com/Perl/perl5/commit/72f88c5e216e61843a0ea218f368675fb4ec0661
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 7751c608022d0ecf7d8e9e0242a026db3d9e9919
https://github.com/Perl/perl5/commit/7751c608022d0ecf7d8e9e0242a026db3d9e9919
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 2e2a516410e1e4e69771f44b2923c9dbb421f83a
https://github.com/Perl/perl5/commit/2e2a516410e1e4e69771f44b2923c9dbb421f83a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 3089d8299b44143c85e35320e6de0bd9bed9fd6c
https://github.com/Perl/perl5/commit/3089d8299b44143c85e35320e6de0bd9bed9fd6c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 2cf161962dc78bea18a7ef437a15a9f8eed7cedf
https://github.com/Perl/perl5/commit/2cf161962dc78bea18a7ef437a15a9f8eed7cedf
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 73896cd46292588de48892de7a92d37e4705f954
https://github.com/Perl/perl5/commit/73896cd46292588de48892de7a92d37e4705f954
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 7a340549ac07097c2c15fd33691a316928059ac6
https://github.com/Perl/perl5/commit/7a340549ac07097c2c15fd33691a316928059ac6
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 672dd8eb79f1d662005c7d184edb542d5421cb3c
https://github.com/Perl/perl5/commit/672dd8eb79f1d662005c7d184edb542d5421cb3c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 0d6ee54bc1ce7689a9e6434167b786c991dcfb41
https://github.com/Perl/perl5/commit/0d6ee54bc1ce7689a9e6434167b786c991dcfb41
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: eda705848fb37d08d7516c58c67863daca1d440b
https://github.com/Perl/perl5/commit/eda705848fb37d08d7516c58c67863daca1d440b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 5a109c7ee8743a4e66831841245c3431e4339334
https://github.com/Perl/perl5/commit/5a109c7ee8743a4e66831841245c3431e4339334
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 6f6e25f2a53e6e6660df03012b074715da191f54
https://github.com/Perl/perl5/commit/6f6e25f2a53e6e6660df03012b074715da191f54
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: a35293dce411f9500d8d794c30481b0ca2a95799
https://github.com/Perl/perl5/commit/a35293dce411f9500d8d794c30481b0ca2a95799
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 10db32c2bb8fab770a773ec62eba246213dffdea
https://github.com/Perl/perl5/commit/10db32c2bb8fab770a773ec62eba246213dffdea
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 7e5d63b8049090b8de325aec6256a4e82583bc86
https://github.com/Perl/perl5/commit/7e5d63b8049090b8de325aec6256a4e82583bc86
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 89874c050b653f7758398363e0fb0effde414068
https://github.com/Perl/perl5/commit/89874c050b653f7758398363e0fb0effde414068
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 70d738636ecdc3cd975c048142e7f70fe439e582
https://github.com/Perl/perl5/commit/70d738636ecdc3cd975c048142e7f70fe439e582
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 4363394c9270d31534caa642ca3053028b24b5d3
https://github.com/Perl/perl5/commit/4363394c9270d31534caa642ca3053028b24b5d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 7f435521d39ec7408015e7306f5431f4bcbe789e
https://github.com/Perl/perl5/commit/7f435521d39ec7408015e7306f5431f4bcbe789e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: f553ac2947b6ce13f50c267cdedd9ea7596a0f9e
https://github.com/Perl/perl5/commit/f553ac2947b6ce13f50c267cdedd9ea7596a0f9e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 390da6497e7f71e640031fd2547e358b2ebce7b7
https://github.com/Perl/perl5/commit/390da6497e7f71e640031fd2547e358b2ebce7b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 4190bf1daae798045e4c7cb64783f7c0f49a8fde
https://github.com/Perl/perl5/commit/4190bf1daae798045e4c7cb64783f7c0f49a8fde
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: b9d6e2aba903eea03238b8c220a424db2e6ffd5e
https://github.com/Perl/perl5/commit/b9d6e2aba903eea03238b8c220a424db2e6ffd5e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: d046c3d21567e8a63cd11a216289b4f32497ee3a
https://github.com/Perl/perl5/commit/d046c3d21567e8a63cd11a216289b4f32497ee3a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 6d0e61f19587c50918e5a6356909c1a906b145ac
https://github.com/Perl/perl5/commit/6d0e61f19587c50918e5a6356909c1a906b145ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 9373b2de81f877b332dc24555d2e1918222424d9
https://github.com/Perl/perl5/commit/9373b2de81f877b332dc24555d2e1918222424d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 176b5620b6810431090fa6e51fc51929987c715c
https://github.com/Perl/perl5/commit/176b5620b6810431090fa6e51fc51929987c715c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: aa535b09cef101840882efe76fd772bead64a2cf
https://github.com/Perl/perl5/commit/aa535b09cef101840882efe76fd772bead64a2cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 05aa4db51fc44e5c79c4a4c04e3e966f5bb7a71f
https://github.com/Perl/perl5/commit/05aa4db51fc44e5c79c4a4c04e3e966f5bb7a71f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 3fe5343e8d83e05662ce9979490b0fc3ce8a5e72
https://github.com/Perl/perl5/commit/3fe5343e8d83e05662ce9979490b0fc3ce8a5e72
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 6feb5776a999126c494195493988fa95d668f678
https://github.com/Perl/perl5/commit/6feb5776a999126c494195493988fa95d668f678
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 76c446eb78f2aa367224c0f346049d187a5f7b0d
https://github.com/Perl/perl5/commit/76c446eb78f2aa367224c0f346049d187a5f7b0d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 8f991b2ac9efed3ad52598a62749634af7ad8567
https://github.com/Perl/perl5/commit/8f991b2ac9efed3ad52598a62749634af7ad8567
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 4d39779452cd907c4cb96733f4206258364e73de
https://github.com/Perl/perl5/commit/4d39779452cd907c4cb96733f4206258364e73de
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 53c2d93151381e17f7a2eb5c11be574f7a69e2bc
https://github.com/Perl/perl5/commit/53c2d93151381e17f7a2eb5c11be574f7a69e2bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 02d1e37879a704d73a0db45ecd1281a3d44dd562
https://github.com/Perl/perl5/commit/02d1e37879a704d73a0db45ecd1281a3d44dd562
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 22f7c5c91f7b8b4d1d9215fd02f2d7ac06eaae70
https://github.com/Perl/perl5/commit/22f7c5c91f7b8b4d1d9215fd02f2d7ac06eaae70
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 0b6962286e007f1f1ce61a9c03337c2e2d55754d
https://github.com/Perl/perl5/commit/0b6962286e007f1f1ce61a9c03337c2e2d55754d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: f4efea52ffe61fc837505bf20e3680437bd60a02
https://github.com/Perl/perl5/commit/f4efea52ffe61fc837505bf20e3680437bd60a02
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: d749b0b957e25af7ce7d01c8ec3d46eb55af62a4
https://github.com/Perl/perl5/commit/d749b0b957e25af7ce7d01c8ec3d46eb55af62a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 8d84f92a97d5e60ea73d3d5cd8ec9e5f80f6a05c
https://github.com/Perl/perl5/commit/8d84f92a97d5e60ea73d3d5cd8ec9e5f80f6a05c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: a27e81c939f117d011f5fdb221e5f4d09d3d0cb1
https://github.com/Perl/perl5/commit/a27e81c939f117d011f5fdb221e5f4d09d3d0cb1
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 9cd52b989ac230afce7b113b44e51aae9a4ec336
https://github.com/Perl/perl5/commit/9cd52b989ac230afce7b113b44e51aae9a4ec336
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 12d3bcf0cd83ee5c2d0206bc4d4586a11d7c8f27
https://github.com/Perl/perl5/commit/12d3bcf0cd83ee5c2d0206bc4d4586a11d7c8f27
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: 1ca0f490b9d27d5c5ec4186734a1c06439ee3572
https://github.com/Perl/perl5/commit/1ca0f490b9d27d5c5ec4186734a1c06439ee3572
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: ebf07780c7b1cef93c1566d061c17baa5a9c051e
https://github.com/Perl/perl5/commit/ebf07780c7b1cef93c1566d061c17baa5a9c051e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 9341feb2e6fe8aad40131a980fb7e77a97937d84
https://github.com/Perl/perl5/commit/9341feb2e6fe8aad40131a980fb7e77a97937d84
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 7a8948c3f0fb55158e17b6e5fa8aa9e3d9d8ee3d
https://github.com/Perl/perl5/commit/7a8948c3f0fb55158e17b6e5fa8aa9e3d9d8ee3d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: f1bfc6ef98423efe38681698453f87f46e1468aa
https://github.com/Perl/perl5/commit/f1bfc6ef98423efe38681698453f87f46e1468aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: a24c9b3b22032999599db223e63fb268e68ca49e
https://github.com/Perl/perl5/commit/a24c9b3b22032999599db223e63fb268e68ca49e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 48cf223dc25704d866923d1f00d3d0a7dcfaaf87
https://github.com/Perl/perl5/commit/48cf223dc25704d866923d1f00d3d0a7dcfaaf87
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 3d306b1b49372fe0ec27ae923a99e7eab69bd2a5
https://github.com/Perl/perl5/commit/3d306b1b49372fe0ec27ae923a99e7eab69bd2a5
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 5b0a078376daa639b18f08c93b59b5dcd8e67e89
https://github.com/Perl/perl5/commit/5b0a078376daa639b18f08c93b59b5dcd8e67e89
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 71b736f79a01f51d5a7b5263dc3388387ea8e222
https://github.com/Perl/perl5/commit/71b736f79a01f51d5a7b5263dc3388387ea8e222
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 4ee8b59ee19adc0feb204ef744aa57776982ed7e
https://github.com/Perl/perl5/commit/4ee8b59ee19adc0feb204ef744aa57776982ed7e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 031eaea2492a2119da19e4f1520d599db7d2a4ce
https://github.com/Perl/perl5/commit/031eaea2492a2119da19e4f1520d599db7d2a4ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 05d403872056f2dd3cff767b9fd6caab26cd1739
https://github.com/Perl/perl5/commit/05d403872056f2dd3cff767b9fd6caab26cd1739
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: e051f2105cf35439cf8ad4769a6901e0733242f1
https://github.com/Perl/perl5/commit/e051f2105cf35439cf8ad4769a6901e0733242f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 13d719accc0d702d187d3033f1ac0ef0c9b7351d
https://github.com/Perl/perl5/commit/13d719accc0d702d187d3033f1ac0ef0c9b7351d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: 16365608d0bafe5255e8447c610c4e99ee9b21e5
https://github.com/Perl/perl5/commit/16365608d0bafe5255e8447c610c4e99ee9b21e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 93c2d36eb5a0a908d827034044018989cfb9b4ab
https://github.com/Perl/perl5/commit/93c2d36eb5a0a908d827034044018989cfb9b4ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 282a053aab8fd3fa4d83fac16f2085c8d8d1fa4d
https://github.com/Perl/perl5/commit/282a053aab8fd3fa4d83fac16f2085c8d8d1fa4d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 2381854a30524256d5d206cff8e9d97d71ad86f1
https://github.com/Perl/perl5/commit/2381854a30524256d5d206cff8e9d97d71ad86f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 1fde1af3a5b5fe79ce1eb10a967781d3a8d83fd1
https://github.com/Perl/perl5/commit/1fde1af3a5b5fe79ce1eb10a967781d3a8d83fd1
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: ad1ab0b3942d866f61db01416a2f5faf4a60df2f
https://github.com/Perl/perl5/commit/ad1ab0b3942d866f61db01416a2f5faf4a60df2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: d827510d2c08b62d964df5db589ce1a9fb4d2963
https://github.com/Perl/perl5/commit/d827510d2c08b62d964df5db589ce1a9fb4d2963
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: e747e67b4b7214e2b3017777e9ee2bf4067f442d
https://github.com/Perl/perl5/commit/e747e67b4b7214e2b3017777e9ee2bf4067f442d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 86e03434732d2fb5227b3b51b13f4c6c9b988796
https://github.com/Perl/perl5/commit/86e03434732d2fb5227b3b51b13f4c6c9b988796
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: e6e823248d16d783d3b73705224234214c8777c6
https://github.com/Perl/perl5/commit/e6e823248d16d783d3b73705224234214c8777c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 4786190d515b236e4bd956becb7ce7d150ec06f6
https://github.com/Perl/perl5/commit/4786190d515b236e4bd956becb7ce7d150ec06f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: ce0f8197f6f0c68c675ea232379f6c2510399bf3
https://github.com/Perl/perl5/commit/ce0f8197f6f0c68c675ea232379f6c2510399bf3
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: a56c00dfe39e23877fd163ac3f1a49ed27583cb8
https://github.com/Perl/perl5/commit/a56c00dfe39e23877fd163ac3f1a49ed27583cb8
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 40a84309193c6fb2d692fce1715a7add08c84b6a
https://github.com/Perl/perl5/commit/40a84309193c6fb2d692fce1715a7add08c84b6a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 12be6a4dcc0502be1b124769ebec31283eb33ee2
https://github.com/Perl/perl5/commit/12be6a4dcc0502be1b124769ebec31283eb33ee2
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: e994c567e95e3fc9bd2b7139a5f0b0016f8ffda9
https://github.com/Perl/perl5/commit/e994c567e95e3fc9bd2b7139a5f0b0016f8ffda9
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 08fe623152d201f6562ad9e551daf06dcfafdc0b
https://github.com/Perl/perl5/commit/08fe623152d201f6562ad9e551daf06dcfafdc0b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 563c347023585c8803a8212f005d2c947a6a9fba
https://github.com/Perl/perl5/commit/563c347023585c8803a8212f005d2c947a6a9fba
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 8613e322d9a717dc8f89ca50e1072d1296453e92
https://github.com/Perl/perl5/commit/8613e322d9a717dc8f89ca50e1072d1296453e92
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: a4239b8ec653ab472cc774f13718df0ac8d14b92
https://github.com/Perl/perl5/commit/a4239b8ec653ab472cc774f13718df0ac8d14b92
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 4e0617ef910200b51fc43e5462c4227a8b9a9e60
https://github.com/Perl/perl5/commit/4e0617ef910200b51fc43e5462c4227a8b9a9e60
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 61aca2848c14cef62f808d290238d1d0842f0d97
https://github.com/Perl/perl5/commit/61aca2848c14cef62f808d290238d1d0842f0d97
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 41e52fdee14ce811cd1fd4a69c66f3fd7ea15239
https://github.com/Perl/perl5/commit/41e52fdee14ce811cd1fd4a69c66f3fd7ea15239
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: 3cabab3b049f35f6b21296ac6081cd61c3532ddb
https://github.com/Perl/perl5/commit/3cabab3b049f35f6b21296ac6081cd61c3532ddb
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 5167e718c81c5798bdc573e9398f98a0b5eefef8
https://github.com/Perl/perl5/commit/5167e718c81c5798bdc573e9398f98a0b5eefef8
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 9836703c658fc788565c28d8819401c19e1d1f3c
https://github.com/Perl/perl5/commit/9836703c658fc788565c28d8819401c19e1d1f3c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: b6bc9c66a0154c5e4a1fa73fc2799242802f9e30
https://github.com/Perl/perl5/commit/b6bc9c66a0154c5e4a1fa73fc2799242802f9e30
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 207555db1f4386aab687c96b307d7399f1ca968f
https://github.com/Perl/perl5/commit/207555db1f4386aab687c96b307d7399f1ca968f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: af2948f34bae39187b5f89f113a7167e9934e70d
https://github.com/Perl/perl5/commit/af2948f34bae39187b5f89f113a7167e9934e70d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: ca5ebb2ebd693c266792348d9ef0b65f1902cb4a
https://github.com/Perl/perl5/commit/ca5ebb2ebd693c266792348d9ef0b65f1902cb4a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: f8e4100db8f06d3923da312bf8df85b8b94c99ea
https://github.com/Perl/perl5/commit/f8e4100db8f06d3923da312bf8df85b8b94c99ea
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 9b961ad657602374e07179479269cb4a2bbf464b
https://github.com/Perl/perl5/commit/9b961ad657602374e07179479269cb4a2bbf464b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 21ab51c6b21ab5d6a274581110a4dac6b457f1af
https://github.com/Perl/perl5/commit/21ab51c6b21ab5d6a274581110a4dac6b457f1af
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 1beec23cb1823c35c8edc56b1291f66d521d02eb
https://github.com/Perl/perl5/commit/1beec23cb1823c35c8edc56b1291f66d521d02eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 6d861060506b2760d5e3ebad1b0f7eac25ef4e20
https://github.com/Perl/perl5/commit/6d861060506b2760d5e3ebad1b0f7eac25ef4e20
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: e1623c057d359dfc8d93ea824dc875dd112ffb4e
https://github.com/Perl/perl5/commit/e1623c057d359dfc8d93ea824dc875dd112ffb4e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 5e4e695beb7944054bb0405c02798033ec94b9f0
https://github.com/Perl/perl5/commit/5e4e695beb7944054bb0405c02798033ec94b9f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 01248bc67a1d0f3a7f0c5a6354c5e6a99d0ad37a
https://github.com/Perl/perl5/commit/01248bc67a1d0f3a7f0c5a6354c5e6a99d0ad37a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: e678880fe689aa8a9d1326b3afdcafe52ea32227
https://github.com/Perl/perl5/commit/e678880fe689aa8a9d1326b3afdcafe52ea32227
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: e3885dd28b824c1400426ddc6d8e08e35922b5cf
https://github.com/Perl/perl5/commit/e3885dd28b824c1400426ddc6d8e08e35922b5cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: a533a5e91dce1a970c5d28dabad065abc701f29d
https://github.com/Perl/perl5/commit/a533a5e91dce1a970c5d28dabad065abc701f29d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 05d416798f3ef09071af7269bf4335306b45acf3
https://github.com/Perl/perl5/commit/05d416798f3ef09071af7269bf4335306b45acf3
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: f26cf1cc733fcb56c564f2f648e35b5d8b73d6f8
https://github.com/Perl/perl5/commit/f26cf1cc733fcb56c564f2f648e35b5d8b73d6f8
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 4df39647d4685332a21cabbc9268f95667c01976
https://github.com/Perl/perl5/commit/4df39647d4685332a21cabbc9268f95667c01976
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 0a3495a20d4998a6aa389095e89135eb64d04360
https://github.com/Perl/perl5/commit/0a3495a20d4998a6aa389095e89135eb64d04360
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: cf2037d0f5d311175524aa60cc82bf3e3fc6c99b
https://github.com/Perl/perl5/commit/cf2037d0f5d311175524aa60cc82bf3e3fc6c99b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: f2c22a185df80bd7685d94cb92769c1e1b63192d
https://github.com/Perl/perl5/commit/f2c22a185df80bd7685d94cb92769c1e1b63192d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 26d8f25ec7eef137123d8dc17df7fa1f43997171
https://github.com/Perl/perl5/commit/26d8f25ec7eef137123d8dc17df7fa1f43997171
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 798ede94cf916cbcc96c92d7e7e8b5e6b7cf24c0
https://github.com/Perl/perl5/commit/798ede94cf916cbcc96c92d7e7e8b5e6b7cf24c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: e725be6fc0087bfa7992154f91d6abe0fc7211ac
https://github.com/Perl/perl5/commit/e725be6fc0087bfa7992154f91d6abe0fc7211ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: b5bc265890c1b33bf932c0edf4e5e81350fb8511
https://github.com/Perl/perl5/commit/b5bc265890c1b33bf932c0edf4e5e81350fb8511
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: ffdf4bdad80f1660f83e35a306ef8b4059350db6
https://github.com/Perl/perl5/commit/ffdf4bdad80f1660f83e35a306ef8b4059350db6
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: b09140a2d2ecd968bbddc4937a08d35db5383ea5
https://github.com/Perl/perl5/commit/b09140a2d2ecd968bbddc4937a08d35db5383ea5
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: fb639d0ca24278f75054e933f687567f73457e12
https://github.com/Perl/perl5/commit/fb639d0ca24278f75054e933f687567f73457e12
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 1d7ed8fb82b94dca0ac57ac533d1b2cfc09b0f9f
https://github.com/Perl/perl5/commit/1d7ed8fb82b94dca0ac57ac533d1b2cfc09b0f9f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: fb37a7047dd2fc6c41332d22603ccf9eae1d585f
https://github.com/Perl/perl5/commit/fb37a7047dd2fc6c41332d22603ccf9eae1d585f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: fe702501c4701411951e731f657e1d6f24c5b4ab
https://github.com/Perl/perl5/commit/fe702501c4701411951e731f657e1d6f24c5b4ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: 68bce16a8bcc1a63eaf7c675234c7e82e480db27
https://github.com/Perl/perl5/commit/68bce16a8bcc1a63eaf7c675234c7e82e480db27
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: a783daf47c31d0d028ed7fc3ff6f25ac36d12bf5
https://github.com/Perl/perl5/commit/a783daf47c31d0d028ed7fc3ff6f25ac36d12bf5
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: 39fe091d49227431428b7979b9bcc38829d1fe59
https://github.com/Perl/perl5/commit/39fe091d49227431428b7979b9bcc38829d1fe59
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: ce00b379b0232b7f640f2133bb5da2122c2887e2
https://github.com/Perl/perl5/commit/ce00b379b0232b7f640f2133bb5da2122c2887e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: 8454d71fb17b19dcbdd03c2c512ec4184ba3f5ea
https://github.com/Perl/perl5/commit/8454d71fb17b19dcbdd03c2c512ec4184ba3f5ea
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: a629647d2de488e5f2fba3ff08b939febec1c35b
https://github.com/Perl/perl5/commit/a629647d2de488e5f2fba3ff08b939febec1c35b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: 89e375337b1401c9f006a8fb7fbc7e6561d6277e
https://github.com/Perl/perl5/commit/89e375337b1401c9f006a8fb7fbc7e6561d6277e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: ab2afda59644787353a564d587f18722aa735083
https://github.com/Perl/perl5/commit/ab2afda59644787353a564d587f18722aa735083
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: b8220a1dad1d521750aa5ff186430fc63d62fdf4
https://github.com/Perl/perl5/commit/b8220a1dad1d521750aa5ff186430fc63d62fdf4
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 457e19291ae1b9b13974108ee039d67e80293aa0
https://github.com/Perl/perl5/commit/457e19291ae1b9b13974108ee039d67e80293aa0
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: c5bf7b052cbd738df08ab8d36b6b869f4a88b935
https://github.com/Perl/perl5/commit/c5bf7b052cbd738df08ab8d36b6b869f4a88b935
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: b2c93a91af8590941ab013d96a456e00bc7a037f
https://github.com/Perl/perl5/commit/b2c93a91af8590941ab013d96a456e00bc7a037f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 4534136dee1e10320173a6e09d284560c9e78ec4
https://github.com/Perl/perl5/commit/4534136dee1e10320173a6e09d284560c9e78ec4
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 0263680be88794dc180edb1f127b7807d46327ac
https://github.com/Perl/perl5/commit/0263680be88794dc180edb1f127b7807d46327ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 48fdcdd4b385f953bb3d0aa6180c9323ad765ab9
https://github.com/Perl/perl5/commit/48fdcdd4b385f953bb3d0aa6180c9323ad765ab9
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: lib/locale.t: debug
Commit: e704fdad409a39fd266d9b940f2447abe41a74e6
https://github.com/Perl/perl5/commit/e704fdad409a39fd266d9b940f2447abe41a74e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 3f1e3f1687672f7c0b9da5124d5306e95b170e3a
https://github.com/Perl/perl5/commit/3f1e3f1687672f7c0b9da5124d5306e95b170e3a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: affb8c95425ffd5310447778985d234b09afbbdd
https://github.com/Perl/perl5/commit/affb8c95425ffd5310447778985d234b09afbbdd
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 054c3edcd56aa18ac69ae5efe6372eb24ee0e7c0
https://github.com/Perl/perl5/commit/054c3edcd56aa18ac69ae5efe6372eb24ee0e7c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 154a99582132405998058d94d1f0a3785055857f
https://github.com/Perl/perl5/commit/154a99582132405998058d94d1f0a3785055857f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 7aca878ed9d9cca80ac654468262276db1debef0
https://github.com/Perl/perl5/commit/7aca878ed9d9cca80ac654468262276db1debef0
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: b673f7a84eec4d8e7e33779a40c0876c506df521
https://github.com/Perl/perl5/commit/b673f7a84eec4d8e7e33779a40c0876c506df521
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: e9fa80984f7524b9c981508910ee95dde319a3d3
https://github.com/Perl/perl5/commit/e9fa80984f7524b9c981508910ee95dde319a3d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 09a5f8aee692a2b72ad9b845c282026e6e08a839
https://github.com/Perl/perl5/commit/09a5f8aee692a2b72ad9b845c282026e6e08a839
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: c06d74b16fd86f45df7417adc150fc99ac26cdde
https://github.com/Perl/perl5/commit/c06d74b16fd86f45df7417adc150fc99ac26cdde
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 73c184a373669eb415e984cedd30d84b381b5416
https://github.com/Perl/perl5/commit/73c184a373669eb415e984cedd30d84b381b5416
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: e79caa64a52e462cd38d14f6a01e8f8fe66d5db4
https://github.com/Perl/perl5/commit/e79caa64a52e462cd38d14f6a01e8f8fe66d5db4
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: f3b58632e2b244b6f87bab64a4c9e5a6490d8b90
https://github.com/Perl/perl5/commit/f3b58632e2b244b6f87bab64a4c9e5a6490d8b90
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 983c316cf8ef75f1f25aa57b7990edb66ac5411b
https://github.com/Perl/perl5/commit/983c316cf8ef75f1f25aa57b7990edb66ac5411b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: eee6fe0a3b1c794eeb7a2388a889a19e2f1231c1
https://github.com/Perl/perl5/commit/eee6fe0a3b1c794eeb7a2388a889a19e2f1231c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: e9a06d1cc9f50a0723f8d2364f5f6ff190f5f550
https://github.com/Perl/perl5/commit/e9a06d1cc9f50a0723f8d2364f5f6ff190f5f550
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: f00ac86a6313d409956f1dcfbc20cf5aae0bc36e
https://github.com/Perl/perl5/commit/f00ac86a6313d409956f1dcfbc20cf5aae0bc36e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 3988ec100222f8b8555148f083afab7dfac8518f
https://github.com/Perl/perl5/commit/3988ec100222f8b8555148f083afab7dfac8518f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 6e5e9638574c5b4469fcfdbfed6154baa15fd5fa
https://github.com/Perl/perl5/commit/6e5e9638574c5b4469fcfdbfed6154baa15fd5fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 84e72fe27c49bd432691c74395c792cbcd9c1a6d
https://github.com/Perl/perl5/commit/84e72fe27c49bd432691c74395c792cbcd9c1a6d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: afa45122c31c88732266c1d477871577385a17fd
https://github.com/Perl/perl5/commit/afa45122c31c88732266c1d477871577385a17fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 4608d4ecdbe22668b48755ad3c676564b88e4db9
https://github.com/Perl/perl5/commit/4608d4ecdbe22668b48755ad3c676564b88e4db9
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 549a4278f8fd628461329f2c3be3a028fe10950a
https://github.com/Perl/perl5/commit/549a4278f8fd628461329f2c3be3a028fe10950a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: cc270f2f171255c8b82bd17189b9a15112255b26
https://github.com/Perl/perl5/commit/cc270f2f171255c8b82bd17189b9a15112255b26
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: 02c3c238979b50f29aa20d19faa256b19794a951
https://github.com/Perl/perl5/commit/02c3c238979b50f29aa20d19faa256b19794a951
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 95ff9e0604fe6f980d506b81378a44f9ae1469ed
https://github.com/Perl/perl5/commit/95ff9e0604fe6f980d506b81378a44f9ae1469ed
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 406be90fbb3a07586efecdaf26b8a4fc1218021d
https://github.com/Perl/perl5/commit/406be90fbb3a07586efecdaf26b8a4fc1218021d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: ed5756d2512ef4580e0a02fea1c45856ae5f1dbe
https://github.com/Perl/perl5/commit/ed5756d2512ef4580e0a02fea1c45856ae5f1dbe
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 27bfe082d773bcbb17d05c584c599d5cbb5f56ff
https://github.com/Perl/perl5/commit/27bfe082d773bcbb17d05c584c599d5cbb5f56ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: f041fa605b286ebbe06e9ee770fe4930f765843f
https://github.com/Perl/perl5/commit/f041fa605b286ebbe06e9ee770fe4930f765843f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 49a50c03b2638a2dfbe365c8f04a823bd9a8a9cc
https://github.com/Perl/perl5/commit/49a50c03b2638a2dfbe365c8f04a823bd9a8a9cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 44cbbce32bb4efd9a759e07cbd83ecd66fe50eb5
https://github.com/Perl/perl5/commit/44cbbce32bb4efd9a759e07cbd83ecd66fe50eb5
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: aeee8438a5ab9bb669824bab84ffecc18b12e104
https://github.com/Perl/perl5/commit/aeee8438a5ab9bb669824bab84ffecc18b12e104
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: aac25c9698d579a20ecfab1c92e1cd647d853f75
https://github.com/Perl/perl5/commit/aac25c9698d579a20ecfab1c92e1cd647d853f75
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 4de964a571bd2c7e42be6f79d18dd84a0bc2f06c
https://github.com/Perl/perl5/commit/4de964a571bd2c7e42be6f79d18dd84a0bc2f06c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 851cafd95232e6a48380322073e859174eb4e85c
https://github.com/Perl/perl5/commit/851cafd95232e6a48380322073e859174eb4e85c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 8c072b0317960fe165c1e7f7700dbc79ac8b4483
https://github.com/Perl/perl5/commit/8c072b0317960fe165c1e7f7700dbc79ac8b4483
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 6513332ec2d50347524bd7f6fb99110afa3c9956
https://github.com/Perl/perl5/commit/6513332ec2d50347524bd7f6fb99110afa3c9956
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 8f8219d59ba7b498961a082fb1d04bdd9c79264b
https://github.com/Perl/perl5/commit/8f8219d59ba7b498961a082fb1d04bdd9c79264b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 810ac4e61c99dd269592925dd33c1b683298980f
https://github.com/Perl/perl5/commit/810ac4e61c99dd269592925dd33c1b683298980f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 79d3bd110ad841e1c3003b979f6c1c0e6770d4cc
https://github.com/Perl/perl5/commit/79d3bd110ad841e1c3003b979f6c1c0e6770d4cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: b7986e40831fbbeafd2e1ae3a9ff64ce8777845c
https://github.com/Perl/perl5/commit/b7986e40831fbbeafd2e1ae3a9ff64ce8777845c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: d82452b556b2412975278378eae93ddc8d4b637a
https://github.com/Perl/perl5/commit/d82452b556b2412975278378eae93ddc8d4b637a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: eb0aaec70dfccea05f3cf2eb973f042f4a892af8
https://github.com/Perl/perl5/commit/eb0aaec70dfccea05f3cf2eb973f042f4a892af8
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 8e076e3c2571f6d1a09119d3b11fe7a0a72c83cb
https://github.com/Perl/perl5/commit/8e076e3c2571f6d1a09119d3b11fe7a0a72c83cb
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 6942434cf096a9adf5ccba2cabaf13b2dbbc5441
https://github.com/Perl/perl5/commit/6942434cf096a9adf5ccba2cabaf13b2dbbc5441
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: c39d376fa3b2ae252c9ccea57ce16e836349d5fb
https://github.com/Perl/perl5/commit/c39d376fa3b2ae252c9ccea57ce16e836349d5fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 60385c031d8ab783b664bc223745563f3667836c
https://github.com/Perl/perl5/commit/60385c031d8ab783b664bc223745563f3667836c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 2e359840a9509bbdc9fd0691e93e13a6a60fb0b1
https://github.com/Perl/perl5/commit/2e359840a9509bbdc9fd0691e93e13a6a60fb0b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: fb20a87a8a5ccdff55387555decf600f13fcc5a0
https://github.com/Perl/perl5/commit/fb20a87a8a5ccdff55387555decf600f13fcc5a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 7234cc0d963d24661134ded92d4ba601cab41924
https://github.com/Perl/perl5/commit/7234cc0d963d24661134ded92d4ba601cab41924
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: bd8cb8580a0317481b15938669d93a5e1a4179e0
https://github.com/Perl/perl5/commit/bd8cb8580a0317481b15938669d93a5e1a4179e0
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 076300201b258e82f9a550b3ca09719d13f6c7d8
https://github.com/Perl/perl5/commit/076300201b258e82f9a550b3ca09719d13f6c7d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: bd9195702abd37a54466ade3033f67221415b048
https://github.com/Perl/perl5/commit/bd9195702abd37a54466ade3033f67221415b048
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: 9bf1e5a3d6a374c3ca3877128d54d728c16af09d
https://github.com/Perl/perl5/commit/9bf1e5a3d6a374c3ca3877128d54d728c16af09d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 6918cf5e4ce7dbcb562567c01aa19f2c6a637de4
https://github.com/Perl/perl5/commit/6918cf5e4ce7dbcb562567c01aa19f2c6a637de4
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 807645fe817bf64a6b0d700adfa7b2f28778b782
https://github.com/Perl/perl5/commit/807645fe817bf64a6b0d700adfa7b2f28778b782
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 1fee701eecb0c54c938bbee83ba1f0736fd2c5d3
https://github.com/Perl/perl5/commit/1fee701eecb0c54c938bbee83ba1f0736fd2c5d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: cbafa1a4a84b37c5951a5813142c8e9c7c95abeb
https://github.com/Perl/perl5/commit/cbafa1a4a84b37c5951a5813142c8e9c7c95abeb
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 933cffbae0cb87be620aef5f2f5c331d9edd844f
https://github.com/Perl/perl5/commit/933cffbae0cb87be620aef5f2f5c331d9edd844f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: d2fb760c58b2466a57dbdd8a96ba2b16a2bf2b6b
https://github.com/Perl/perl5/commit/d2fb760c58b2466a57dbdd8a96ba2b16a2bf2b6b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: ce1bebabe71c73344dd429d5c421cf892475921c
https://github.com/Perl/perl5/commit/ce1bebabe71c73344dd429d5c421cf892475921c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 12b5964b28201bd58a7ff5c67d07e1ca34b70849
https://github.com/Perl/perl5/commit/12b5964b28201bd58a7ff5c67d07e1ca34b70849
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 9f570f68afb0ac632e69bba98e7a486dc891c06e
https://github.com/Perl/perl5/commit/9f570f68afb0ac632e69bba98e7a486dc891c06e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 6b9389802ee3850d085fa6fffe5ad785f861a300
https://github.com/Perl/perl5/commit/6b9389802ee3850d085fa6fffe5ad785f861a300
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: b520339b8407969cbf1fcd14e1a5cdfc84a6ebef
https://github.com/Perl/perl5/commit/b520339b8407969cbf1fcd14e1a5cdfc84a6ebef
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: f4f6b6f64ffd987bf86de387c2d62ac6db6a3198
https://github.com/Perl/perl5/commit/f4f6b6f64ffd987bf86de387c2d62ac6db6a3198
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: f11593d3c2c3d2887db5cd6843b268d0472862ba
https://github.com/Perl/perl5/commit/f11593d3c2c3d2887db5cd6843b268d0472862ba
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 63dd4e5f45ef9c8deeceb7c4128a51c17c18a434
https://github.com/Perl/perl5/commit/63dd4e5f45ef9c8deeceb7c4128a51c17c18a434
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 4285544304028fd620bbd26a77d2a12a00a05d44
https://github.com/Perl/perl5/commit/4285544304028fd620bbd26a77d2a12a00a05d44
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: a7ac95921f7eaf7b282edf5999c5d88b05f6b456
https://github.com/Perl/perl5/commit/a7ac95921f7eaf7b282edf5999c5d88b05f6b456
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: b583a118a7606651d6bab9109236c43f239bd57f
https://github.com/Perl/perl5/commit/b583a118a7606651d6bab9109236c43f239bd57f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 7db301e181e86b9c89aefecf6216a5a579b36c93
https://github.com/Perl/perl5/commit/7db301e181e86b9c89aefecf6216a5a579b36c93
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 90e0721718e4001633b658c421ad18fb254b2a62
https://github.com/Perl/perl5/commit/90e0721718e4001633b658c421ad18fb254b2a62
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 80b3da1d4e4c7967e81c0a07f6f8a609e165801e
https://github.com/Perl/perl5/commit/80b3da1d4e4c7967e81c0a07f6f8a609e165801e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: f891285f85f9e58ac39d7c85bcd4a1508715e8ef
https://github.com/Perl/perl5/commit/f891285f85f9e58ac39d7c85bcd4a1508715e8ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: 0369278d61bb3e4b0e81233e247305fbbc4cce47
https://github.com/Perl/perl5/commit/0369278d61bb3e4b0e81233e247305fbbc4cce47
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: 8fe7484e37ff133f4edd1cd2244b2fdf193e0f5b
https://github.com/Perl/perl5/commit/8fe7484e37ff133f4edd1cd2244b2fdf193e0f5b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: bac57a41af7d9b83607c9c97cb61e0890ecdcea8
https://github.com/Perl/perl5/commit/bac57a41af7d9b83607c9c97cb61e0890ecdcea8
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: 17766b05ef6227c9f31ef27fc1dea3f941765605
https://github.com/Perl/perl5/commit/17766b05ef6227c9f31ef27fc1dea3f941765605
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: 35dd338c6b15f309c03a93ed60cac955ce10c503
https://github.com/Perl/perl5/commit/35dd338c6b15f309c03a93ed60cac955ce10c503
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: 99f89db1c0e0e510533565ae8068e2a3a1bd7694
https://github.com/Perl/perl5/commit/99f89db1c0e0e510533565ae8068e2a3a1bd7694
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: 2e36f0f2151a1cfe997303cf7265bf59b2ee03d7
https://github.com/Perl/perl5/commit/2e36f0f2151a1cfe997303cf7265bf59b2ee03d7
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 7aa15873e027f20f857c8393eeac9fc2eabdd260
https://github.com/Perl/perl5/commit/7aa15873e027f20f857c8393eeac9fc2eabdd260
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 6a19dcf96bd9173f54a91e22806777a53ba17324
https://github.com/Perl/perl5/commit/6a19dcf96bd9173f54a91e22806777a53ba17324
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: 957fd48a829ed2ead102e2755a6aa1503988f42d
https://github.com/Perl/perl5/commit/957fd48a829ed2ead102e2755a6aa1503988f42d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: 512e209571d8c9d630a9a9549c4c124784c593d5
https://github.com/Perl/perl5/commit/512e209571d8c9d630a9a9549c4c124784c593d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: f1dd4f62df60f35cb9809b4b10fb1f86d07f86ad
https://github.com/Perl/perl5/commit/f1dd4f62df60f35cb9809b4b10fb1f86d07f86ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: 173283ed03fe394254c38c5d7486b2818ee424e5
https://github.com/Perl/perl5/commit/173283ed03fe394254c38c5d7486b2818ee424e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: 18e76070ff252dbd6514a7595c69ce17fb774005
https://github.com/Perl/perl5/commit/18e76070ff252dbd6514a7595c69ce17fb774005
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: 9b4d0d9198ccc31109b9289060d0d9f09cfd5eca
https://github.com/Perl/perl5/commit/9b4d0d9198ccc31109b9289060d0d9f09cfd5eca
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: 8715e5eed82b4bc5d53521f7f0efcc1f30b1c17c
https://github.com/Perl/perl5/commit/8715e5eed82b4bc5d53521f7f0efcc1f30b1c17c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: aea7ed2e749ba738a5756bd9ec67122644fcb855
https://github.com/Perl/perl5/commit/aea7ed2e749ba738a5756bd9ec67122644fcb855
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: d830fa8a0fd9e2d7df0e1f1ab91e88ad7224bc95
https://github.com/Perl/perl5/commit/d830fa8a0fd9e2d7df0e1f1ab91e88ad7224bc95
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: 35d4a37ec656b707bdaa58eaf1448d2e23357b20
https://github.com/Perl/perl5/commit/35d4a37ec656b707bdaa58eaf1448d2e23357b20
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: 32ab9ae1ebd59a511a305f7d4ddf67e2c72fccd8
https://github.com/Perl/perl5/commit/32ab9ae1ebd59a511a305f7d4ddf67e2c72fccd8
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 425f89adcf9f3e2898e0faf59a6d71b422bf1ba9
https://github.com/Perl/perl5/commit/425f89adcf9f3e2898e0faf59a6d71b422bf1ba9
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads debugging
Commit: 64ed78dffc8e7f4654d272eab5e46e60ed698e5c
https://github.com/Perl/perl5/commit/64ed78dffc8e7f4654d272eab5e46e60ed698e5c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: 41a530eae19f407c902592c2b31a78b41b018415
https://github.com/Perl/perl5/commit/41a530eae19f407c902592c2b31a78b41b018415
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: f5989677493a647847bb939eab5bd5424157079c
https://github.com/Perl/perl5/commit/f5989677493a647847bb939eab5bd5424157079c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg,thread_init Revamp sync_locale, switch_to_global_locale
f
Commit: d541db40af38930130500cd4a527f6294410c1f2
https://github.com/Perl/perl5/commit/d541db40af38930130500cd4a527f6294410c1f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv duplicate clones
These variables are already cloned when creating a thread
Commit: 8101b385983b02250dd89592a528f0fb3d85170c
https://github.com/Perl/perl5/commit/8101b385983b02250dd89592a528f0fb3d85170c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv redundant clause
If threaded locales are being used, basic locales are too. No need to
check both
Commit: bb2e2d0a04ee17eea25674a25ca034388f648434
https://github.com/Perl/perl5/commit/bb2e2d0a04ee17eea25674a25ca034388f648434
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
M lib/locale.t
Log Message:
-----------
Fix isspace() handling on AIX
This box incorrectly thinks the NBSP is a graphic on many locales.
Overriding that makes these locales behave like proper POSIX ones.
Commit: 1a0cfbd5951ea3071da0f08c42b814a2674c4e37
https://github.com/Perl/perl5/commit/1a0cfbd5951ea3071da0f08c42b814a2674c4e37
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: White-space only
Replace leading tabs with spaces
Commit: 6514e896a571b8daf2276125f994726348c3ccf3
https://github.com/Perl/perl5/commit/6514e896a571b8daf2276125f994726348c3ccf3
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M hints/cygwin.sh
Log Message:
-----------
XXX check if really necessary after everything: Don't use POSIX 2008 locale
This has been found to be buggy leading to dying inside the newlocale()
in S_emulate_setlocale_i()
Commit: 8676d3b7eeffd47bc18fd6e04d7540f5429137ca
https://github.com/Perl/perl5/commit/8676d3b7eeffd47bc18fd6e04d7540f5429137ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t: Use I18N::Langinfo, not POSIX::localeconv()
Now that Langinfo is ported to every box, it requires less work than
localeconv(), and offers more choices. This commit changes to use it,
and for more info when debugging, gets some additional info from it.
Commit: c066d49a0d7b9ff85e8438b23a42c353009e785a
https://github.com/Perl/perl5/commit/c066d49a0d7b9ff85e8438b23a42c353009e785a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX cygwin debugging small macro buf
Commit: eb57f4cdcfb48d410c5ad96150574023de3ffe1c
https://github.com/Perl/perl5/commit/eb57f4cdcfb48d410c5ad96150574023de3ffe1c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Avoid unnecessary calls to set_numeric_standard()
Prior to this commit, set_numeric_standard() was called unconditionally,
and it could decide if it should do anything or not. But the variable
that indicates this is available to the caller, so by testing it, it can
avoid the call, which is most likely the case.
Commit: a55645eaca93c132f1a7486b1baee3ee2fb22f46
https://github.com/Perl/perl5/commit/a55645eaca93c132f1a7486b1baee3ee2fb22f46
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging trace across all files
Commit: 26409352b885b619b587d4cbaa999efbebfdf702
https://github.com/Perl/perl5/commit/26409352b885b619b587d4cbaa999efbebfdf702
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Use internal querylocale on Linux
XXX Need to bisect to see where this goes bad
XXX Is effectively a no-op due to other debugging code
Commit: 8fc48448937e8c1e78dd08df8eb55c420d6b87a5
https://github.com/Perl/perl5/commit/8fc48448937e8c1e78dd08df8eb55c420d6b87a5
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M handy.h
M iperlsys.h
M locale.c
M perl.h
M pod/perllocale.pod
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: e13ecb2c39d4a84e017a21eb6a81af1e5272ab9d
https://github.com/Perl/perl5/commit/e13ecb2c39d4a84e017a21eb6a81af1e5272ab9d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 7c4afd841d318a6b0185e0f8f9c0aadf17d58971
https://github.com/Perl/perl5/commit/7c4afd841d318a6b0185e0f8f9c0aadf17d58971
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/t/Langinfo.t
M ext/POSIX/POSIX.xs
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M regexec.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
37
Compare: https://github.com/Perl/perl5/compare/0381d0d0073a...7c4afd841d31
