Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: cd5aaa38d7eb3bdee2b9987a3a8148fdda5c58f0
https://github.com/Perl/perl5/commit/cd5aaa38d7eb3bdee2b9987a3a8148fdda5c58f0
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
perlapi: Rmv repeated word
Commit: 7841a885292243fcdf49f87dcf043718b15c3520
https://github.com/Perl/perl5/commit/7841a885292243fcdf49f87dcf043718b15c3520
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: f2ebcacee70acc2b2c77bc5fbfa6076a15f31ce4
https://github.com/Perl/perl5/commit/f2ebcacee70acc2b2c77bc5fbfa6076a15f31ce4
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 9a39e4eb86f7f23e9d93db54b56b563369162766
https://github.com/Perl/perl5/commit/9a39e4eb86f7f23e9d93db54b56b563369162766
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 3c81188bd5d58f4604f7b9d7405fe6af90d89629
https://github.com/Perl/perl5/commit/3c81188bd5d58f4604f7b9d7405fe6af90d89629
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 54158cad2b5badf3c2b1ad11d8e94ecb96680a4f
https://github.com/Perl/perl5/commit/54158cad2b5badf3c2b1ad11d8e94ecb96680a4f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 7c8b1eb73c34d196c77d12281c3f18f4294be72a
https://github.com/Perl/perl5/commit/7c8b1eb73c34d196c77d12281c3f18f4294be72a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 977846e357b06e798e9d4b0ea2b514f077fd00dc
https://github.com/Perl/perl5/commit/977846e357b06e798e9d4b0ea2b514f077fd00dc
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 58a5211ff6b934962179608a74e8a89e5a6f67d7
https://github.com/Perl/perl5/commit/58a5211ff6b934962179608a74e8a89e5a6f67d7
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 14de17422047f5da2df3be3d7cca4762e8331cb2
https://github.com/Perl/perl5/commit/14de17422047f5da2df3be3d7cca4762e8331cb2
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: ff280007480a0f01223db70307ae4676e027b7f5
https://github.com/Perl/perl5/commit/ff280007480a0f01223db70307ae4676e027b7f5
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 54c1693c8fe29b646c0951480a0ff302fe43bcb8
https://github.com/Perl/perl5/commit/54c1693c8fe29b646c0951480a0ff302fe43bcb8
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 17767d55721c80c93d65656391ccedc2c0a73fcd
https://github.com/Perl/perl5/commit/17767d55721c80c93d65656391ccedc2c0a73fcd
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 37603b7a2b98bfdeb726e71da7dbe17384608e76
https://github.com/Perl/perl5/commit/37603b7a2b98bfdeb726e71da7dbe17384608e76
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: d49975e99553fcdb8aacc376ca3e95d56d740517
https://github.com/Perl/perl5/commit/d49975e99553fcdb8aacc376ca3e95d56d740517
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 4842fb5f422f89aa1bcf55c988ce3956c7dac07f
https://github.com/Perl/perl5/commit/4842fb5f422f89aa1bcf55c988ce3956c7dac07f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 1b1d0bdac1943f5e0c2f9728b79ba5a9d9045d19
https://github.com/Perl/perl5/commit/1b1d0bdac1943f5e0c2f9728b79ba5a9d9045d19
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 5f4c2d89be5433623acb996afc56b3dd304cd08e
https://github.com/Perl/perl5/commit/5f4c2d89be5433623acb996afc56b3dd304cd08e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: b8ae357101756bc38c3b82044de0321a6da96ecf
https://github.com/Perl/perl5/commit/b8ae357101756bc38c3b82044de0321a6da96ecf
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: b46a9d48d441a1c67f84269650f7917612d29eaf
https://github.com/Perl/perl5/commit/b46a9d48d441a1c67f84269650f7917612d29eaf
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: f7810a2a97a9fe92f531ee01a34ebb01d06a0aae
https://github.com/Perl/perl5/commit/f7810a2a97a9fe92f531ee01a34ebb01d06a0aae
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: be24895ce7267acdb441145a9c35cbf0d668f31f
https://github.com/Perl/perl5/commit/be24895ce7267acdb441145a9c35cbf0d668f31f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 3ae470e8fb04553d173c4d8aa5e2e76ad2a763ec
https://github.com/Perl/perl5/commit/3ae470e8fb04553d173c4d8aa5e2e76ad2a763ec
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 80f07adfcf55132ac1b448b5e5a676a89c28dcf4
https://github.com/Perl/perl5/commit/80f07adfcf55132ac1b448b5e5a676a89c28dcf4
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 3ba6c510f86489ec9cc8c6c0e63b7c5361ff55a2
https://github.com/Perl/perl5/commit/3ba6c510f86489ec9cc8c6c0e63b7c5361ff55a2
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 11e85c3f7ccf3ec0e7fc922a0865b59058036488
https://github.com/Perl/perl5/commit/11e85c3f7ccf3ec0e7fc922a0865b59058036488
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 99c947849b4672847d2b94d2483e790de0d9c768
https://github.com/Perl/perl5/commit/99c947849b4672847d2b94d2483e790de0d9c768
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 82a399618420a57699dbf7c5d1957674811cfd12
https://github.com/Perl/perl5/commit/82a399618420a57699dbf7c5d1957674811cfd12
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 8eac343d5a2a0ff457f847fb4ab62ccacfdce792
https://github.com/Perl/perl5/commit/8eac343d5a2a0ff457f847fb4ab62ccacfdce792
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: d918d2801240f962bb5619acbb56f3df3b1222f5
https://github.com/Perl/perl5/commit/d918d2801240f962bb5619acbb56f3df3b1222f5
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: da5e138a06197c38eb3a9b472e3c1c6ee20df9a9
https://github.com/Perl/perl5/commit/da5e138a06197c38eb3a9b472e3c1c6ee20df9a9
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: a350e07d554c4a4d8a2aca86f0f065f014efbb21
https://github.com/Perl/perl5/commit/a350e07d554c4a4d8a2aca86f0f065f014efbb21
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: ea062dbbbe83f24b8c16f7d1adcad73a777e2690
https://github.com/Perl/perl5/commit/ea062dbbbe83f24b8c16f7d1adcad73a777e2690
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 8a87794b2189f21fd5c8db54a244187076c42490
https://github.com/Perl/perl5/commit/8a87794b2189f21fd5c8db54a244187076c42490
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 3a7f721ba4c14f69699b359890bf110b78e3bb56
https://github.com/Perl/perl5/commit/3a7f721ba4c14f69699b359890bf110b78e3bb56
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: dbbd424af940f1b6dbf1f1add4b994962b09a21b
https://github.com/Perl/perl5/commit/dbbd424af940f1b6dbf1f1add4b994962b09a21b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: f44f584eb8faea0deca5100138de51a661951c70
https://github.com/Perl/perl5/commit/f44f584eb8faea0deca5100138de51a661951c70
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 2407a046433c8ca8fef174843b02013d809a185f
https://github.com/Perl/perl5/commit/2407a046433c8ca8fef174843b02013d809a185f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 5b35cc0bcc92d477c1adf22710ea322a2768d459
https://github.com/Perl/perl5/commit/5b35cc0bcc92d477c1adf22710ea322a2768d459
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 3f6a426e482c2be644f85537272612c9af722a5f
https://github.com/Perl/perl5/commit/3f6a426e482c2be644f85537272612c9af722a5f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: b0bbb0b32c993ea7a7456d9e6e66917e0bc3f565
https://github.com/Perl/perl5/commit/b0bbb0b32c993ea7a7456d9e6e66917e0bc3f565
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 16259172936cb2f90b3457a50cb449de66bde989
https://github.com/Perl/perl5/commit/16259172936cb2f90b3457a50cb449de66bde989
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 2784244c90f30cf12c03a7c96b62bab99f78baaf
https://github.com/Perl/perl5/commit/2784244c90f30cf12c03a7c96b62bab99f78baaf
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 39284687cc4db1e6fb663eae052e63b791491d7d
https://github.com/Perl/perl5/commit/39284687cc4db1e6fb663eae052e63b791491d7d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: c682d319e262c6ae82074ff36223baf72a657685
https://github.com/Perl/perl5/commit/c682d319e262c6ae82074ff36223baf72a657685
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: b7bee0eb894a09094a425b05a703a16c9a35bc2d
https://github.com/Perl/perl5/commit/b7bee0eb894a09094a425b05a703a16c9a35bc2d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 5a3b12f7c33232a65d15926cf6c9ffa51156bdb9
https://github.com/Perl/perl5/commit/5a3b12f7c33232a65d15926cf6c9ffa51156bdb9
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: d8579ebf57f234aa55798cda962c2599ca650fde
https://github.com/Perl/perl5/commit/d8579ebf57f234aa55798cda962c2599ca650fde
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 623261dffe59beea67ed785f511e365d4e90b8e1
https://github.com/Perl/perl5/commit/623261dffe59beea67ed785f511e365d4e90b8e1
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: e32b9f368a7d6e22ea179ce9d29d2a9465b1b4b0
https://github.com/Perl/perl5/commit/e32b9f368a7d6e22ea179ce9d29d2a9465b1b4b0
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 67d7fce56f3368e6bee58ec0e4f26d9bf7dcf3ec
https://github.com/Perl/perl5/commit/67d7fce56f3368e6bee58ec0e4f26d9bf7dcf3ec
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: d95ba490c65ca737a9739655669da5411ee08c6e
https://github.com/Perl/perl5/commit/d95ba490c65ca737a9739655669da5411ee08c6e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 8b9277a4a8cfb6874200a87d499010516f2461b0
https://github.com/Perl/perl5/commit/8b9277a4a8cfb6874200a87d499010516f2461b0
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 8851b4e5086a0cff4b23dc12100d3c6ffc6c0735
https://github.com/Perl/perl5/commit/8851b4e5086a0cff4b23dc12100d3c6ffc6c0735
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 0928bde9efbf9424add4ab63d579471e5610b23d
https://github.com/Perl/perl5/commit/0928bde9efbf9424add4ab63d579471e5610b23d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 5d6f63267f1840b7be3b1816f0c237f6e3950f54
https://github.com/Perl/perl5/commit/5d6f63267f1840b7be3b1816f0c237f6e3950f54
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 8ea6720bf2b31daa39fe4699c7e22d130c9fe7b2
https://github.com/Perl/perl5/commit/8ea6720bf2b31daa39fe4699c7e22d130c9fe7b2
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: abfc159065da1e93226840c9a559fbfb11c8ff6d
https://github.com/Perl/perl5/commit/abfc159065da1e93226840c9a559fbfb11c8ff6d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: 9a56c7ba327c6280791d2508f8604293e08169e8
https://github.com/Perl/perl5/commit/9a56c7ba327c6280791d2508f8604293e08169e8
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: 36b1a5ead1ff1bc1f79eca60a9d999adcc54c752
https://github.com/Perl/perl5/commit/36b1a5ead1ff1bc1f79eca60a9d999adcc54c752
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: f3392129d92e16b0e52b75c60251dc606df3a077
https://github.com/Perl/perl5/commit/f3392129d92e16b0e52b75c60251dc606df3a077
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 232e3c4c2809e01cec3c2fdaceef5ee0b97fbe9d
https://github.com/Perl/perl5/commit/232e3c4c2809e01cec3c2fdaceef5ee0b97fbe9d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 69eafdc3011a4b6ee749b9759bcf2524d713a773
https://github.com/Perl/perl5/commit/69eafdc3011a4b6ee749b9759bcf2524d713a773
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 409c1830fc3fc8c4d1c7ba19d3792ff1de39708c
https://github.com/Perl/perl5/commit/409c1830fc3fc8c4d1c7ba19d3792ff1de39708c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 233d83abb7ca646d8be55bbcb6413398c4b5dc08
https://github.com/Perl/perl5/commit/233d83abb7ca646d8be55bbcb6413398c4b5dc08
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: dcb7fd22679e7885829fa72eda7f2549299e7a47
https://github.com/Perl/perl5/commit/dcb7fd22679e7885829fa72eda7f2549299e7a47
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 43ea1ed1fc3627794b21a5286ac08d230b278c8a
https://github.com/Perl/perl5/commit/43ea1ed1fc3627794b21a5286ac08d230b278c8a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 2d62e64bb32f7e66ef213986fe3027f4ead4c89a
https://github.com/Perl/perl5/commit/2d62e64bb32f7e66ef213986fe3027f4ead4c89a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: b2796f7df737d548873ac8180e16aa8e45cd2b31
https://github.com/Perl/perl5/commit/b2796f7df737d548873ac8180e16aa8e45cd2b31
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 48913719315311d82bb0971f0ff7866254361bc8
https://github.com/Perl/perl5/commit/48913719315311d82bb0971f0ff7866254361bc8
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 1fe3e597fbde90b325ce878343c5fbfd86ff0930
https://github.com/Perl/perl5/commit/1fe3e597fbde90b325ce878343c5fbfd86ff0930
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 3bbb3386ab7e6b40d72d3e9ef740ae27be31b498
https://github.com/Perl/perl5/commit/3bbb3386ab7e6b40d72d3e9ef740ae27be31b498
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: dc5e1477cdf31574e9e47e6758fcc170280fe710
https://github.com/Perl/perl5/commit/dc5e1477cdf31574e9e47e6758fcc170280fe710
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: ace565f0cd4106eaed0480166544b9aba26a9d4f
https://github.com/Perl/perl5/commit/ace565f0cd4106eaed0480166544b9aba26a9d4f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 38fe8b6252c6190b1a00631d742252a1a6af56cc
https://github.com/Perl/perl5/commit/38fe8b6252c6190b1a00631d742252a1a6af56cc
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 92472317be6183f5ce9acd9ec50c157e6f9d280d
https://github.com/Perl/perl5/commit/92472317be6183f5ce9acd9ec50c157e6f9d280d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 952cb6ae8ba7ee09d218cd40670b6b76f66b3c86
https://github.com/Perl/perl5/commit/952cb6ae8ba7ee09d218cd40670b6b76f66b3c86
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: e5f99f62f4693ce466f58fc6fa4478ee895cbf61
https://github.com/Perl/perl5/commit/e5f99f62f4693ce466f58fc6fa4478ee895cbf61
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 0b9472071c04b4f3cd6a46db977ea64c8d8d9f4e
https://github.com/Perl/perl5/commit/0b9472071c04b4f3cd6a46db977ea64c8d8d9f4e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: c289a2d7a71fe0e43460180f60303096f39419e3
https://github.com/Perl/perl5/commit/c289a2d7a71fe0e43460180f60303096f39419e3
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 7390e6a2ee841148d567847b54d84043a49414e9
https://github.com/Perl/perl5/commit/7390e6a2ee841148d567847b54d84043a49414e9
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: fa3f70d6e07ee9f9939f0d4b8a6fdd7aa22735e0
https://github.com/Perl/perl5/commit/fa3f70d6e07ee9f9939f0d4b8a6fdd7aa22735e0
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 0547f94fdc383a66cd9049612f15b33b812d8ba0
https://github.com/Perl/perl5/commit/0547f94fdc383a66cd9049612f15b33b812d8ba0
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 3d1e87cbc606bdc55e1a12a3991448b8ab79f9f1
https://github.com/Perl/perl5/commit/3d1e87cbc606bdc55e1a12a3991448b8ab79f9f1
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 8902cab25d5d147ef1892cd522f2f964acb1daed
https://github.com/Perl/perl5/commit/8902cab25d5d147ef1892cd522f2f964acb1daed
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 4f851ed4f0efc7513e4a8317826375a840121f8a
https://github.com/Perl/perl5/commit/4f851ed4f0efc7513e4a8317826375a840121f8a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: e2dfaae04b4556f300a2cd2e3d95fbe4749c332d
https://github.com/Perl/perl5/commit/e2dfaae04b4556f300a2cd2e3d95fbe4749c332d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: d4c10de39d334ed3eabd3f340b4c501a61a1c0c1
https://github.com/Perl/perl5/commit/d4c10de39d334ed3eabd3f340b4c501a61a1c0c1
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 5651e1314f81dae943aa40cd9e3138e00670fe6a
https://github.com/Perl/perl5/commit/5651e1314f81dae943aa40cd9e3138e00670fe6a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 624697c490a54137a104f6b0429b496516f56b8c
https://github.com/Perl/perl5/commit/624697c490a54137a104f6b0429b496516f56b8c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 42e4fc482b686679290f13c10bb5d7e1c77f86da
https://github.com/Perl/perl5/commit/42e4fc482b686679290f13c10bb5d7e1c77f86da
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 414d78c39350a33d6bcc11479d6043b9dc75b8fe
https://github.com/Perl/perl5/commit/414d78c39350a33d6bcc11479d6043b9dc75b8fe
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 903bbd6635e438ba1de2ee6b2c4d8ef5de3c908d
https://github.com/Perl/perl5/commit/903bbd6635e438ba1de2ee6b2c4d8ef5de3c908d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: b9b77bcc49c6d4d46eaecded5f42c4e1e0ff4411
https://github.com/Perl/perl5/commit/b9b77bcc49c6d4d46eaecded5f42c4e1e0ff4411
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: d8160cb3876097c7246293f0b3454ffe69df8554
https://github.com/Perl/perl5/commit/d8160cb3876097c7246293f0b3454ffe69df8554
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 81dd62ef390f1e64f842ffdc0aa0b0a42dced30a
https://github.com/Perl/perl5/commit/81dd62ef390f1e64f842ffdc0aa0b0a42dced30a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: d8a6c76d47b586c2f7326eecefb03bf9930c8102
https://github.com/Perl/perl5/commit/d8a6c76d47b586c2f7326eecefb03bf9930c8102
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: a52d3468d0ee56f1327752ca2c4d869ce7b24b78
https://github.com/Perl/perl5/commit/a52d3468d0ee56f1327752ca2c4d869ce7b24b78
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: f62290cb3fb8c469672b1d0ef15087a53b48fc24
https://github.com/Perl/perl5/commit/f62290cb3fb8c469672b1d0ef15087a53b48fc24
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: df35042fe0f9e4182ddb51bbc72235bd7e0d876e
https://github.com/Perl/perl5/commit/df35042fe0f9e4182ddb51bbc72235bd7e0d876e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 5183ada22979862d020469efb3cdd8370f808fa2
https://github.com/Perl/perl5/commit/5183ada22979862d020469efb3cdd8370f808fa2
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: d2077dbd77e87995873dfc4a4bf9973336f38268
https://github.com/Perl/perl5/commit/d2077dbd77e87995873dfc4a4bf9973336f38268
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: c89109cb159a9e7dcddd545b341e4d5aceb1f923
https://github.com/Perl/perl5/commit/c89109cb159a9e7dcddd545b341e4d5aceb1f923
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 4cf68c7363fb2b29bbd2cdc2b14c2155e47fb7e1
https://github.com/Perl/perl5/commit/4cf68c7363fb2b29bbd2cdc2b14c2155e47fb7e1
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 1a5f60781499cd9693b6d55dfeb9b22d12a47052
https://github.com/Perl/perl5/commit/1a5f60781499cd9693b6d55dfeb9b22d12a47052
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 32bef86bfe5dc943b8f4621f371bb2128b59226b
https://github.com/Perl/perl5/commit/32bef86bfe5dc943b8f4621f371bb2128b59226b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: d64faa273241adfa64dabe3aa7a651776f55dd83
https://github.com/Perl/perl5/commit/d64faa273241adfa64dabe3aa7a651776f55dd83
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 1ac719393df9ba84c1aeddbed9616081fab3da56
https://github.com/Perl/perl5/commit/1ac719393df9ba84c1aeddbed9616081fab3da56
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 79bd23dcec7acc9af7d15b144ff4b819b9a2fd84
https://github.com/Perl/perl5/commit/79bd23dcec7acc9af7d15b144ff4b819b9a2fd84
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: c0de91a41e5e29027dcdbfbc8571669359d4ecf0
https://github.com/Perl/perl5/commit/c0de91a41e5e29027dcdbfbc8571669359d4ecf0
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 1cbb5adaa989e36422a6ad61deef37b65646fe67
https://github.com/Perl/perl5/commit/1cbb5adaa989e36422a6ad61deef37b65646fe67
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 96cd9c7e00f4e35a68cce13aeb3d5382958b7cc1
https://github.com/Perl/perl5/commit/96cd9c7e00f4e35a68cce13aeb3d5382958b7cc1
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: d6ba54344eb18ec6aa3a087b1e5bc0cc4dc09781
https://github.com/Perl/perl5/commit/d6ba54344eb18ec6aa3a087b1e5bc0cc4dc09781
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: f5730039fa0b62702f981b7b2528c888364b667a
https://github.com/Perl/perl5/commit/f5730039fa0b62702f981b7b2528c888364b667a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: c16865776a2b1053c90147c600bef78910d0cef5
https://github.com/Perl/perl5/commit/c16865776a2b1053c90147c600bef78910d0cef5
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: efa5bc5c105628f0fc0e2a19c0a79e5e7bcace5b
https://github.com/Perl/perl5/commit/efa5bc5c105628f0fc0e2a19c0a79e5e7bcace5b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: e8de581c6b9c8e80f187b0e8de81d8ac51a22559
https://github.com/Perl/perl5/commit/e8de581c6b9c8e80f187b0e8de81d8ac51a22559
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 53dab3563d25a5efd6b26ee31086b4893c83278c
https://github.com/Perl/perl5/commit/53dab3563d25a5efd6b26ee31086b4893c83278c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: 4bcb7d6b46a149219fd1419ffddfb1d97cb23a30
https://github.com/Perl/perl5/commit/4bcb7d6b46a149219fd1419ffddfb1d97cb23a30
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: e28e510748187b7ce38cc15beb00156d1a33541d
https://github.com/Perl/perl5/commit/e28e510748187b7ce38cc15beb00156d1a33541d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 1e0f639aaf327c8c9e434c698927bc1920d295e2
https://github.com/Perl/perl5/commit/1e0f639aaf327c8c9e434c698927bc1920d295e2
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 365ec723b54bf1ca42484f72eaf25a745234439b
https://github.com/Perl/perl5/commit/365ec723b54bf1ca42484f72eaf25a745234439b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: b1b3b975f9e1683432e009dbdccd97e057bb00b8
https://github.com/Perl/perl5/commit/b1b3b975f9e1683432e009dbdccd97e057bb00b8
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 26741067785ac0a26ddeeb4caa563a0bd4060967
https://github.com/Perl/perl5/commit/26741067785ac0a26ddeeb4caa563a0bd4060967
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 31635e0a0faefb4c92498217b0ab623117780c81
https://github.com/Perl/perl5/commit/31635e0a0faefb4c92498217b0ab623117780c81
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: cd81520202e7c345f009e10e01afdee1815e807a
https://github.com/Perl/perl5/commit/cd81520202e7c345f009e10e01afdee1815e807a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 353c5a5afad16ffc9fe1bf9005b3b9ea90566585
https://github.com/Perl/perl5/commit/353c5a5afad16ffc9fe1bf9005b3b9ea90566585
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 8d0f85b3cf7d5a4f0c4ac0d514b49f79c3a1382a
https://github.com/Perl/perl5/commit/8d0f85b3cf7d5a4f0c4ac0d514b49f79c3a1382a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: d56b709646b8e95f918a95a0120e57ea5dcdfc95
https://github.com/Perl/perl5/commit/d56b709646b8e95f918a95a0120e57ea5dcdfc95
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: f35ef3b80c404086b2a4999ac61ded3c969fd127
https://github.com/Perl/perl5/commit/f35ef3b80c404086b2a4999ac61ded3c969fd127
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: bb0b97ca88302c2702f3113d02868713c2fee131
https://github.com/Perl/perl5/commit/bb0b97ca88302c2702f3113d02868713c2fee131
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: f2e7e45287c69963c70ca455ce18960d64c40f43
https://github.com/Perl/perl5/commit/f2e7e45287c69963c70ca455ce18960d64c40f43
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: b96542c4bfdbe0792fd16427ce0dc983bbf242da
https://github.com/Perl/perl5/commit/b96542c4bfdbe0792fd16427ce0dc983bbf242da
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: b6d68fe0faa587cc51b5c9991317474d49d749b4
https://github.com/Perl/perl5/commit/b6d68fe0faa587cc51b5c9991317474d49d749b4
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: c17511132227fe6f0c5e92c456f8d010b1223128
https://github.com/Perl/perl5/commit/c17511132227fe6f0c5e92c456f8d010b1223128
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: b5344eb68ca3de26028cbf893406a2a342e3fb33
https://github.com/Perl/perl5/commit/b5344eb68ca3de26028cbf893406a2a342e3fb33
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: 99cd06332c2b69b1e90a39dd0ade21cf89d04867
https://github.com/Perl/perl5/commit/99cd06332c2b69b1e90a39dd0ade21cf89d04867
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: 162684a1da7ef659f14641b288702d731dc1941a
https://github.com/Perl/perl5/commit/162684a1da7ef659f14641b288702d731dc1941a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: c06e1b5c258c34bf53aa6eb9cfb8609513ebb3ff
https://github.com/Perl/perl5/commit/c06e1b5c258c34bf53aa6eb9cfb8609513ebb3ff
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: e0e32f313aa1172b4f529b8b6904b46bc3d2f03e
https://github.com/Perl/perl5/commit/e0e32f313aa1172b4f529b8b6904b46bc3d2f03e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 9e0751f822722bfd6f374df268383267bd9a4fec
https://github.com/Perl/perl5/commit/9e0751f822722bfd6f374df268383267bd9a4fec
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 9c2fea22b59408fd189ed8dff2f5b4d6bfbbd8d0
https://github.com/Perl/perl5/commit/9c2fea22b59408fd189ed8dff2f5b4d6bfbbd8d0
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: ab810abd358ef176d452a1d4197c91ee377b0202
https://github.com/Perl/perl5/commit/ab810abd358ef176d452a1d4197c91ee377b0202
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 912ee5393afc1ebfcccd315b9e6489a226ad11ad
https://github.com/Perl/perl5/commit/912ee5393afc1ebfcccd315b9e6489a226ad11ad
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 33315bba5393befe0eac1c00c781fcfa465ddbd8
https://github.com/Perl/perl5/commit/33315bba5393befe0eac1c00c781fcfa465ddbd8
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: lib/locale.t: debug
Commit: bc8c78579cedfae7e4b2aa3d2d64d00378ad7349
https://github.com/Perl/perl5/commit/bc8c78579cedfae7e4b2aa3d2d64d00378ad7349
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 6a495b5059070c3ad4f72b7f1bdbd6a75878ad3e
https://github.com/Perl/perl5/commit/6a495b5059070c3ad4f72b7f1bdbd6a75878ad3e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: c7ca7b717ff037186c85043f9f2307e82235ba11
https://github.com/Perl/perl5/commit/c7ca7b717ff037186c85043f9f2307e82235ba11
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 4b2a7c1584d5fbb92b4acb4c01e446cb8842a22b
https://github.com/Perl/perl5/commit/4b2a7c1584d5fbb92b4acb4c01e446cb8842a22b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 686682353ff8ead25ed743c346587eb4c74e487d
https://github.com/Perl/perl5/commit/686682353ff8ead25ed743c346587eb4c74e487d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 49b8112547bac6f2df4a320eb5c95750e0f8fe9a
https://github.com/Perl/perl5/commit/49b8112547bac6f2df4a320eb5c95750e0f8fe9a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 52391fba2f9fb2c6da22578942f0f9eb79bb291e
https://github.com/Perl/perl5/commit/52391fba2f9fb2c6da22578942f0f9eb79bb291e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: cefa31b4557c1d0fc7e09898fce5b6d6f5e423c0
https://github.com/Perl/perl5/commit/cefa31b4557c1d0fc7e09898fce5b6d6f5e423c0
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 714253aa880e0407444690d9f56e5f95de5f67a4
https://github.com/Perl/perl5/commit/714253aa880e0407444690d9f56e5f95de5f67a4
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 13b8611aea65ffa1177b34387dd9f02f3cbe9045
https://github.com/Perl/perl5/commit/13b8611aea65ffa1177b34387dd9f02f3cbe9045
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: f8098593a6019de896a53b7df1f1c6ad6be5da5b
https://github.com/Perl/perl5/commit/f8098593a6019de896a53b7df1f1c6ad6be5da5b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 6af5d5855096ec8eeed2c08b0c39a33d51fbd63e
https://github.com/Perl/perl5/commit/6af5d5855096ec8eeed2c08b0c39a33d51fbd63e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 97882def226f651e0885e4d9015c4b22f75d7434
https://github.com/Perl/perl5/commit/97882def226f651e0885e4d9015c4b22f75d7434
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 0dc4e7b9c9467b0e03a44fbcd394ab89474a176e
https://github.com/Perl/perl5/commit/0dc4e7b9c9467b0e03a44fbcd394ab89474a176e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 2595f8562be410ecdf2ac4d5db059b71a901dc3f
https://github.com/Perl/perl5/commit/2595f8562be410ecdf2ac4d5db059b71a901dc3f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: ad875c21e68ddb9d575cc20cdf29834e07d118e8
https://github.com/Perl/perl5/commit/ad875c21e68ddb9d575cc20cdf29834e07d118e8
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 57abae2c2904b70882dbc04b1b7bd4270381c3e1
https://github.com/Perl/perl5/commit/57abae2c2904b70882dbc04b1b7bd4270381c3e1
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 56d8f7c3c2d95f6f803d2a85b40fd0677c03333f
https://github.com/Perl/perl5/commit/56d8f7c3c2d95f6f803d2a85b40fd0677c03333f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 7f7b529580718b51dd476d710509b9efe5d72fd8
https://github.com/Perl/perl5/commit/7f7b529580718b51dd476d710509b9efe5d72fd8
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 9341acb71eb08a15ad265f116f3a0510688ed97d
https://github.com/Perl/perl5/commit/9341acb71eb08a15ad265f116f3a0510688ed97d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: a3b5daa7c7fb86a0fb8dc8955a7c17e5b8d0cdef
https://github.com/Perl/perl5/commit/a3b5daa7c7fb86a0fb8dc8955a7c17e5b8d0cdef
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 5a5f5bb87689a9c98dec3e7d47f3c57e143597ca
https://github.com/Perl/perl5/commit/5a5f5bb87689a9c98dec3e7d47f3c57e143597ca
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 128e84bd45e1baf11a93cc6e01a5cc971f627637
https://github.com/Perl/perl5/commit/128e84bd45e1baf11a93cc6e01a5cc971f627637
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: cf25b97c1d9e07ba47c8118e4bda69c84727aa3c
https://github.com/Perl/perl5/commit/cf25b97c1d9e07ba47c8118e4bda69c84727aa3c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: 129e6ea128f695e06026cd01a835e97735373998
https://github.com/Perl/perl5/commit/129e6ea128f695e06026cd01a835e97735373998
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 54622c75a7ee28062ce000859ee4332291b7d280
https://github.com/Perl/perl5/commit/54622c75a7ee28062ce000859ee4332291b7d280
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 4c5b69a137a1a618a92ab6a26a2241ccdb136025
https://github.com/Perl/perl5/commit/4c5b69a137a1a618a92ab6a26a2241ccdb136025
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 536f9ecf063e2b335e3d6bb80f480fbcfe701df1
https://github.com/Perl/perl5/commit/536f9ecf063e2b335e3d6bb80f480fbcfe701df1
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 697d3a1b74e34e843c70b8e6d159376e19b0593f
https://github.com/Perl/perl5/commit/697d3a1b74e34e843c70b8e6d159376e19b0593f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 153021d75dc184d3d8e17e32daff93fb20a1d6fe
https://github.com/Perl/perl5/commit/153021d75dc184d3d8e17e32daff93fb20a1d6fe
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: f32af3bc02e377dd98e6af1974857f814563435a
https://github.com/Perl/perl5/commit/f32af3bc02e377dd98e6af1974857f814563435a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: fa34f861edf946fd25485b9920e24f276ace9d6e
https://github.com/Perl/perl5/commit/fa34f861edf946fd25485b9920e24f276ace9d6e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: e18c0f8db18a58ad5dbbf1173c7d9be755da085e
https://github.com/Perl/perl5/commit/e18c0f8db18a58ad5dbbf1173c7d9be755da085e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 9f1aeba0042a79b43ad9de449c6d526c53dff289
https://github.com/Perl/perl5/commit/9f1aeba0042a79b43ad9de449c6d526c53dff289
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 440120917bbd57d090fe8fbc980b1f4530e48a58
https://github.com/Perl/perl5/commit/440120917bbd57d090fe8fbc980b1f4530e48a58
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 8830f7388c6a5260af17cbdb3509a438292440a2
https://github.com/Perl/perl5/commit/8830f7388c6a5260af17cbdb3509a438292440a2
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 0c0863703f8affca1fc8c70a5bd12550400915ae
https://github.com/Perl/perl5/commit/0c0863703f8affca1fc8c70a5bd12550400915ae
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 4776601f326bf34512743e745d9da630bce1ef1b
https://github.com/Perl/perl5/commit/4776601f326bf34512743e745d9da630bce1ef1b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: e26f7225dd783e5fa99b54ba73dec0cd013aeb9b
https://github.com/Perl/perl5/commit/e26f7225dd783e5fa99b54ba73dec0cd013aeb9b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: b2102e4f38888f46e43b1915b4a9e7e8e0168e68
https://github.com/Perl/perl5/commit/b2102e4f38888f46e43b1915b4a9e7e8e0168e68
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 771ba298082113ba4f86ec8367161575c1045c64
https://github.com/Perl/perl5/commit/771ba298082113ba4f86ec8367161575c1045c64
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 86f787b24dd81222615ffa50cf5684b091f76874
https://github.com/Perl/perl5/commit/86f787b24dd81222615ffa50cf5684b091f76874
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: df8094b9e303233626dad525015ea89389ef2a8c
https://github.com/Perl/perl5/commit/df8094b9e303233626dad525015ea89389ef2a8c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 694eacc864d2e1ea65c6d899ad6b3a904ba12d69
https://github.com/Perl/perl5/commit/694eacc864d2e1ea65c6d899ad6b3a904ba12d69
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 8be8b6149ba95dd615f7e22f520ac29d0ee151d1
https://github.com/Perl/perl5/commit/8be8b6149ba95dd615f7e22f520ac29d0ee151d1
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: bca7f72aa739b00e10a6488c5d07c72d9d8bf801
https://github.com/Perl/perl5/commit/bca7f72aa739b00e10a6488c5d07c72d9d8bf801
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 7434b6ef84fbe00fa1347cd734b6017ae3823e6d
https://github.com/Perl/perl5/commit/7434b6ef84fbe00fa1347cd734b6017ae3823e6d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 6d8000d81c265f00302d8a96dd2c25d53cdbd4f7
https://github.com/Perl/perl5/commit/6d8000d81c265f00302d8a96dd2c25d53cdbd4f7
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: c6c5adb4320be7dc7ae2d6d4a0c905a50765a37c
https://github.com/Perl/perl5/commit/c6c5adb4320be7dc7ae2d6d4a0c905a50765a37c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 312c14bb12d3269b82f9c6abe94f42b81e0e7c01
https://github.com/Perl/perl5/commit/312c14bb12d3269b82f9c6abe94f42b81e0e7c01
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 2c2ce454d044af9b6869d33ce9aa74da175ce81d
https://github.com/Perl/perl5/commit/2c2ce454d044af9b6869d33ce9aa74da175ce81d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 58dbdecd3f1f4042b2db5187baadab957f78ba72
https://github.com/Perl/perl5/commit/58dbdecd3f1f4042b2db5187baadab957f78ba72
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 51fd0890a6144abfb6089eb55a00ad90cf528400
https://github.com/Perl/perl5/commit/51fd0890a6144abfb6089eb55a00ad90cf528400
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: e69336bcc7e6751915899d92d9860d9201aecf51
https://github.com/Perl/perl5/commit/e69336bcc7e6751915899d92d9860d9201aecf51
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: e81c3e4adb517f928a9c4a6e0b498069ddbe653b
https://github.com/Perl/perl5/commit/e81c3e4adb517f928a9c4a6e0b498069ddbe653b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: c6d97df5b4137a4e1f77f8296b6e22d1fcb1dfbd
https://github.com/Perl/perl5/commit/c6d97df5b4137a4e1f77f8296b6e22d1fcb1dfbd
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: f91d02e1fd4bb817d66a61e93b2096f9b58e1331
https://github.com/Perl/perl5/commit/f91d02e1fd4bb817d66a61e93b2096f9b58e1331
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: df9116a4ab73fbbc35bb3af9c47fdfff9b6cad27
https://github.com/Perl/perl5/commit/df9116a4ab73fbbc35bb3af9c47fdfff9b6cad27
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: dbe87abd57d777b963c11451dde8827d865b97f3
https://github.com/Perl/perl5/commit/dbe87abd57d777b963c11451dde8827d865b97f3
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: f7dd48f1822640b6cf1349ef4e40a63a5eba3f90
https://github.com/Perl/perl5/commit/f7dd48f1822640b6cf1349ef4e40a63a5eba3f90
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 72c9ffa9826eca8210f8b784bcc4b4303b9ddfc0
https://github.com/Perl/perl5/commit/72c9ffa9826eca8210f8b784bcc4b4303b9ddfc0
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 8592dc92cbe737a53500f5110eb3eaf4e35f3337
https://github.com/Perl/perl5/commit/8592dc92cbe737a53500f5110eb3eaf4e35f3337
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 427fb9f56555ea65c869fcf899546f8f04d99387
https://github.com/Perl/perl5/commit/427fb9f56555ea65c869fcf899546f8f04d99387
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 1f03d1fb98f1cb47ec93cc4ee0aca83f7ccdc85c
https://github.com/Perl/perl5/commit/1f03d1fb98f1cb47ec93cc4ee0aca83f7ccdc85c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 8cba5b2dc9ef540c572391462da824aaa28e71fe
https://github.com/Perl/perl5/commit/8cba5b2dc9ef540c572391462da824aaa28e71fe
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 904fff20f66c268f4f5e3b72c57696b9994d3698
https://github.com/Perl/perl5/commit/904fff20f66c268f4f5e3b72c57696b9994d3698
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 6fd45ba6d385606271d5a721db0a3b83b43135a7
https://github.com/Perl/perl5/commit/6fd45ba6d385606271d5a721db0a3b83b43135a7
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 6e33a8ae0b46b9927d1a0f3e5a3d37c1deaca596
https://github.com/Perl/perl5/commit/6e33a8ae0b46b9927d1a0f3e5a3d37c1deaca596
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 934ab03d4cb7cff595572546d23422c57cb5aa6b
https://github.com/Perl/perl5/commit/934ab03d4cb7cff595572546d23422c57cb5aa6b
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 53073dcfc7a803b6210fc125893c2f62f585ca2c
https://github.com/Perl/perl5/commit/53073dcfc7a803b6210fc125893c2f62f585ca2c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: f23b0c5e417f62087667c52c1835299cfcb8682d
https://github.com/Perl/perl5/commit/f23b0c5e417f62087667c52c1835299cfcb8682d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 6521ccd684e8d249764aab6043fb2e4e30dc718c
https://github.com/Perl/perl5/commit/6521ccd684e8d249764aab6043fb2e4e30dc718c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: b18207c3215ad750b920f2c26697e94c05c4ff27
https://github.com/Perl/perl5/commit/b18207c3215ad750b920f2c26697e94c05c4ff27
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: b787e155dfc68f157330debfa5a2a30fd8f01d5c
https://github.com/Perl/perl5/commit/b787e155dfc68f157330debfa5a2a30fd8f01d5c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 90a8b07c8862c63734b4c7942a5360166d3755fe
https://github.com/Perl/perl5/commit/90a8b07c8862c63734b4c7942a5360166d3755fe
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: d4858feb3b25e68d70696dc1f8394e9a68f95e0c
https://github.com/Perl/perl5/commit/d4858feb3b25e68d70696dc1f8394e9a68f95e0c
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: 42e0234f77486a61c52432962fec034ceb99bf89
https://github.com/Perl/perl5/commit/42e0234f77486a61c52432962fec034ceb99bf89
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: 9f082b73056bf7e16572c76cbd790a9a91df39ca
https://github.com/Perl/perl5/commit/9f082b73056bf7e16572c76cbd790a9a91df39ca
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: af556dd16ae3369cce1196a8ab82c68ffe0496ea
https://github.com/Perl/perl5/commit/af556dd16ae3369cce1196a8ab82c68ffe0496ea
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: 66136c2407282945b4aba83c1dc91c98d1f6fa2d
https://github.com/Perl/perl5/commit/66136c2407282945b4aba83c1dc91c98d1f6fa2d
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: f7951dc073a1ba048b0b310f009127ed68571718
https://github.com/Perl/perl5/commit/f7951dc073a1ba048b0b310f009127ed68571718
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: 1ab0412e1c72f72110bf95eaa4582e7e554bd0db
https://github.com/Perl/perl5/commit/1ab0412e1c72f72110bf95eaa4582e7e554bd0db
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: d68082b69226a15c4d4a8ee8d759d4956701d7b9
https://github.com/Perl/perl5/commit/d68082b69226a15c4d4a8ee8d759d4956701d7b9
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 87093384ee329852184d818c0f85655f5dda3fb2
https://github.com/Perl/perl5/commit/87093384ee329852184d818c0f85655f5dda3fb2
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 38bd1e251568c4912edc8a5e6a407e108c634e9f
https://github.com/Perl/perl5/commit/38bd1e251568c4912edc8a5e6a407e108c634e9f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: cc13768937cf0c34c7948ecdd5d8315650c9050a
https://github.com/Perl/perl5/commit/cc13768937cf0c34c7948ecdd5d8315650c9050a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: 9c875d1c1f1cb42e2c4e61d29db6f2b91d9998e0
https://github.com/Perl/perl5/commit/9c875d1c1f1cb42e2c4e61d29db6f2b91d9998e0
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: ef8edd7888245d02ac4e52dcd8c8c6cbcce8bcd4
https://github.com/Perl/perl5/commit/ef8edd7888245d02ac4e52dcd8c8c6cbcce8bcd4
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: af917d5a72196651f336bf8b40292d7234286490
https://github.com/Perl/perl5/commit/af917d5a72196651f336bf8b40292d7234286490
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: e2ad5b99ed366a7d5cc071763216a92d34c47347
https://github.com/Perl/perl5/commit/e2ad5b99ed366a7d5cc071763216a92d34c47347
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: 8bd8c7b07424f1664ff99d1a890d7e60b5dbfee3
https://github.com/Perl/perl5/commit/8bd8c7b07424f1664ff99d1a890d7e60b5dbfee3
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: 4eaf105806290ab86aac89137507c7eca8994f34
https://github.com/Perl/perl5/commit/4eaf105806290ab86aac89137507c7eca8994f34
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: a6940496b3b655f05fcf819c7b00392a702d0712
https://github.com/Perl/perl5/commit/a6940496b3b655f05fcf819c7b00392a702d0712
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: 930c7bdfbcb3318b7a0d88304f57aefaf6f86069
https://github.com/Perl/perl5/commit/930c7bdfbcb3318b7a0d88304f57aefaf6f86069
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: a44d97c5125b167597d58a66af5b8ac1d4d5ff4e
https://github.com/Perl/perl5/commit/a44d97c5125b167597d58a66af5b8ac1d4d5ff4e
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: 1df7ef37eed880514877f4e4e1e09929065e42cf
https://github.com/Perl/perl5/commit/1df7ef37eed880514877f4e4e1e09929065e42cf
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: a3b429663905c49f2eb7186bcae4ac1335b1a4e3
https://github.com/Perl/perl5/commit/a3b429663905c49f2eb7186bcae4ac1335b1a4e3
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads debugging
Commit: fb8406d5278ce484c6e2c5125457294c15a8029a
https://github.com/Perl/perl5/commit/fb8406d5278ce484c6e2c5125457294c15a8029a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: 8a4a59d9bb970c85940f8ce5140a57633c947921
https://github.com/Perl/perl5/commit/8a4a59d9bb970c85940f8ce5140a57633c947921
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: 6b395752c3ecc388763cabc29d5a2d221e6b5430
https://github.com/Perl/perl5/commit/6b395752c3ecc388763cabc29d5a2d221e6b5430
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg,thread_init Revamp sync_locale, switch_to_global_locale
f
Commit: cd8e6615b4111aab2ef7720bc5c9bdb20c7e05a1
https://github.com/Perl/perl5/commit/cd8e6615b4111aab2ef7720bc5c9bdb20c7e05a1
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv duplicate clones
These variables are already cloned when creating a thread
Commit: a767006c31d5cac9dabb60ae74be74767f74880f
https://github.com/Perl/perl5/commit/a767006c31d5cac9dabb60ae74be74767f74880f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv redundant clause
If threaded locales are being used, basic locales are too. No need to
check both
Commit: 7f55373857be7b08553ccf033aa7b537d116ebb3
https://github.com/Perl/perl5/commit/7f55373857be7b08553ccf033aa7b537d116ebb3
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
M lib/locale.t
Log Message:
-----------
Fix isspace() handling on AIX
This box incorrectly thinks the NBSP is a graphic on many locales.
Overriding that makes these locales behave like proper POSIX ones.
Commit: 9aa7a56e0c4a1265ade9bf9ebb8e0dcc439817d1
https://github.com/Perl/perl5/commit/9aa7a56e0c4a1265ade9bf9ebb8e0dcc439817d1
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: White-space only
Replace leading tabs with spaces
Commit: 74fee550b0ced759391e8bbd3de50dd713b160d6
https://github.com/Perl/perl5/commit/74fee550b0ced759391e8bbd3de50dd713b160d6
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M hints/cygwin.sh
Log Message:
-----------
XXX check if really necessary after everything: Don't use POSIX 2008 locale
This has been found to be buggy leading to dying inside the newlocale()
in S_emulate_setlocale_i()
Commit: fe7f52be7abef929fe6f9b4892e27fa76f552a1a
https://github.com/Perl/perl5/commit/fe7f52be7abef929fe6f9b4892e27fa76f552a1a
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t: Use I18N::Langinfo, not POSIX::localeconv()
Now that Langinfo is ported to every box, it requires less work than
localeconv(), and offers more choices. This commit changes to use it,
and for more info when debugging, gets some additional info from it.
Commit: 437412568f0a33150d52b999608a0215c6d01346
https://github.com/Perl/perl5/commit/437412568f0a33150d52b999608a0215c6d01346
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX cygwin debugging small macro buf
Commit: ae13da7d6d39ac53c076773161be67c192b3d32f
https://github.com/Perl/perl5/commit/ae13da7d6d39ac53c076773161be67c192b3d32f
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Avoid unnecessary calls to set_numeric_standard()
Prior to this commit, set_numeric_standard() was called unconditionally,
and it could decide if it should do anything or not. But the variable
that indicates this is available to the caller, so by testing it, it can
avoid the call, which is most likely the case.
Commit: 212bae9aeb6f8aa5d7b45e26cdd4124d55c5b664
https://github.com/Perl/perl5/commit/212bae9aeb6f8aa5d7b45e26cdd4124d55c5b664
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging trace across all files
Commit: 71b8f0eaf8fa2e6777fb186de637e3375289eafc
https://github.com/Perl/perl5/commit/71b8f0eaf8fa2e6777fb186de637e3375289eafc
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Use internal querylocale on Linux
XXX Need to bisect to see where this goes bad
XXX Is effectively a no-op due to other debugging code
Commit: b48896c4facffdadaa38c64b45397cebc6ca1ff6
https://github.com/Perl/perl5/commit/b48896c4facffdadaa38c64b45397cebc6ca1ff6
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M handy.h
M iperlsys.h
M locale.c
M perl.h
M pod/perllocale.pod
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: 7f2852e899e354123a7d821fbc9b5441fef53283
https://github.com/Perl/perl5/commit/7f2852e899e354123a7d821fbc9b5441fef53283
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M ext/I18N-Langinfo/t/Langinfo.t
M ext/POSIX/POSIX.xs
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M makedef.pl
M mg.c
M perl.c
M perl.h
M proto.h
M regexec.c
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
57
Commit: e685bc26c3ffa67143d239261dcd272d4d02e602
https://github.com/Perl/perl5/commit/e685bc26c3ffa67143d239261dcd272d4d02e602
Author: Karl Williamson <[email protected]>
Date: 2021-05-05 (Wed, 05 May 2021)
Changed paths:
M lib/locale_threads.t
M locale.c
M pp.c
Log Message:
-----------
61
Compare: https://github.com/Perl/perl5/compare/5f11090fd998...e685bc26c3ff
