Branch: refs/heads/blead
Home: https://github.com/Perl/perl5
Commit: 50df9eae4e3888a9ffd0061b0e2d91972839c6b1
https://github.com/Perl/perl5/commit/50df9eae4e3888a9ffd0061b0e2d91972839c6b1
Author: James E Keenan <[email protected]>
Date: 2021-08-23 (Mon, 23 Aug 2021)
Changed paths:
M ext/Pod-Html/lib/Pod/Html.pm
M ext/Pod-Html/lib/Pod/Html/Util.pm
M ext/Pod-Html/t/lib/Testing.pm
Log Message:
-----------
Increment $VERSION to 1.33 in all .pm files
Commit: f8cf53b8d2ba53107aca1b08864386f1340c2058
https://github.com/Perl/perl5/commit/f8cf53b8d2ba53107aca1b08864386f1340c2058
Author: James E Keenan <[email protected]>
Date: 2021-08-23 (Mon, 23 Aug 2021)
Changed paths:
M ext/Pod-Html/lib/Pod/Html.pm
Log Message:
-----------
Start to make Pod::Html object-oriented.
For the time being, at least, we'll have pod2html() call a constructor.
All subs up through refine_globals have been turned into method calls.
Signed-off-by: James E Keenan <[email protected]>
Commit: 2d1284dc4e597109945e02357a11ca3035fcd131
https://github.com/Perl/perl5/commit/2d1284dc4e597109945e02357a11ca3035fcd131
Author: James E Keenan <[email protected]>
Date: 2021-08-23 (Mon, 23 Aug 2021)
Changed paths:
M ext/Pod-Html/lib/Pod/Html.pm
Log Message:
-----------
File::Spec::Unix is not needed within package Pod::Html
It's only needed within Pod::Simple::XHTML::LocalPodLinks, so let's
remove it from the first package.
Signed-off-by: James E Keenan <[email protected]>
Commit: fb5291d5ec7e496fb3644ac4dd014f2be8cff96a
https://github.com/Perl/perl5/commit/fb5291d5ec7e496fb3644ac4dd014f2be8cff96a
Author: James E Keenan <[email protected]>
Date: 2021-08-23 (Mon, 23 Aug 2021)
Changed paths:
M ext/Pod-Html/lib/Pod/Html.pm
Log Message:
-----------
Make get_cache(), cache_key() and load_cache() use object
Signed-off-by: James E Keenan <[email protected]>
Commit: db6e96c4db5fa8577aa6db9fb6550f126af11e15
https://github.com/Perl/perl5/commit/db6e96c4db5fa8577aa6db9fb6550f126af11e15
Author: James E Keenan <[email protected]>
Date: 2021-08-23 (Mon, 23 Aug 2021)
Changed paths:
M ext/Pod-Html/lib/Pod/Html.pm
Log Message:
-----------
Have generate_cache() use object
Still have to deal with %Pages being outside the object.
Signed-off-by: James E Keenan <[email protected]>
Commit: 8e5a9496f9ae4f398a9cc25054054226914cd445
https://github.com/Perl/perl5/commit/8e5a9496f9ae4f398a9cc25054054226914cd445
Author: James E Keenan <[email protected]>
Date: 2021-08-23 (Mon, 23 Aug 2021)
Changed paths:
M ext/Pod-Html/lib/Pod/Html.pm
Log Message:
-----------
Turn 3 more internal subroutines into method calls
identify_input(); parse_input_for_podtree(); set_Title_from_podtree();
Signed-off-by: James E Keenan <[email protected]>
Commit: b9cd5823f4b35b7d870d17a180afa9d91cc3f3dd
https://github.com/Perl/perl5/commit/b9cd5823f4b35b7d870d17a180afa9d91cc3f3dd
Author: James E Keenan <[email protected]>
Date: 2021-08-23 (Mon, 23 Aug 2021)
Changed paths:
M ext/Pod-Html/lib/Pod/Html.pm
Log Message:
-----------
Convert 3 more subroutines to method calls
refine_parser(); feed_tree_to_parser(); write_file()
Signed-off-by: James E Keenan <[email protected]>
Commit: 06dda0b0ccbe2aec353c1a8c1bd1ea3adb085b4a
https://github.com/Perl/perl5/commit/06dda0b0ccbe2aec353c1a8c1bd1ea3adb085b4a
Author: James E Keenan <[email protected]>
Date: 2021-08-23 (Mon, 23 Aug 2021)
Changed paths:
M ext/Pod-Html/lib/Pod/Html.pm
Log Message:
-----------
Replace _save_pages() with _transform()
_save_pages() is a Pod::Simple::Search method which takes two specific
arguments. From the point of view of making Pod-Html OO, it was
problematic because (a) it used a variable ($Podroot) defined outside of
its scope and (b) it assigned to a variable (%Pages) defined outside of
its scope. It was therefore resistant to encapsulation.
Experimentation showed that if we use the return value of
Pod::Simple::Search::survey(), we could parse that hashref using what
was the guts of _save_pages() and assign explicitly to %Pages.
TODO: Move %Pages within the Pod::Html object. Handle $object
properly.
Signed-off-by: James E Keenan <[email protected]>
Remove merge conflict marks, commented-out code, as noted by rjbs in
https://github.com/Perl/perl5/pull/19050#discussion_r693559914.
Commit: 0e74e9b028173e63b960835f7ba58e379dd18e0e
https://github.com/Perl/perl5/commit/0e74e9b028173e63b960835f7ba58e379dd18e0e
Author: James E Keenan <[email protected]>
Date: 2021-08-23 (Mon, 23 Aug 2021)
Changed paths:
M ext/Pod-Html/lib/Pod/Html.pm
Log Message:
-----------
Move $output into the object
Correct dropped variable declaration.
Signed-off-by: James E Keenan <[email protected]>
Commit: b33902f54359a709bf04c14e2458c127cf8d9b90
https://github.com/Perl/perl5/commit/b33902f54359a709bf04c14e2458c127cf8d9b90
Author: James E Keenan <[email protected]>
Date: 2021-08-23 (Mon, 23 Aug 2021)
Changed paths:
M ext/Pod-Html/lib/Pod/Html.pm
M ext/Pod-Html/t/htmldir3.t
Log Message:
-----------
Introduce $self->{Pages}
htmldir3.t: 3rd test unit is now expected to fail. So now the test file
demonstrates that the unit fails whether it's placed before the second
unit or after.
Signed-off-by: James E Keenan <[email protected]>
Commit: b2a21b5cd49a33cd078c64d0918a98320fb79a77
https://github.com/Perl/perl5/commit/b2a21b5cd49a33cd078c64d0918a98320fb79a77
Author: James E Keenan <[email protected]>
Date: 2021-08-23 (Mon, 23 Aug 2021)
Changed paths:
M ext/Pod-Html/lib/Pod/Html.pm
M ext/Pod-Html/lib/Pod/Html/Util.pm
M ext/Pod-Html/t/lib/Testing.pm
Log Message:
-----------
Pod-Html: remove commented-out code
Make use of Exporter consistent.
Commit: a358e746a4e1efa73acc4356b9aeb8112f775169
https://github.com/Perl/perl5/commit/a358e746a4e1efa73acc4356b9aeb8112f775169
Author: James E Keenan <[email protected]>
Date: 2021-08-23 (Mon, 23 Aug 2021)
Changed paths:
M ext/Pod-Html/lib/Pod/Html.pm
Log Message:
-----------
Pod::Html: assign directly to array ref
This restores the thrust of c0ac28175b, which got zapped when resolving
merge conflicts.
Commit: 7e493be2db2f292ccda80be1a741776e2cf1cf5b
https://github.com/Perl/perl5/commit/7e493be2db2f292ccda80be1a741776e2cf1cf5b
Author: James E Keenan <[email protected]>
Date: 2021-08-23 (Mon, 23 Aug 2021)
Changed paths:
M ext/Pod-Html/lib/Pod/Html.pm
Log Message:
-----------
Pod::Html: remove debugging artifact
As noted by @Grinnz in
https://github.com/Perl/perl5/pull/19050#discussion_r688969538.
Commit: c79df2fbe5099d0b8e1cc40b40c332fb06b088db
https://github.com/Perl/perl5/commit/c79df2fbe5099d0b8e1cc40b40c332fb06b088db
Author: James E Keenan <[email protected]>
Date: 2021-08-23 (Mon, 23 Aug 2021)
Changed paths:
M ext/Pod-Html/lib/Pod/Html.pm
Log Message:
-----------
Pod::Html: remove debugging artifact
As noted by @Grinnz in
https://github.com/Perl/perl5/pull/19050#discussion_r688969025.
Commit: 4c43b5bf9862d97c61dede3abada60af15eb1cc2
https://github.com/Perl/perl5/commit/4c43b5bf9862d97c61dede3abada60af15eb1cc2
Author: James E Keenan <[email protected]>
Date: 2021-08-23 (Mon, 23 Aug 2021)
Changed paths:
M ext/Pod-Html/lib/Pod/Html.pm
Log Message:
-----------
Pod::Html: correct line dropped in 13f1edeb52
As noted by @Grinnz in
https://github.com/Perl/perl5/pull/19050#discussion_r688968921.
Commit: 96ce139047ccf31b0223a93eb400a880b07a54c5
https://github.com/Perl/perl5/commit/96ce139047ccf31b0223a93eb400a880b07a54c5
Author: James E Keenan <[email protected]>
Date: 2021-08-23 (Mon, 23 Aug 2021)
Changed paths:
M ext/Pod-Html/lib/Pod/Html.pm
M ext/Pod-Html/lib/Pod/Html/Util.pm
M ext/Pod-Html/t/htmldir3.t
M ext/Pod-Html/t/lib/Testing.pm
Log Message:
-----------
Merge branch 'pod-html-refactoring-5-of-5' into blead
Compare: https://github.com/Perl/perl5/compare/38b5dc294ed4...96ce139047cc
