Branch: refs/heads/blead
  Home:   https://github.com/Perl/perl5
  Commit: 3254d4a679560c0d112aa8edc87177b6610c701a
      
https://github.com/Perl/perl5/commit/3254d4a679560c0d112aa8edc87177b6610c701a
  Author: Karl Williamson <[email protected]>
  Date:   2022-09-01 (Thu, 01 Sep 2022)

  Changed paths:
    M locale.c

  Log Message:
  -----------
  locale.c: Reorder code

This commit makes the trivial case first in a conditional compilation
line, as that is easier to comprehend.


  Commit: 775f50ab5d8d6730a8a76ff863144447cff23e8b
      
https://github.com/Perl/perl5/commit/775f50ab5d8d6730a8a76ff863144447cff23e8b
  Author: Karl Williamson <[email protected]>
  Date:   2022-09-01 (Thu, 01 Sep 2022)

  Changed paths:
    M locale.c

  Log Message:
  -----------
  locale.c: Reorder 'if' branches

It's better for understandability to have positive tests than negative
ones


  Commit: fcf05094b2966c0bc0d639a8d4f7697c8ce2e987
      
https://github.com/Perl/perl5/commit/fcf05094b2966c0bc0d639a8d4f7697c8ce2e987
  Author: Karl Williamson <[email protected]>
  Date:   2022-09-01 (Thu, 01 Sep 2022)

  Changed paths:
    M locale.c

  Log Message:
  -----------
  locale.c: Refactor S_new_numeric()

S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.

This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier.  This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.

Explanatory comments are also added.


  Commit: 759f440699165404333ddf8bb8ff614563a3d2c4
      
https://github.com/Perl/perl5/commit/759f440699165404333ddf8bb8ff614563a3d2c4
  Author: Karl Williamson <[email protected]>
  Date:   2022-09-01 (Thu, 01 Sep 2022)

  Changed paths:
    M embed.fnc
    M locale.c
    M proto.h

  Log Message:
  -----------
  locale.c: Rmv unused code in changing LC_NUMERIC

The code to handle changing LC_NUMERIC handled the possibility of being
passed a NULL locale name.  But we're not changing things unless we have
a new locale, and know its name, so a name is always passed


  Commit: 3d3a0c7eea7bfaa5d3cfad5522675a66d363afc7
      
https://github.com/Perl/perl5/commit/3d3a0c7eea7bfaa5d3cfad5522675a66d363afc7
  Author: Karl Williamson <[email protected]>
  Date:   2022-09-01 (Thu, 01 Sep 2022)

  Changed paths:
    M locale.c

  Log Message:
  -----------
  locale.c: Mv line of code later in fcn

This avoids setting this until needed.


  Commit: 818cdb7aa9f85227c1c7313257c6204c872beb94
      
https://github.com/Perl/perl5/commit/818cdb7aa9f85227c1c7313257c6204c872beb94
  Author: Karl Williamson <[email protected]>
  Date:   2022-09-01 (Thu, 01 Sep 2022)

  Changed paths:
    M locale.c

  Log Message:
  -----------
  locale.c: Skip code if will be a no-op

The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return


  Commit: 22bb228247b201b8ce29a2e5a5c0fa164a306c11
      
https://github.com/Perl/perl5/commit/22bb228247b201b8ce29a2e5a5c0fa164a306c11
  Author: Karl Williamson <[email protected]>
  Date:   2022-09-01 (Thu, 01 Sep 2022)

  Changed paths:
    M locale.c

  Log Message:
  -----------
  locale.c: Specially handle the trivial case

When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further.  All the
ancillary info is also known.  So save time and just set these all and
return.


  Commit: 98c5f15cfe00e491f40f48200d502db1d133abfd
      
https://github.com/Perl/perl5/commit/98c5f15cfe00e491f40f48200d502db1d133abfd
  Author: Karl Williamson <[email protected]>
  Date:   2022-09-01 (Thu, 01 Sep 2022)

  Changed paths:
    M numeric.c

  Log Message:
  -----------
  numeric.: Rmv outdated condition

It hasn't been true for some releases that the SV was removed when the
radix was a dot.  Instead the SV contains the correct decimal point
character at all times.


  Commit: 430ae200b5739fbee33c70114a733afecbced76c
      
https://github.com/Perl/perl5/commit/430ae200b5739fbee33c70114a733afecbced76c
  Author: Karl Williamson <[email protected]>
  Date:   2022-09-01 (Thu, 01 Sep 2022)

  Changed paths:
    M locale.c

  Log Message:
  -----------
  locale.c: Swap setting related variables

It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa


  Commit: 37b8263e6d237e6e7d0e92a6c311d9b6121ea57c
      
https://github.com/Perl/perl5/commit/37b8263e6d237e6e7d0e92a6c311d9b6121ea57c
  Author: Karl Williamson <[email protected]>
  Date:   2022-09-01 (Thu, 01 Sep 2022)

  Changed paths:
    M embedvar.h
    M intrpvar.h
    M locale.c
    M perl.c
    M sv.c

  Log Message:
  -----------
  locale.c: Save underlying radix character

When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.

The calculation is still performed twice when the new locale is switched
into.  But the redundant calculation will be removed in a couple of
commits hence.


  Commit: 7506c6d9dcd4aa3087080b663d02aaae91074d60
      
https://github.com/Perl/perl5/commit/7506c6d9dcd4aa3087080b663d02aaae91074d60
  Author: Karl Williamson <[email protected]>
  Date:   2022-09-01 (Thu, 01 Sep 2022)

  Changed paths:
    M locale.c

  Log Message:
  -----------
  locale.c: Move debug stmt to earlier in fcn


  Commit: 6cd93f2af51b2c45bd9e1c180d10bea1bfa226c7
      
https://github.com/Perl/perl5/commit/6cd93f2af51b2c45bd9e1c180d10bea1bfa226c7
  Author: Karl Williamson <[email protected]>
  Date:   2022-09-01 (Thu, 01 Sep 2022)

  Changed paths:
    M embed.fnc
    M embed.h
    M locale.c
    M proto.h

  Log Message:
  -----------
  locale.c: Rmv S_set_numeric_radix()

Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message


  Commit: 992e38c75c3458a29260860388d37ee4204e864e
      
https://github.com/Perl/perl5/commit/992e38c75c3458a29260860388d37ee4204e864e
  Author: Karl Williamson <[email protected]>
  Date:   2022-09-01 (Thu, 01 Sep 2022)

  Changed paths:
    M embed.fnc
    M embed.h
    M embedvar.h
    M intrpvar.h
    M locale.c
    M numeric.c
    M perl.c
    M proto.h
    M sv.c

  Log Message:
  -----------
  Merge branch 'locale.c: Improve newnumeric()' into blead

This function is called when LC_NUMERIC is changed. This series of
commits reorders things so as to perform less work by performing things
earlier that later things depend on.


Compare: https://github.com/Perl/perl5/compare/0c33882a9438...992e38c75c34

Reply via email to