Branch: refs/heads/yves/ws_cleanup_headers
  Home:   https://github.com/Perl/perl5
  Commit: 9fa8963c800da25671777d7befcd0986eee932a9
      
https://github.com/Perl/perl5/commit/9fa8963c800da25671777d7befcd0986eee932a9
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M dquote.c
    M op.c
    M os2/os2ish.h
    M perl.h
    M t/porting/diag.t

  Log Message:
  -----------
  porting/diag.t - improved parsing a bit

The "multiline" logic of diag.t was getting confused by define
statements that would define a symbol to call an error function but not
end in ";", this would then slurp potentially many lines errorenously,
potentially absorbing more than one message. The multi-line logic also
would undef $listed_as and lose the diag_listed_as data in some
circumstances.

Fixing those issues revealed some interesting cases. To fix one of them
I defined a new noop macro in perl.h to help: PERL_DIAG_WARN_SYNTAX(),
which helps the diag.t parser identify messages without needing to be
actually part of a specific message line. These macros are noops, they
just return their argument, but they help hint to diag.t what is going
on. Maybe in the future this can be reworked to be more generic, there
are other similar cases that are not covered.

Interestingly fixing this bug meant that at least one message that used
to be erroneously picked up was no longer identified or tested. This was
replaced with a PERL_DIAG_DIE_SYNTAX() wrapper.


  Commit: 9cfc60a1612fa9a4912088a0538224830c462ca0
      
https://github.com/Perl/perl5/commit/9cfc60a1612fa9a4912088a0538224830c462ca0
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M regen/regcomp.pl

  Log Message:
  -----------
  regen/regcomp.pl - make robust to line continuations in header files

I noticed that tests fail if some of these defines are changed to use a
line continuation. This fixes the problem.

For instance, some of the defines that are parsed by this code are
rather long and if they get broken into a multiline statement with
C pre processor style line continuations they would get dropped from
regnodes.h and our debug output.


  Commit: 20786ec37d08a6894c9f24d6754f7d4a1904f013
      
https://github.com/Perl/perl5/commit/20786ec37d08a6894c9f24d6754f7d4a1904f013
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M ext/XS-APItest/t/locale.t

  Log Message:
  -----------
  XS-APItest/t/locale.t - deal with indented values properly

The old code used a regex that would split on exactly one space, so if
the data was changed to have more than one then it would get absorbed
into the name that was parsed out of the header file, leading the code
to test for things like "FOO ", which of course don't exist. Likely this
could have caused other issues too, but the defines in practice are
single symbols.


  Commit: e54b31eb7b6f3791b7081707976acec9122c9e1d
      
https://github.com/Perl/perl5/commit/e54b31eb7b6f3791b7081707976acec9122c9e1d
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M perl.h

  Log Message:
  -----------
  perl.h - remove duplicated code from commented explanation


  Commit: ffc8bafcc615153f36317fc165532b06440e529b
      
https://github.com/Perl/perl5/commit/ffc8bafcc615153f36317fc165532b06440e529b
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M intrpvar.h

  Log Message:
  -----------
  intrpvar.h - change "char * *" into "char **"

Uniformity in such things is good.


  Commit: dd9378227abdabbb100d237d8844d2c98a247e36
      
https://github.com/Perl/perl5/commit/dd9378227abdabbb100d237d8844d2c98a247e36
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M intrpvar.h

  Log Message:
  -----------
  intrpvar.h - move size declaration to a define

so it can be reused and so the PERLVAR() lines up better.


  Commit: 5ffc149dfc374efc0f5f93f21647d508642e1cbb
      
https://github.com/Perl/perl5/commit/5ffc149dfc374efc0f5f93f21647d508642e1cbb
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M perlvars.h

  Log Message:
  -----------
  perlvars.h - move length computation to a define

So it can be reused if necessary, also because it makes
parsing PERLVARx() statements easier, this is the only
place where such a definition has a parameter that contains
a parenthesis. Moving it to a define makes it easier to
parse these statements externally in some ways.


  Commit: edbcb1d0d898501f6f8aee0196a09a0e6b429cd1
      
https://github.com/Perl/perl5/commit/edbcb1d0d898501f6f8aee0196a09a0e6b429cd1
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M regexp.h

  Log Message:
  -----------
  regexp.h - move semicolon to be before the comment.

This is the only struct in our manually maintained files where
there is a comment in front of the semicolon instead of after it.


  Commit: 82d9123c8a6b535908f3ec30a5613fa2fc283d68
      
https://github.com/Perl/perl5/commit/82d9123c8a6b535908f3ec30a5613fa2fc283d68
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M XSUB.h

  Log Message:
  -----------
  XSUB.h - put STMT_END on its own line and lined up with STMT_START


  Commit: 7b1802dd696afd9dd09e70de4c31c192448267b3
      
https://github.com/Perl/perl5/commit/7b1802dd696afd9dd09e70de4c31c192448267b3
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M perl.h

  Log Message:
  -----------
  perl.h - put STMT_END on its own line, and lined up with STMT_START


  Commit: 9df31d00e868007a9bf1a2c6cf73acb54c21067c
      
https://github.com/Perl/perl5/commit/9df31d00e868007a9bf1a2c6cf73acb54c21067c
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M regexp.h

  Log Message:
  -----------
  regexp.h - put STMT_END on its own line and lined up with STMT_START


  Commit: bea5427f29cf9762aff7da589912b4c49ebf80b5
      
https://github.com/Perl/perl5/commit/bea5427f29cf9762aff7da589912b4c49ebf80b5
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M regcomp.h

  Log Message:
  -----------
  regcomp.h - put STMT_START on its own line and lined up with STMT_END


  Commit: e99b37e9f57add150d4f91e0b4898e36c5d629b3
      
https://github.com/Perl/perl5/commit/e99b37e9f57add150d4f91e0b4898e36c5d629b3
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M pp.h

  Log Message:
  -----------
  pp.h - put STMT_END on its own line and lined up STMT_START


  Commit: 21660755b132f7e9cc59a3559cec1878e7795abc
      
https://github.com/Perl/perl5/commit/21660755b132f7e9cc59a3559cec1878e7795abc
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M XSUB.h

  Log Message:
  -----------
  XSUB.h - line up properly

and make sure they are shorter than 80 cols


  Commit: c3416492c9d3094e99de69c0dc7817916cfa6bc5
      
https://github.com/Perl/perl5/commit/c3416492c9d3094e99de69c0dc7817916cfa6bc5
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M handy.h

  Log Message:
  -----------
  handy.h - remove unused macros

None of these are used anymore. See c62fdeb784c7643c90d2ea8c2ec0f03a548da338
for more details.


  Commit: e85fed7cca64c3a9f5b20ee28fd897784a9390b4
      
https://github.com/Perl/perl5/commit/e85fed7cca64c3a9f5b20ee28fd897784a9390b4
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M EXTERN.h
    M INTERN.h
    M XSUB.h
    M av.h
    M cop.h
    M cv.h
    M dosish.h
    M fakesdio.h
    M gv.h
    M handy.h
    M hv.h
    M hv_func.h
    M hv_macro.h
    M inline.h
    M intrpvar.h
    M invlist_inline.h
    M iperlsys.h
    M mg.h
    M mydtrace.h
    M op.h
    M op_reg_common.h
    M pad.h
    M parser.h
    M perl.h
    M perl_inc_macro.h
    M perl_siphash.h
    M perlio.h
    M perliol.h
    M perlvars.h
    M pp.h
    M regcomp.h
    M regexp.h
    M sbox32_hash.h
    M scope.h
    M sv.h
    M sv_inline.h
    M thread.h
    M time64_config.h
    M unixish.h
    M utf8.h
    M utfebcdic.h
    M util.h
    M vutil.h
    M zaphod32_hash.h

  Log Message:
  -----------
  (1) simple ws fixups


  Commit: 3f5075879d771107e93229b7ebf9aadaf957964e
      
https://github.com/Perl/perl5/commit/3f5075879d771107e93229b7ebf9aadaf957964e
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M XSUB.h
    M cop.h
    M gv.h
    M handy.h
    M hv.h
    M hv_func.h
    M inline.h
    M iperlsys.h
    M op.h
    M op_reg_common.h
    M perl.h
    M perl_inc_macro.h
    M pp.h
    M regcomp.h
    M regexp.h
    M scope.h
    M sv.h
    M utfebcdic.h
    M util.h
    M vutil.h

  Log Message:
  -----------
  (2) break long define


  Commit: 65092c0ce080e63ddcbd2c1c5f1687c6478f41c7
      
https://github.com/Perl/perl5/commit/65092c0ce080e63ddcbd2c1c5f1687c6478f41c7
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M XSUB.h
    M av.h
    M cop.h
    M cv.h
    M gv.h
    M handy.h
    M hv.h
    M hv_func.h
    M hv_macro.h
    M inline.h
    M iperlsys.h
    M mg.h
    M op.h
    M pad.h
    M perl.h
    M perl_inc_macro.h
    M pp.h
    M regcomp.h
    M regexp.h
    M sbox32_hash.h
    M scope.h
    M sv.h
    M sv_inline.h
    M unixish.h
    M utf8.h
    M zaphod32_hash.h

  Log Message:
  -----------
  (3) break multiline define


  Commit: d7bbaab4d7ed1e642a389ae6ef53e8c0fb75f41d
      
https://github.com/Perl/perl5/commit/d7bbaab4d7ed1e642a389ae6ef53e8c0fb75f41d
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M EXTERN.h
    M INTERN.h
    M XSUB.h
    M av.h
    M cop.h
    M cv.h
    M dosish.h
    M fakesdio.h
    M gv.h
    M handy.h
    M hv.h
    M hv_func.h
    M hv_macro.h
    M inline.h
    M intrpvar.h
    M invlist_inline.h
    M iperlsys.h
    M mg.h
    M nostdio.h
    M op.h
    M pad.h
    M parser.h
    M perl.h
    M perl_inc_macro.h
    M perl_langinfo.h
    M perlio.h
    M perlvars.h
    M pp.h
    M regcomp.h
    M regexp.h
    M sbox32_hash.h
    M scope.h
    M sv.h
    M sv_inline.h
    M thread.h
    M time64.h
    M time64_config.h
    M unixish.h
    M utf8.h
    M util.h
    M vutil.h

  Log Message:
  -----------
  (4) line up simple defs


  Commit: 1b858ba5cf00337b5e115ade3fa631dc047779ec
      
https://github.com/Perl/perl5/commit/1b858ba5cf00337b5e115ade3fa631dc047779ec
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M av.h
    M cop.h
    M handy.h
    M hv_macro.h
    M op.h
    M perl.h
    M regcomp.h
    M regexp.h
    M sv.h
    M util.h

  Log Message:
  -----------
  (5) join short continuations


  Commit: 8ed6e3d4319b81269b49a85604900601f1b34535
      
https://github.com/Perl/perl5/commit/8ed6e3d4319b81269b49a85604900601f1b34535
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M av.h
    M cop.h
    M gv.h
    M hv.h
    M malloc_ctl.h
    M mg.h
    M op.h
    M pad.h
    M parser.h
    M perl.h
    M perliol.h
    M regcomp.h
    M regexp.h
    M sv.h
    M sv_inline.h
    M time64.h
    M util.h

  Log Message:
  -----------
  (6) reformat structs


  Commit: 2ca320a2b2780d65039263e2f803e2a0ad68d200
      
https://github.com/Perl/perl5/commit/2ca320a2b2780d65039263e2f803e2a0ad68d200
  Author: Yves Orton <[email protected]>
  Date:   2022-09-06 (Tue, 06 Sep 2022)

  Changed paths:
    M XSUB.h
    M cv.h
    M dosish.h
    M handy.h
    M hv.h
    M hv_func.h
    M hv_macro.h
    M intrpvar.h
    M iperlsys.h
    M op.h
    M parser.h
    M perl.h
    M perlio.h
    M perlvars.h
    M regcomp.h
    M regexp.h
    M sbox32_hash.h
    M sv.h
    M sv_inline.h
    M thread.h
    M util.h
    M zaphod32_hash.h

  Log Message:
  -----------
  (7) break remaining long line comments


Compare: https://github.com/Perl/perl5/compare/0adc6d424587...2ca320a2b278

Reply via email to