Branch: refs/heads/yves/robust_inc_unsquash
Home: https://github.com/Perl/perl5
Commit: 933133ff98f491ec090c5e3c1f4e412ba7c030aa
https://github.com/Perl/perl5/commit/933133ff98f491ec090c5e3c1f4e412ba7c030aa
Author: Yves Orton <[email protected]>
Date: 2022-12-08 (Thu, 08 Dec 2022)
Changed paths:
M t/porting/podcheck.t
Log Message:
-----------
podcheck.t - make error message less confusing
podcheck.t assumes all non =head text will be indented
at least 4 spaces, but this wasn't explicit in the output
from podcheck for verbatim line length checks.
Commit: 3832602bcf35354f7f3eacec5f80252ccac6ce8c
https://github.com/Perl/perl5/commit/3832602bcf35354f7f3eacec5f80252ccac6ce8c
Author: Yves Orton <[email protected]>
Date: 2022-12-08 (Thu, 08 Dec 2022)
Changed paths:
M t/op/inccode.t
M t/op/require_errors.t
Log Message:
-----------
t/ - INC hardening tests
These tests are pretty much all marked TODO. In the
following patches we will remove the TODO as we fix
the bug or implement the feature.
Commit: a9e7fb11c231293da6780db764c42c4a491207c1
https://github.com/Perl/perl5/commit/a9e7fb11c231293da6780db764c42c4a491207c1
Author: Yves Orton <[email protected]>
Date: 2022-12-08 (Thu, 08 Dec 2022)
Changed paths:
M pp_ctl.c
Log Message:
-----------
pp_ctl.c - rename vars to something more descriptive in require_file()
"i" and "ar" is a bit too minimal, and I will be refactoring
this code somewhat in following patches, so this preps it for
future changes.
Commit: 88f33c91b1602acaa383c44b41f4de78f481b57e
https://github.com/Perl/perl5/commit/88f33c91b1602acaa383c44b41f4de78f481b57e
Author: Yves Orton <[email protected]>
Date: 2022-12-08 (Thu, 08 Dec 2022)
Changed paths:
M pp_ctl.c
Log Message:
-----------
pp_ctl.c - make ENTER debug data a bit more clear
We will have more than one INC hook in the future.
Commit: 9d7961ffd458549cb5152749ed777c9305fcbb7f
https://github.com/Perl/perl5/commit/9d7961ffd458549cb5152749ed777c9305fcbb7f
Author: Yves Orton <[email protected]>
Date: 2022-12-08 (Thu, 08 Dec 2022)
Changed paths:
M pp_ctl.c
Log Message:
-----------
pp_ctl.c - refetch @INC from *INC after hook
The original value may have been freed by the time the hook
returns, so we have to refetch it immediately after execution.
We also move the declaration into a more minimal scope.
Commit: 4b23889803519cdee0e770aa67ca7bd030feedb0
https://github.com/Perl/perl5/commit/4b23889803519cdee0e770aa67ca7bd030feedb0
Author: Yves Orton <[email protected]>
Date: 2022-12-08 (Thu, 08 Dec 2022)
Changed paths:
M pp_ctl.c
M t/op/require_errors.t
Log Message:
-----------
pp_ctl.c - eval INC hooks, and rethrow errors with more useful message
When an INC hook blows up debugging what is going on can be
somewhat difficult. This adds some debugging data if the error
message does not seem to be customized.
Commit: 012640444841e6662e53db003dbac73a814a9e65
https://github.com/Perl/perl5/commit/012640444841e6662e53db003dbac73a814a9e65
Author: Yves Orton <[email protected]>
Date: 2022-12-08 (Thu, 08 Dec 2022)
Changed paths:
M pod/perldelta.pod
M pp_ctl.c
M t/op/inccode.t
M t/op/require_errors.t
Log Message:
-----------
pp_ctl.c - require_file: truthful errors and tests: ties are called once
We need to keep track of what we actually checked. We cannot simply
report the state of @INC at the end of the require, as it might have
changed, possibly several times during the require. This also accounts
for most "silly" stuff that might upset our internal assumptions, for
instance where a tie might report one value to the code doing the
directory check and another in the error message.
We had long standing tests to see that @INC tie elements where called
"once" but they actually tested they were called twice despite claiming
otherwise. This fixes all of those test so that a tied @INC entry is
called exactly once, and whatever it returned the first time is placed
in the error message.
This includes a change to the require error message, so that where it
once said "@INC contains:" it now says "@INC entries checked:". Note
this patch requires parent v0.239 to be available (which was done
in the previous commit).
Commit: 6c363f64503d9d85a6a18a3c3d6b529663eb578f
https://github.com/Perl/perl5/commit/6c363f64503d9d85a6a18a3c3d6b529663eb578f
Author: Yves Orton <[email protected]>
Date: 2022-12-08 (Thu, 08 Dec 2022)
Changed paths:
M pp_ctl.c
M t/op/require_errors.t
Log Message:
-----------
pp_ctl.c - support $INC in require_file @INC hook
$INC is localized to be the C level index of the loop over the @INC
array. At the end of the hook its value is assigned back to the C level
loop iterator (inc_idx). This allows a hook to control where in the @INC
array the loop should continue, for instance -1 represents "reprocess
from the beginning" (and as a convenience so does undef). This can be
useful if the @INC array is modified by a hook. Normally we would just
"continue along", but this may or may not be the right thing to do, so we
let the user decide.
Commit: c2291cb4f72be94ad8913dc8bd81ac717ea9faaf
https://github.com/Perl/perl5/commit/c2291cb4f72be94ad8913dc8bd81ac717ea9faaf
Author: Yves Orton <[email protected]>
Date: 2022-12-08 (Thu, 08 Dec 2022)
Changed paths:
M pod/perldelta.pod
M pod/perldiag.pod
M pp_ctl.c
M t/op/require_errors.t
Log Message:
-----------
pp_ctl.c - handle objects in @INC a bit more gracefully
If an object doesn't have an INC hook then don't call it. Either simply
stringify the ref (think overloads), OR, if it is a blessed coderef,
then just execute it like it was an unblessed coderef.
Also handle when an object is passed as the first argument of the
array form of call. Previously this would throw an exception as the
first argument on the stack when we call_method() would not be
blessed. When this is the scenario we pass in the array as the third
argument to the method.
Commit: 2be0ae391d0b5096fa239c060bfdfa9fda291f5f
https://github.com/Perl/perl5/commit/2be0ae391d0b5096fa239c060bfdfa9fda291f5f
Author: Yves Orton <[email protected]>
Date: 2022-12-08 (Thu, 08 Dec 2022)
Changed paths:
M pp_ctl.c
M t/op/inccode.t
M t/op/require_errors.t
Log Message:
-----------
pp_ctl.c - add support for an INCDIR hook
This hook returns a list of directories for Perl to search.
If it returns an empty list it acts like a no-op (except for the
error message). The return from INCDIR is always stringified,
they are not treated the same as normal @INC entries so no hooks
returning hooks.
Commit: 66e559e9575b1f2bb44d12d3ad90a1e152c7357d
https://github.com/Perl/perl5/commit/66e559e9575b1f2bb44d12d3ad90a1e152c7357d
Author: Yves Orton <[email protected]>
Date: 2022-12-08 (Thu, 08 Dec 2022)
Changed paths:
M pp_ctl.c
Log Message:
-----------
pp_ctl.c - move logic closer to where it is used
No sense doing something that has not effect.
Commit: 22aa98f4b9b9c7859013b89d535c9e328405397b
https://github.com/Perl/perl5/commit/22aa98f4b9b9c7859013b89d535c9e328405397b
Author: Yves Orton <[email protected]>
Date: 2022-12-08 (Thu, 08 Dec 2022)
Changed paths:
M pod/perldelta.pod
M pod/perlfunc.pod
M pod/perlvar.pod
Log Message:
-----------
pod/ - document $INC and INCDIR
Compare: https://github.com/Perl/perl5/compare/a2c3eaa9d2e7...22aa98f4b9b9