Branch: refs/heads/smoke-me/khw-dimitry
  Home:   https://github.com/Perl/perl5
  Commit: c314b02350cdebdf807cd83f0457a0f8f511932d
      
https://github.com/Perl/perl5/commit/c314b02350cdebdf807cd83f0457a0f8f511932d
  Author: Karl Williamson <[email protected]>
  Date:   2022-12-17 (Sat, 17 Dec 2022)

  Changed paths:
    M locale.c

  Log Message:
  -----------
  locale.c: Clarifications

This commit adds/improves some comments, changes a variable name, and
adds some parentheses, and moves a declaration (since we now use C99).


  Commit: 79a4b3fba26cedf7fa04b2274575a34237f3f4bd
      
https://github.com/Perl/perl5/commit/79a4b3fba26cedf7fa04b2274575a34237f3f4bd
  Author: Karl Williamson <[email protected]>
  Date:   2022-12-17 (Sat, 17 Dec 2022)

  Changed paths:
    M ext/XS-APItest/t/locale.t

  Log Message:
  -----------
  API-test:locale.t: Look for a comma radix locale

Prior to this commit there was code (whose results were ignored) looking
for a locale with a non-dot radix.  This can result in a UTF-8 radix,
which may not display properly without the terminal and file handle
being in sync.  Almost all non-dot locales use a comma, which is
represented the same in UTF-8 as not, so doesn't suffer from the display
problem.  So look specifically for a comma.

The result is still unused, but the next commit will use it.


  Commit: de6d188645ec13a7dbd1d819dc53a6aa5a57ce56
      
https://github.com/Perl/perl5/commit/de6d188645ec13a7dbd1d819dc53a6aa5a57ce56
  Author: Karl Williamson <[email protected]>
  Date:   2022-12-17 (Sat, 17 Dec 2022)

  Changed paths:
    M ext/XS-APItest/APItest.xs
    M ext/XS-APItest/t/locale.t

  Log Message:
  -----------
  Add testing global locale switching; Todo #20565

API switch_to_global_locale() and sync_locale() weren't tested because I
hadn't figured out a way to do so, but @dk showed me the way in his
reproducing case for GH #20565.


  Commit: a16e29ec4aa88bcd71c8339eb3e981ad1f53f2f9
      
https://github.com/Perl/perl5/commit/a16e29ec4aa88bcd71c8339eb3e981ad1f53f2f9
  Author: Karl Williamson <[email protected]>
  Date:   2022-12-17 (Sat, 17 Dec 2022)

  Changed paths:
    M embed.fnc
    M embed.h
    M ext/XS-APItest/t/locale.t
    M locale.c
    M proto.h

  Log Message:
  -----------
  Fix broken API: sync_locale()

This fixes GH #20565.

Lack of tests allowed sync_locale() to get broken until CPAN testing
showed it so.

Basically, I blew it in 9f5a615be674d7663d3b4719849baa1ba3027f5b.  Most
egregiously, I forgot to turn back on when a sync_locale() is executed,
the toggling for locales whose radix character isn't a dot.  And this
needs a way to tell the other code that it needs to recompute things at
this time, since our records don't reflect what happened before the
sync.


Compare: https://github.com/Perl/perl5/compare/c314b02350cd%5E...a16e29ec4aa8

Reply via email to