Branch: refs/heads/blead
  Home:   https://github.com/Perl/perl5
  Commit: ad2d7a7b8430731f134374105121d039762c6f6c
      
https://github.com/Perl/perl5/commit/ad2d7a7b8430731f134374105121d039762c6f6c
  Author: Yves Orton <[email protected]>
  Date:   2023-03-06 (Mon, 06 Mar 2023)

  Changed paths:
    M scope.c

  Log Message:
  -----------
  scope.c - fix typo


  Commit: 624f6f53b1081642aea65e1f3f172bcaad6c12c7
      
https://github.com/Perl/perl5/commit/624f6f53b1081642aea65e1f3f172bcaad6c12c7
  Author: Yves Orton <[email protected]>
  Date:   2023-03-06 (Mon, 06 Mar 2023)

  Changed paths:
    M cop.h
    M embed.fnc
    M embed.h
    M pod/perlguts.pod
    M proto.h
    M regen/scope_types.pl
    M scope.c
    M scope.h
    M scope_types.h
    M sv.c

  Log Message:
  -----------
  scope.c - improved RCPV support, SAVERCPV SAVEFREERCPV

I misnamed some of the RCPV stuff when it was introduced. The macro
which I called SAVERCPVFREE should have been called SAVERCPV,
and there should also have been a SAVEFREERCPV macro.

Note the naming system for these functions is a bit confusing.
SAVEFREERCPV /just/ frees. SAVERCPV saves and restores (eg, its like
local). SAVEFREESV is an exception. :-( and it behaves like SAVERCPV.
See for instance SAVEPV or similar macros.

There also should have been RCPV_REFCNT_dec() and RCPV_REFCNT_inc()
macros.

There was also missing documentation. This patch should fix all of these
issues. Since this functionality has never been released in a production
perl it should be fine to do these renames, nothing out there should use
these macros yet.

I noticed these oversights while fixing Scope::Upper, see also:
https://github.com/Perl/perl5/issues/20861
https://rt.cpan.org/Ticket/Display.html?id=146897


Compare: https://github.com/Perl/perl5/compare/bf8d775317f3...624f6f53b108

Reply via email to