Branch: refs/heads/yves/fix_define_tab
  Home:   https://github.com/Perl/perl5
  Commit: e09dd7c2c938401352767ae61cde5b420a991a57
      
https://github.com/Perl/perl5/commit/e09dd7c2c938401352767ae61cde5b420a991a57
  Author: Yves Orton <demer...@gmail.com>
  Date:   2023-04-28 (Fri, 28 Apr 2023)

  Changed paths:
    M Configure
    M Porting/config_H
    M Porting/config_h.pl
    M config_h.SH
    M uconfig.h

  Log Message:
  -----------
  Replace "define\t" with "define " in Configure/metaconfig related files

This is broken out so it is easier for Tux to find and merge with
metaconfig.

View this patch with -w and you will see "no changes" except for
config_h.SH and Porting/config_h.pl both which needed to be changed to
ensure that they produce output that doesn't replicate the problem.


  Commit: d2b273866610925a75477de543a1e662b4548051
      
https://github.com/Perl/perl5/commit/d2b273866610925a75477de543a1e662b4548051
  Author: Yves Orton <demer...@gmail.com>
  Date:   2023-04-28 (Fri, 28 Apr 2023)

  Changed paths:
    M dist/IO/ChangeLog
    M dist/IO/IO.pm
    M dist/IO/lib/IO/Dir.pm
    M dist/IO/lib/IO/File.pm
    M dist/IO/lib/IO/Handle.pm
    M dist/IO/lib/IO/Pipe.pm
    M dist/IO/lib/IO/Poll.pm
    M dist/IO/lib/IO/Seekable.pm
    M dist/IO/lib/IO/Select.pm
    M dist/IO/lib/IO/Socket.pm
    M dist/IO/lib/IO/Socket/INET.pm
    M dist/IO/lib/IO/Socket/UNIX.pm
    M dist/IO/poll.h

  Log Message:
  -----------
  dist/IO: replace "define\t" with "define "

This cleans up the defines in dist/IO/poll.h.

"#define\t" is annoying as it is it 8 spaces wide, so it looks like
"#define ", yet will not be found in a grep for "define foo" as the
space is actually a tab.


  Commit: bb43cb9de1f5f4b08c6b6bc3706d007e7d302b53
      
https://github.com/Perl/perl5/commit/bb43cb9de1f5f4b08c6b6bc3706d007e7d302b53
  Author: Yves Orton <demer...@gmail.com>
  Date:   2023-04-28 (Fri, 28 Apr 2023)

  Changed paths:
    M ext/File-Glob/Glob.pm
    M ext/File-Glob/bsd_glob.c
    M ext/File-Glob/bsd_glob.h

  Log Message:
  -----------
  ext/File-Glob/ - replace "define\t" with "define "

"#define\t" is annoying as it is it 8 spaces wide, so it looks like
"#define ", yet will not be found in a grep for "define foo" as the
space is actually a tab.


  Commit: 70d6702b15fe032106d2ae873f05bd485b78815a
      
https://github.com/Perl/perl5/commit/70d6702b15fe032106d2ae873f05bd485b78815a
  Author: Yves Orton <demer...@gmail.com>
  Date:   2023-04-28 (Fri, 28 Apr 2023)

  Changed paths:
    M ext/SDBM_File/SDBM_File.pm
    M ext/SDBM_File/dbu.c

  Log Message:
  -----------
  ext/SDBM_File/ - replace "define\t" with "define "

"#define\t" is annoying as it is it 8 spaces wide, so it looks like
"#define ", yet will not be found in a grep for "define foo" as the
space is actually a tab.


  Commit: 05cc6cbf56b2be9b5844b2b3296c1f18281ca260
      
https://github.com/Perl/perl5/commit/05cc6cbf56b2be9b5844b2b3296c1f18281ca260
  Author: Yves Orton <demer...@gmail.com>
  Date:   2023-04-28 (Fri, 28 Apr 2023)

  Changed paths:
    M cop.h
    M malloc.c
    M op.h
    M os2/os2ish.h
    M patchlevel.h
    M plan9/config.plan9
    M plan9/config_h.sample
    M plan9/plan9ish.h
    M regcomp.h
    M regexec.c
    M t/uni/stash.t
    M unixish.h
    M util.c
    M vms/vmsish.h
    M win32/config_H.gc
    M win32/config_H.vc
    M win32/include/sys/socket.h
    M win32/win32.h
    M win32/win32iop.h

  Log Message:
  -----------
  replace "define\t" with "define " in most "normal" core files.

The main exceptions being dist/, ext/, and Configure related
files, which will be updated in a subsequent commit. Files in the cpan/
directory are also omitted as they are not owned by the core.

'#define' has seven characters, so following it with a \t makes it look
like '#define ' when it is not, which then frustrates attempts to find
where a given define is. If you *know* then you do a

    git grep -P 'define\s+WHATEVER'

but if don't or you forget, you can get very confused trying to find
where a given define is located. This fixes all such cases so they
actually are 'define WHATEVER' instead.

If this patch is getting in your way with blame analysis then view it
with the -w option to blame.


Compare: https://github.com/Perl/perl5/compare/8dbdfe2ca38c...05cc6cbf56b2

Reply via email to