Branch: refs/heads/blead
  Home:   https://github.com/Perl/perl5
  Commit: 9cca022465b6bee5f766cf317c150e791f105dbe
      
https://github.com/Perl/perl5/commit/9cca022465b6bee5f766cf317c150e791f105dbe
  Author: Lukas Mai <lukasmai....@gmail.com>
  Date:   2024-08-01 (Thu, 01 Aug 2024)

  Changed paths:
    M t/porting/cpphdrcheck.t

  Log Message:
  -----------
  t/porting/cpphdrcheck.t: fix cc version fallback

The `unless ($ver)` check doesn't work as intended because
`` `$cc -V 2>&1` `` captures stderr (intentionally, for Sun C). This
means with gcc or clang `$ver` ends up containing a true-ish string,
either

    gcc: error: unrecognized command-line option ā€˜-V’
    gcc: fatal error: no input files
    compilation terminated.

or

    clang: error: argument to '-V' is missing (expected 1 value)
    clang: error: no input files

so the `$cc --version` fallback never runs.

Checking for a non-zero exit status and the word "error" in the output
seems to work reliably, though.



To unsubscribe from these emails, change your notification settings at 
https://github.com/Perl/perl5/settings/notifications

Reply via email to