Branch: refs/heads/davem/xs_refactor
Home: https://github.com/Perl/perl5
Commit: e1a86cb80fc94b94c272961efed387ab811c5878
https://github.com/Perl/perl5/commit/e1a86cb80fc94b94c272961efed387ab811c5878
Author: David Mitchell <da...@iabyn.com>
Date: 2024-08-02 (Fri, 02 Aug 2024)
Changed paths:
M dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
Log Message:
-----------
ParseXS::process_file(): balance braces
Within the long subroutine process_file(), make '{' and '}' be balanced,
so that it's easier to bounce around between matching braces using
'%' on vim, or the equivalent on other text editors.
This is achieved by fixing a couple comment typos, plus using the
'[[' and ']]' escapes in a few Q(<<EOF) calls which output unbalanced
braces but were using a bare '{' or '}'.
Most of code-output heredocs in this sub already used the escapes, just
these few weren't.
Commit: e10343c294260245bed5fdc7b8da4ae2513547af
https://github.com/Perl/perl5/commit/e10343c294260245bed5fdc7b8da4ae2513547af
Author: David Mitchell <da...@iabyn.com>
Date: 2024-08-02 (Fri, 02 Aug 2024)
Changed paths:
M dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
Log Message:
-----------
ParseXS::process_file(): rename some lex vars
process_file() is a long sub of about 1600 lines. This commit is one
of a series to rename etc some of its lexical vars for greater clarity
and consistency.
Rename %args to %Options. This hash records the various switches passed
to the sub, but its name can get confused with many other vars with
'arg' in their name used later for parsing an XSUB's signature.
At the same time, rename the minor %options var to %opts.
Commit: 8b0e382af7e9bdd033b40cf78386c52ee6717e63
https://github.com/Perl/perl5/commit/8b0e382af7e9bdd033b40cf78386c52ee6717e63
Author: David Mitchell <da...@iabyn.com>
Date: 2024-08-02 (Fri, 02 Aug 2024)
Changed paths:
M dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
Log Message:
-----------
ParseXS::process_file(): adj scope of some my vars
process_file() is a long sub of about 1600 lines. This commit is one
of a series to rename etc some of its lexical vars for greater clarity
and consistency.
This commit reduces the scope of a few lexical vars from being in the
whole scope of the big sub (or the big loop within it) to just where
they are used.
Commit: 4c518ad87f5b224f0e197d631daa91eeffb23550
https://github.com/Perl/perl5/commit/4c518ad87f5b224f0e197d631daa91eeffb23550
Author: David Mitchell <da...@iabyn.com>
Date: 2024-08-02 (Fri, 02 Aug 2024)
Changed paths:
M dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
Log Message:
-----------
ParseXS::process_file(): adjust some indents
After the previous commit which added some new { } scopes,
re-indent the code within the new scopes.
Whitespace-only change (plus wrapping one over-long comment).
Commit: 93bad1eed9819ff1802068e1ae6410b415418d7a
https://github.com/Perl/perl5/commit/93bad1eed9819ff1802068e1ae6410b415418d7a
Author: David Mitchell <da...@iabyn.com>
Date: 2024-08-02 (Fri, 02 Aug 2024)
Changed paths:
M dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
Log Message:
-----------
ParseXS::process_file(): rename more my vars
process_file() is a long sub of about 1600 lines. This commit is one
of a series to rename etc some of its lexical vars for greater clarity
and consistency.
Rename various boolean lexical vars to $seen_FOO, where FOO is something
in the XSUB that has been detected.
was now
$RETVAL_no_return $seen_NO_RETURN
$externC $seen_extern_C
$static $seen_static
$ellipsis $seen_ellipsis
$PPCODE $seen_PPCODE
$CODE $seen_CODE
$INTERFACE $seen_INTERFACE
Commit: 1de0e00fb68739dd7c51d1caf1366b6a90d4ef49
https://github.com/Perl/perl5/commit/1de0e00fb68739dd7c51d1caf1366b6a90d4ef49
Author: David Mitchell <da...@iabyn.com>
Date: 2024-08-02 (Fri, 02 Aug 2024)
Changed paths:
M dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
Log Message:
-----------
ParseXS::process_file(): rename yet more my vars
process_file() is a long sub of about 1600 lines. This commit is one
of a series to rename etc some of its lexical vars for greater clarity
and consistency.
These are miscellaneous renames for clarity:
was now
$XSS_work_idx $XSS_top_if_idx
$cpp_next_tmp $cpp_next_tmp_define
$xsreturn $XSRETURN_count
$len_name $name_or_lenname
$islength $is_length
$num_args $args_count
$min_args $min_arg_count
$extra_args $optional_args_count
@args_num @map_param_idx_to_arg_idx
$wantRETVAL $implicit_OUTPUT_RETVAL
$trgt $target
Commit: c5b551ee80013078b035941eaac167db5dfb5a22
https://github.com/Perl/perl5/commit/c5b551ee80013078b035941eaac167db5dfb5a22
Author: David Mitchell <da...@iabyn.com>
Date: 2024-08-02 (Fri, 02 Aug 2024)
Changed paths:
M dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
Log Message:
-----------
ParseXS::process_file(): fix couple of my vars
process_file() is a long sub of about 1600 lines. This commit is one
of a series to rename etc some of its lexical vars for greater clarity
and consistency.
This commit:
Deletes the unused $inout_var variable.
Reduces the scope of the $EXPLICIT_RETURN variable.
Commit: e4bbeb5c5533e4a4d482bb139c4bf068ac71be92
https://github.com/Perl/perl5/commit/e4bbeb5c5533e4a4d482bb139c4bf068ac71be92
Author: David Mitchell <da...@iabyn.com>
Date: 2024-08-02 (Fri, 02 Aug 2024)
Changed paths:
M dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
Log Message:
-----------
ParseXS::process_file(): rename 2 ref my vars
process_file() is a long sub of about 1600 lines. This commit is one
of a series to rename etc some of its lexical vars for greater clarity
and consistency.
This commit converts a couple of vars called $foo_ref which are
references to an array or hash, into a direct array or hash.
These vars are used just locally to the sub and aren't passed anywhere
else, so it seems little point in making them references.
was now
$only_C_inlist_ref @only_C_inlist
$outlist_ref @OUTLIST_vars
The declaration of @OUTLIST_vars is also moved down to be nearer to
where the variable is first used.
Commit: 273a03a91478b20d4a17c9c4ba447b9faeeb7e7b
https://github.com/Perl/perl5/commit/273a03a91478b20d4a17c9c4ba447b9faeeb7e7b
Author: David Mitchell <da...@iabyn.com>
Date: 2024-08-02 (Fri, 02 Aug 2024)
Changed paths:
M dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
Log Message:
-----------
ParseXS::process_file(): eliminate 2 postfix fors
There are a couple of multi-line statements with a 'for foo' suffix.
Turn them into a proper 'for { block }' instead, as it's easy to miss
the trailing 'for' when visually inspecting such code.
Commit: 98f431f72fa84e9e221e4fea5037e51b437287ac
https://github.com/Perl/perl5/commit/98f431f72fa84e9e221e4fea5037e51b437287ac
Author: David Mitchell <da...@iabyn.com>
Date: 2024-08-02 (Fri, 02 Aug 2024)
Changed paths:
M dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
Log Message:
-----------
ParseXS::process_file(): merge 2 prints
Two code-emitting print statements follow one from another. Merge into
a single staement. This is a trivial simplification with no change to
output.
Compare: https://github.com/Perl/perl5/compare/e1a86cb80fc9%5E...98f431f72fa8
To unsubscribe from these emails, change your notification settings at
https://github.com/Perl/perl5/settings/notifications
