Branch: refs/heads/davem/xs_refactor5
  Home:   https://github.com/Perl/perl5
  Commit: d52927ad6d754998f71cf36f8d07fa051233eed7
      
https://github.com/Perl/perl5/commit/d52927ad6d754998f71cf36f8d07fa051233eed7
  Author: David Mitchell <da...@iabyn.com>
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
    M dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
    M dist/ExtUtils-ParseXS/t/001-basic.t

  Log Message:
  -----------
  ParseXS: 5.8.9 backcompat fixes

A couple of fixes to make it build+test under 5.8.9.

The grep expression

    exists $_->{in_out} && $_->{in_out} =~ /OUT$/

was wrong - it should have been defined rather than exists, as is done
elsewhere. I'm not sure why an 'uninit var' warning only appeared on 5.8.9
but not blead - perhaps some minor autovivification difference?

It was also warning

    $ExtUtils::ParseXS::DIE_ON_ERROR only used once
    $ExtUtils::ParseXS::AUTHOR_WARNINGS only used once

in t/001-basic.t because that test file only loads ExtUtils::ParseXS at
runtime. Again, I'm not sure why it didn't warn on blead too. But I made
the var initialisations more robust against 'once' warnings anyway by
using 'our'.



To unsubscribe from these emails, change your notification settings at 
https://github.com/Perl/perl5/settings/notifications

Reply via email to