Branch: refs/heads/davem/xs_refactor6
Home: https://github.com/Perl/perl5
Commit: 24c25e1508bd5cfeecea050de3a6475bb779e01c
https://github.com/Perl/perl5/commit/24c25e1508bd5cfeecea050de3a6475bb779e01c
Author: David Mitchell <da...@iabyn.com>
Date: 2024-11-13 (Wed, 13 Nov 2024)
Changed paths:
M dist/ExtUtils-ParseXS/t/001-basic.t
Log Message:
-----------
ParseXS: t/001-basic.t: fixup regex
A couple of newly-added regexes had (in part) /....\b*/, which gives the
warning:
\b* matches null string many times in regex
so this commit removes the extraneous '*'
Commit: 42817dbae480cdb8644f7267b655d89d98029908
https://github.com/Perl/perl5/commit/42817dbae480cdb8644f7267b655d89d98029908
Author: David Mitchell <da...@iabyn.com>
Date: 2024-11-13 (Wed, 13 Nov 2024)
Changed paths:
M dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
Log Message:
-----------
ParseXS: fix under older perls
One line had: 'exists $param->{type}' as part of a condition. This
worked fine when $param was a normal hash ref (created under 'use
fields'), but the combination of:
- a recent commit which copies those hashes to $sig->{old_params}
then resets some of the fields (to allow for multiple CASEs);
- older perls (in particular 5.8.9) which used pseudo-hashes to
implement fields,
was causing the field to spring into existence, even though it wasn't defined.
So change the test from 'exists' to 'defined'.
Commit: 527a03f59d2cd55bc896ac04a590ededbf0f62e5
https://github.com/Perl/perl5/commit/527a03f59d2cd55bc896ac04a590ededbf0f62e5
Author: David Mitchell <da...@iabyn.com>
Date: 2024-11-13 (Wed, 13 Nov 2024)
Changed paths:
M dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm
M dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Node.pm
Log Message:
-----------
ParseXS: refactor: use new() copying to simplify code
A recent commit needed, at one point, to make a copy of a Node::Param
object, and did so in a clunky way. But this can be simplified by
instead using the new() method's built-in ability to take an
initialisation hash ref as an arg. So this commit does that.
However, it turns out that this new() method *shared* rather than copied
that hash ref when running in an environment where 'use fields' isn't
available - namely during the building of perl itself. So fix that too.
Compare: https://github.com/Perl/perl5/compare/1855b26b8091...527a03f59d2c
To unsubscribe from these emails, change your notification settings at
https://github.com/Perl/perl5/settings/notifications
