Branch: refs/heads/blead
Home: https://github.com/Perl/perl5
Commit: b20c83a3cb15b6c2b7d8192c054f4907846871d5
https://github.com/Perl/perl5/commit/b20c83a3cb15b6c2b7d8192c054f4907846871d5
Author: Richard Leach <richardle...@users.noreply.github.com>
Date: 2025-05-17 (Sat, 17 May 2025)
Changed paths:
M op.c
Log Message:
-----------
Perl_op_convert_list - only short circuit CONST OPs with an IsCOW SV
Currently, a CONST OP's SV will not have the `IsCOW` flag set if
the PV buffer was truncated such that it is too small to be COWed.
In which case, not short circuting `Perl_op_convert_list` causes
the OP to undergo constant folding, resulting in a CONST OP with
an SV that can participate in COW.
This means that the commit which introduced the short-circuit for
CONST OPs accidentally introduced a regression:
https://github.com/Perl/perl5/commit/a902d92a78262a0fd111789742f9c9e2a7fa2f42
This commit adds an additional check to ensure that short circuiting
does not happen when the CONST OP SV cannot be COWed. This is a
short term workaround given the proximity to the next stable release.
https://github.com/Perl/perl5/pull/23290 seems like the more
appropriate fix, but is a bigger change, so will be held until the
next development cycle.
To unsubscribe from these emails, change your notification settings at
https://github.com/Perl/perl5/settings/notifications
