Branch: refs/heads/blead
Home: https://github.com/Perl/perl5
Commit: 13dc55fb0c2bf4d2a962b5d81335e144d77b2695
https://github.com/Perl/perl5/commit/13dc55fb0c2bf4d2a962b5d81335e144d77b2695
Author: TAKAI Kousuke <[email protected]>
Date: 2025-11-19 (Wed, 19 Nov 2025)
Changed paths:
M numeric.c
M t/op/oct.t
Log Message:
-----------
grok_bin_oct_hex: Remove unnecessary initializer for `factor`
The initial value of `factor` before this change, `shift << bytes_so_far`,
is effectively not used, as it will be only used in multiplication with
zero (initial value of `value_nv`) on first overflow.
Moreover, this original initializer expression might cause undefined
behaviour as `bytes_so_far` (= s - s0) might become too large for shift
amount if the string had many leading zeros.
t/op/oct.t: Added tests to ensure this change won't change the behaviour.
To unsubscribe from these emails, change your notification settings at
https://github.com/Perl/perl5/settings/notifications
