Branch: refs/heads/blead
  Home:   https://github.com/Perl/perl5
  Commit: 3d37684e811c53b406b349496791782aec048863
      
https://github.com/Perl/perl5/commit/3d37684e811c53b406b349496791782aec048863
  Author: Tony Cook <[email protected]>
  Date:   2026-09-16 (Wed, 16 Sep 2026)

  Changed paths:
    M t/op/threads.t

  Log Message:
  -----------
  t/op/threads.t: fix a TSAN "leaked thread" warning

WARNING: ThreadSanitizer: thread leak (pid=59894)
  Thread T1 (tid=6697764, finished) created by main thread at:
    #0 pthread_create <null> (libclang_rt.tsan_osx_dynamic.dylib:arm64e+0x33834)
    #1 XS_threads_create threads.xs:1292 (threads.bundle:arm64+0x2078)
    #2 Perl_pp_goto pp_ctl.c:3691 (perl:arm64+0x1001764a4)
    #3 Perl_runops_debug dump.c:3486 (perl:arm64+0x10009cf70)
    #4 S_run_body perl.c (perl:arm64+0x10004ec6c)
    #5 perl_run perl.c:2819 (perl:arm64+0x10004e964)
    #6 main perlmain.c:127 (perl:arm64+0x100000910)

SUMMARY: ThreadSanitizer: thread leak threads.xs:1292 in XS_threads_create


  Commit: f90a8c9171d15ce7c30f6d105123ebbd96fa5da4
      
https://github.com/Perl/perl5/commit/f90a8c9171d15ce7c30f6d105123ebbd96fa5da4
  Author: Tony Cook <[email protected]>
  Date:   2026-09-16 (Wed, 16 Sep 2026)

  Changed paths:
    M perlvars.h

  Log Message:
  -----------
  PL_veto_cleanup: make it atomic

This is accessed unprotected by a mutex during cleanup, and the comment
indicates we want it to be atomic, so be it.


  Commit: 4ef09803b458ec376e7a4a1905cc438bbcde4222
      
https://github.com/Perl/perl5/commit/4ef09803b458ec376e7a4a1905cc438bbcde4222
  Author: Tony Cook <[email protected]>
  Date:   2026-09-16 (Wed, 16 Sep 2026)

  Changed paths:
    M dist/threads/threads.xs

  Log Message:
  -----------
  dist/threads: fix race on thread->next

dist/threads/t/free.t was complaining:

WARNING: ThreadSanitizer: data race (pid=42840)
  Read of size 8 at 0x00010d30dec0 by thread T5:
    #0 S_ithread_dec_free threads.xs:333 (threads.bundle:arm64+0x95ac)
    #1 ithread_mg_free threads.xs:474 (threads.bundle:arm64+0xa620)
    #2 Perl_mg_free_struct mg.c:1089 (perl:arm64+0x1000da594)
    #3 S_sv_unmagicext_flags sv.c:7034 (perl:arm64+0x1002aeae0)
    #4 Perl_sv_unmagic sv.c:7061 (perl:arm64+0x1002aa540)
    #5 XS_threads_DESTROY threads.xs:1664 (threads.bundle:arm64+0x4e20)
    #6 Perl_pp_entersub pp_hot.c:6706 (perl:arm64+0x1001a7bcc)
    #7 Perl_runops_debug dump.c:3486 (perl:arm64+0x10009d438)
    #8 Perl_call_sv perl.c:3274 (perl:arm64+0x1000509a0)
    #9 S_curse sv.c:8233 (perl:arm64+0x1002b33fc)
    #10 Perl_sv_clear sv.c:7767 (perl:arm64+0x1002b15e8)
    #11 Perl_sv_free2 sv.c:8337 (perl:arm64+0x1002b3bf8)
    #12 Perl_leave_adjust_stacks pp_hot.c:6290 (perl:arm64+0x1001a4d84)
    #13 Perl_pp_leavesub pp_hot.c:6321 (perl:arm64+0x1001a5528)
    #14 Perl_runops_debug dump.c:3486 (perl:arm64+0x10009d438)
    #15 Perl_call_sv perl.c:3274 (perl:arm64+0x1000509a0)
    #16 S_jmpenv_run threads.xs:578 (threads.bundle:arm64+0x9a5c)
    #17 S_ithread_run threads.xs:688 (threads.bundle:arm64+0x8b10)

  Previous write of size 8 at 0x00010d30dec0 by thread T4 (mutexes: write M0):
    #0 XS_threads_create threads.xs:1292 (threads.bundle:arm64+0x209c)
    #1 Perl_pp_entersub pp_hot.c:6706 (perl:arm64+0x1001a7bcc)
    #2 Perl_runops_debug dump.c:3486 (perl:arm64+0x10009d438)
    #3 Perl_call_sv perl.c:3274 (perl:arm64+0x1000509a0)
    #4 S_jmpenv_run threads.xs:578 (threads.bundle:arm64+0x9a5c)
    #5 S_ithread_run threads.xs:688 (threads.bundle:arm64+0x8b10)

  Location is heap block of size 176 at 0x00010d30dec0 allocated by thread T5:
    #0 malloc <null> (libclang_rt.tsan_osx_dynamic.dylib:arm64e+0x679b4)
    #1 XS_threads_create threads.xs:1292 (threads.bundle:arm64+0x1a6c)
    #2 Perl_pp_entersub pp_hot.c:6706 (perl:arm64+0x1001a7bcc)
    #3 Perl_runops_debug dump.c:3486 (perl:arm64+0x10009d438)
    #4 Perl_call_sv perl.c:3274 (perl:arm64+0x1000509a0)
    #5 S_jmpenv_run threads.xs:578 (threads.bundle:arm64+0x9a5c)
    #6 S_ithread_run threads.xs:688 (threads.bundle:arm64+0x8b10)

All other accesses to thread->next are protected by the
create_destruct_mutex, so this one should be too.


  Commit: e5b7d9b1da46ee66b3e684929e1d850ff0ebaca0
      
https://github.com/Perl/perl5/commit/e5b7d9b1da46ee66b3e684929e1d850ff0ebaca0
  Author: Tony Cook <[email protected]>
  Date:   2026-09-16 (Wed, 16 Sep 2026)

  Changed paths:
    M dist/threads/lib/threads.pm

  Log Message:
  -----------
  bump $threads::VERSION


Compare: https://github.com/Perl/perl5/compare/033e40522c9a...e5b7d9b1da46

To unsubscribe from these emails, change your notification settings at 
https://github.com/Perl/perl5/settings/notifications

Reply via email to