-----BEGIN PGP SIGNED MESSAGE-----
Moin,
this mail has a patch to Text::Balanced as attachement. The last time I
sent this to p5p this was not applied because Text::Balanced is on CPAN,
so now I seperated the patch for Text::Balanced, and while I was at it,
added one more thing: the removal of SelfLoader.
So this patch:
* fixes the mistake in delayed loading of Carp, the code did use "use
Carp" while a "require Carp" is needed to not unec. load Calc.
(On blead, Calc.pm is now quite small, but older Perls have a bigger Calc,
and in any event, the code looks like it wanted to do "require" :)
* removes SelfLoader - it is not used by Text::Balanced at all
Text::Balanced is in the core and Porting/Maintainers.pl lists
David Manura as Maintainer. David also has Text::Balanced as
module/namespace registered on search.cpan.org.
Damina, I Cced you since the last CPAN release is v1.95, and is listed
under your directory on search.cpan.org. (The core version is 1.95_01 and
lists Damian as the AUTHOR and doesn't say who maintains it)
This patch is against blead, but it should be able to be applied against
the package as from CPAN (I do not know how the blead Perl and the CPAN
version differ, though).
Once we have sorted out who should apply this patch to which version (or
snyc which one with which, first), then a new CPAN release is probably in
order. :)
If these is anything I can do to further resolve this issue, just drop me
a note or two :)
Best wishes,
Tels
PS: The needless usage of SelfLoader was discovered via a new toy project
of mine that tries to graph the usage patterns from Perl modules. This
project has thus already paid for the work :-D I'll hope to wrap a
release by tomorrow and throw it to all of your for toying around :~P
- --
Signed on Sat Jul 9 22:32:52 2005 with key 0x93B84C15.
Visit my photo gallery at http://bloodgate.com/photos/
PGP key on http://bloodgate.com/tels.asc or per email.
This email violates EU patent EP0394160:
[ ########## 66% #### ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iQEVAwUBQtA9RXcLPEOTuEwVAQHqCwf+Ldcxfjnc2R2sq6WG8p4lYcTakdpoAAxo
ybSPcOi/R9mQsHPWVCUFowm2qj+sEGwGxphBCwxkLEsTTBNfimiG50wPDk3RqHwh
RJKnYFM9sGhg2TuSSvlxKwKD1gM0GkP5zI4XExKvieZ8ePgIXavIwKDFnGlXVu9w
acVQUg1xK9K3OU1OaVhIuZ6RBRr0VxBjv7siJP9Igch/8xKdq3Ry6wyzqURGmGlv
hFKbxsiSmCDT70BV39mSzaL4qq9CrtfZ7i69DBTaMS/n/rPQC9Q8mBVryXNIVQwB
zLRXTB8WqItUxSS+vr4MaS83MPm57S973e2K6nEycQrT79NtmZRWIQ==
=2gA8
-----END PGP SIGNATURE-----
diff -ruN blead/lib/Text/Balanced.pm blead.text_balanced/lib/Text/Balanced.pm
--- blead/lib/Text/Balanced.pm 2004-05-16 17:52:34.000000000 +0200
+++ blead.text_balanced/lib/Text/Balanced.pm 2005-07-09 22:45:46.000000000
+0200
@@ -7,10 +7,9 @@
package Text::Balanced;
use Exporter;
-use SelfLoader;
use vars qw { $VERSION @ISA %EXPORT_TAGS };
-$VERSION = '1.95_01';
+$VERSION = '1.95_02';
@ISA = qw ( Exporter );
%EXPORT_TAGS = ( ALL => [ qw(
@@ -37,6 +36,10 @@
sub _match_codeblock($$$$$$$);
sub _match_quotelike($$$$);
+sub carp {
+ require Carp; goto &Carp::carp;
+}
+
# HANDLE RETURN VALUES IN VARIOUS CONTEXTS
sub _failmsg {
@@ -343,8 +346,8 @@
for (qw,~ ! ^ & * ) _ + - = } ] : " ; ' > . ? / | ',)
{ next if $rdel =~ /\Q$_/; $del = $_; last }
unless ($del) {
- use Carp;
- croak "Can't interpolate right delimiter $rdel"
+ require Carp;
+ Carp::croak ("Can't interpolate right delimiter
$rdel")
}
eval "qq$del$rdel$del";
};
@@ -887,8 +890,7 @@
unless (wantarray)
{
- use Carp;
- carp "extract_multiple reset maximal count to 1 in
scalar context"
+ carp ("extract_multiple reset maximal count to 1 in
scalar context")
if $^W && defined($_[2]) && $max > 1;
$max = 1
}
