On Fri, Jul 15, 2005 at 02:05:44AM -0700, Gisle Aas wrote:
> Found yet another strangeness in that file. chown() is called with the
> filename as the second argument, but the second argument is supposed
> to be the gid. It means that the chown() call in stat.t has always
> been a noop. This patch make the chown functional, but I still don't
> think it does anything useful. Anybody have an idea of what this line
> was supposed to achieve?
No idea; but I've decided to just delete it (change 25162) rather than
fixing it.
> --- t/op/stat.t.orig 2005-07-15 01:57:40.000000000 -0700
> +++ t/op/stat.t 2005-07-15 01:58:10.000000000 -0700
> @@ -171,7 +171,7 @@
>
> # in ms windows, $tmpfile inherits owner uid from directory
> # not sure about os/2, but chown is harmless anyway
> -eval { chown $>,$tmpfile; 1 } or print "# $@" ;
> +eval { chown $>,$),$tmpfile; 1 } or print "# $@" ;
>
> ok(chmod(0700,$tmpfile), 'chmod 0700');
> ok(-r $tmpfile, ' -r');
--
Please note that ash-trays are provided for the use of smokers,
whereas the floor is provided for the use of all patrons.
-- Bill Royston
