On Tue, Jul 19, 2005 at 01:19:19AM +0100, Dave Mitchell wrote: > On Mon, Jul 18, 2005 at 01:14:43AM -0400, Alex Vandiver wrote: > > On Sun, 2005-07-10 at 14:29 +0100, Dave Mitchell wrote: > > > I don't think this fix is robust. You save the current PV value of ERRSV, > > > and then later set it back; in the meantime, ERRSV's PV may have been > > > realloced, and message now points to free or realloced garbage. > > Point. The attached patch uses save_item(ERRSV) to fully localize [EMAIL > > PROTECTED] > > Also added more tests that the previous patch didn't pass on. Thoughts? > > - Alex > > > I like the idea of localising $@ before calling DESTROY, but unfortunately > it breaks this test:
Which means that it wasn't tested before being sent to the list. make test exists for a reason. Nicholas Clark
