Rafael Garcia-Suarez wrote:
>Steve Hay wrote:
>
>
>>Line 544 in pad.c
>>
>> if (off <= PL_comppad_name_floor)
>>
>>causes a signed/unsigned mismatch on Win32 using VC++.
>>
>>off is a PADOFFSET (an unsigned type), while PL_comppad_name_floor is an
>>I32 (a signed type).
>>
>>Which is the correct fix? This
>>
>> if ((I32)off <= PL_comppad_name_floor)
>>
>>or this
>>
>> if (off <= (PADOFFSET)PL_comppad_name_floor)
>>
>>?
>>
>>
>
>A few lines higher, you have :
>
> /* XXX DAPM - why the (I32) cast - shouldn't we ensure they're the same
> * type ? */
> for (off = top; (I32)off > PL_comppad_name_floor; off--) {
>
>off is a PADOFFSET, which means unsigned integer.
>however the NOT_IN_PAD constant values ((PADOFFSET) -1).
>Regarding this, casting to I32 is the right fix.
>
I'm still not sure that I understand, but I've done the I32 case anyway.
------------------------------------------------
Radan Computational Ltd.
The information contained in this message and any files transmitted with it are
confidential and intended for the addressee(s) only. If you have received this
message in error or there are any problems, please notify the sender
immediately. The unauthorized use, disclosure, copying or alteration of this
message is strictly forbidden. Note that any views or opinions presented in
this email are solely those of the author and do not necessarily represent
those of Radan Computational Ltd. The recipient(s) of this message should
check it and any attached files for viruses: Radan Computational will accept no
liability for any damage caused by any virus transmitted by this email.
