From: Sastry [mailto:[EMAIL PROTECTED]
> Hi
> This is the verbose output of the lib/DBM_Filter/t/encode.t test case
> after my modification in the ext/Encode/Makefile.PL as discussed
> earlier.
>
> 1..26
> ok 1 - use DBM_Filter;
> ok 2 - use SDBM_File;
> ok 3 - use Fcntl;
> ok 4 - use charnames;
> ok 5 - tied to SDBM_File
> ok 6 - push an illigal filter
> ok 7 - push an 'encode' filter (default to utf-8)
> ok 8 - StoreData called from lib/DBM_Filter/t/encode.t, line 47
> ok 9 - Store Data is a hash reference
> ok 10 - Storing to tied hash
> ok 11 - VerifyData called from lib/DBM_Filter/t/encode.t, line 57
> ok 12 - Expected data is a hash reference
> ok 13 - Verifying a tied hash
> ok 14 - Expected == Actual
> ok 15 - pop the 'utf8' filter
> ok 16 - push an 'encode' filter (specify iso-8859-16)
> ok 17 - StoreData called from lib/DBM_Filter/t/encode.t, line 72
> ok 18 - Store Data is a hash reference
> ok 19 - Storing to tied hash
> ok 20 - untie without inner references
> ok 21 - tied to SDBM_File
> ok 22 - VerifyData called from lib/DBM_Filter/t/encode.t, line 90
> ok 23 - Expected data is a hash reference
> ok 24 - Verifying a tied hash
> not ok 25 - Expected == Actual
> # Failed test (/u/isldev3/perl-5.8.6/lib/dbm_filter_util.pl at line
> 48)
> # Expected does not match actual
> # No Match from Expected:
> # 'euro' => 'u'
> #
> # No Match from Actual:
> # 'ÁÍÊ?' => 'u'
> #
> ok 26 - untie without inner references
> # Looks like you failed 1 tests of 26.
>
> The key ÁÍÊ? corresponds to \x65\x75\x72\x6F on EBCDIC platform. Since
> it is using iso-8859-16 codepage to encode, the test case is written
> wrongly in the expected key. Hence I changed the key in test case to
> \x65\x75\x72\x6F in verifyData, which works fine and all the test case
> passes.
> There were other test cases (PerlIO/t/encoding.t and
> ext/Encode/t/gsm0338.t) failing before this change. If I include
> iso-8859-7 and gsm0338 in %table in Makefile.PL these tests
> pass.Please let me know if this change is appropriate on EBCDIC.
>From the DBM_Filter standpoint changing
"euro" => "\xA4",
to
"\x65\x75\x72\x6F" => "\xA4",
in the test harness is fine. It does make the test more portable.
I'll let Dan comment on whether ext/Encode/Makefile.PL should have
iso8859-16 included. DBM_Filter can always use a different charset in the
test if it is an issue.
Paul
___________________________________________________________
To help you stay safe and secure online, we've developed the all new Yahoo!
Security Centre. http://uk.security.yahoo.com
