On Tue, 24 Oct 2017 21:48:16 -0700, c...@zoffix.com wrote:
> On Tue, 24 Oct 2017 13:30:13 -0700, alex.jakime...@gmail.com wrote:
> > FWIW I'm not counting 2) and 3) as blockers, but 1) is worth taking a
> > look at.
> > See my comment here:
> > https://github.com/tokuhirom/p6-WebSocket/issues/15#issuecomment-
> > 339120879
> 
> That looks to be a bug in affinity workers in supply-in-a-sock
> scenarios.
> 
> I made a golfed test[^1] and a hack[^2] that makes the test pass, but
> isn't enough
> to fix the WebSocket module tests, since it applies onto when there's
> one affinity
>  worker knocking about and the module likely has more.
> 
> Needs a proper fix for the *cause* of the deadlock or a smarter algo
> for when to
> add more affinity workers.
> 
> [1]
> https://github.com/perl6/roast/commit/74445ddf8a37ef2d880febf5ccf76a160244f2ea
> [2]
> https://github.com/rakudo/rakudo/commit/ce7e5444a2c4aa69c2e4421f02a287241199318e


This is now properly fixed in https://github.com/rakudo/rakudo/commit/59bfa5ab37

As I understand this was the last issue on this ticket, so I'm closing it 
(tests already went in[^1] and were improved in later commits)

[1] 
https://github.com/perl6/roast/commit/74445ddf8a37ef2d880febf5ccf76a160244f2ea

Reply via email to