> "Dan Sugalski" <[EMAIL PROTECTED]> wrote > > > With the recent stack and GC patches, are we pretty much solid now? > > If so, a 0.0.5 bugfix release may well be in order. > > The one outstanding issue that I know of is the mem_realloc problem in > add_pmc_to_free and add_header_to_free. Since the problem is actually > endemic to mem_realloc, the best solution seems to be a replacement for > mem_realloc that takes a Buffer*, so that an intervening GC run still leaves > it knowing where the source is. > In line with a previous suggestion, I propose that such a routine be called > Parrot_reallocate. > A patch to create such a function and use it within add_pmc_to_free and > add_header_to_free follows; since all uses of mem_realloc are potentially at > risk, it might be a good idea to change any such places also.
This patch looks good to me. It fixes the test case that was posted earlier, and it's much better from a design standpoint than the previous patch, which was withheld. I'm also working on code that builds off this patch, so I'd appreciate if it was applied. Thanks, Mike Lambert
