On Sun, 8 Sep 2002, Steve Fink wrote:

> On Thu, Sep 05, 2002 at 07:46:38PM -0400, John Porter wrote:
> > Steve Fink wrote:
> > > Here is the new PMC I keep babbling about. Before I commit it, any
> > > comments? Like, does anybody think this should be named differently?
> > > It's really a dequeue (double-ended queue), ...
> > 
> > I for one think it ought to be called what it is - a dequeue.
> 
> Ok, I renamed it, but to IntList rather than IntDequeue. "List" is
> still accurate, since it's a circular doubly-linked list.
> 
> I have just committed the patch.
> 
> Note that the patch also adds two-arg push and pop opcodes for calling
> the push_XXX vtable entries, which should be very useful for
> Array/PerlArray as well as IntList. The one-arg push/pop still exist
> for manipulating the built-in int, str, num, and pmc stacks. Also,
> this patch adds shift/unshift too.
> 


I've seen that intlist adds a file called intlist.c to the core of
parrot. This IS! strange to me that Steves patch made it into
parrot while my Matrix patch didnt just because i had a file in the core
of parrot called matrix_core.c. Dan wanted everything in one file.  
Why should my matrix code live in only one file while both perlhash.pmc
and intlist and coroutine and others use external code. 
I feel that its VERY hard to contribute as an outsider. If parrot
wants to grow to a serious VM it has to accept other peoples patches. 

/Josef

Reply via email to