Jeff Clites <[EMAIL PROTECTED]> wrote: > I've sent my patch in through RT--it's [perl #28405]!
Phew, that's huge. I'd really like to have smaller patches that do it step by step. But anyway, the patch must have been a lot of work so lets see and make the best out of it. Some questions: First: - What is string->representation? It seems only to contain string_rep_{one,two,four}. - How does UTF8 fit here? - Where are encoding and chartype now? - Where is string->language? With this string type how do we deal with anything beyond codepoints? And some misc remarks/questions: - string_compare seems just to compare byte,short, or int_32 - What happenend to external constant strings? - What's the plan towards all the transcode opcodes? (And leaving these as a noop would have been simpler) - hash_string seems not to deal with mixed encodings anymore. - Why does read/PIO_reads generate an UTF-8 first? - Why does PIO_putps convert to UTF-8? (I've not applied the patch here, so I might have missed something) > JEff leo