On Oct-05, Andy Dougherty wrote:
> 
> The following patch makes compilation both slightly quieter and also
> slightly more informative.
> 
> Or, with less "spin", it fixes bad advice I gave previously. Specifically,
> I had previously noted that it's generally helpful if the Makefile prints
> out the commands it is trying to execute so that it's easier to track down
> problems when they fail.  When I suggested that the '@' be removed from
> the .pbc.imc rule, I suggested at the same time that the '@' also be
> removed from the compilation step above it.
> 
> Alas, that wasn't quite the right place to do it.  What's ultimately of
> interest is the command that actually gets called.  Accordingly, this
> patch puts the '@' back in front of the invocation
> of tools/dev/cc_flags.pl, but changes the print statement in
> tools/dev/cc_flags.pl to show the actual compilation command being issued.
> 
> Again, I have found that information to be useful on numerous
> occasions.  Also, considering how noisy the whole ICU build is, I
> think the extra clutter for parrot's sources is not a significant
> additional burden.

Makes sense to me. Applied, thanks.

Tell me again why Andy doesn't have commit privs yet?

Reply via email to