On Tue, Jun 28, 2005 at 03:24:51PM +0100, Clayton, Nik wrote:
>     user_ok(name => 'nik', uid => 1000, shell => '/bin/tcsh',
>             'Check nik\'s account');

My only thought is I would use a hash ref.

        user_ok( { name => 'nik', uid => 1000, shell => '/bin/tcsh' },
                 "Check nik's account" );

Just to make it a bit clearer what's going on.  A hash followed by a scalar
as an argument list is a little weird.


> homedir_ok() verifies that the home directory for the given user exists,
> is owned/group owned by that user, and has a given set of permissions.
> 
>     homedir_ok(name => nik, uid => 1000, gid => 1000, perm => 0755,
>                'Check nik\'s home directory');

Is it necessary to tell homedir_ok() what the proper uid and gid is?  Can't
it figure it out from the name?  In fact, wouldn't that be more robust since
the uid/gid on the system might change but the name will stay the same.


-- 
Michael G Schwern     [EMAIL PROTECTED]     http://www.pobox.com/~schwern
'All anyone gets in a mirror is themselves,' she said. 'But what you
gets in a good gumbo is everything.'
        -- "Witches Abroad" by Terry Prachett

Reply via email to