Hi,
I had a look at this, but I'm not that good at Perl, and regular
expressions. However, I found where things go wrong, so someone who
really groks REs may fix it.
THe problem is (well, at least I think it is) at about line 440 in pmc2c.pl
sub parse_pmc {
my $code = shift;
my $signature_re = qr{
^
(?: #blank spaces and comments and spurious semicolons
[;\n\s]*
(?:/\*.*?\*/)? # C-like comments
)*
(METHOD\s+)? #method flag
(\w+\**) #type <<<==========I'd say this
should be (\w+\s*\**) so it matches a word (the return type), optional
spaces, and then optial *'s to indicate a pointer
\s+
(\w+) #method name
\s*
\( ([^\(]*) \) #parameters
}sx;
If the fix as I noted above is done, things don't compile anymore.
I'm sorry I can't provide a real fix, but at least it's easier to fix
now, hopefully.
A more kludgy fix may be to check whether $type equals "METHOD", if so,
then there is something wrong. And it may be that not everything is
handled by this.
kind regards,
klaas-jan
Leopold Toetsch (via RT) wrote:
# New Ticket Created by Leopold Toetsch
# Please include the string: [perl #39313]
# in the subject line of all future correspondence about this issue.
# <URL: https://rt.perl.org/rt3/Ticket/Display.html?id=39313 >
It's easy to add 'invalide' code to .pmc files. E.g. I had defined:
METHOD parent() {
return PMC_pmc_val(SELF) ? PMC_pmc_val(SELF) : PMCNULL;
}
Due to the absence of a return value, the PMC compiler just ignores this
'method' without further notice.
This also is happening, if there's just a whitespace before the '*':
METHOD PMC *parent() {
return PMC_pmc_val(SELF) ? PMC_pmc_val(SELF) : PMCNULL;
}
This totally valid C type declaration is just ignored.
Fixes welcome,
leo
