On Monday 23 April 2007 17:10, Matt Diephouse wrote: > > It's three lines; is it worth extracting somehow? > > It could definitely be placed inside start_flatten(), but that would > make the code a little misleading, I think. I'm not sure it's worth > placing it in a function of its own; the transparency may be worth > something in this case. Having said that, I think this section of the > code could be cleaned up more with further refactoring down the road.
It may not be worth moving, and I'm not sure how aggressively we can support inline functions. However, if we do have more than two or three duplicated lines, I start to worry that they'll get out of sync. I don't have a good solution or even a rule of thumb yet. > There's also a large ~20 line section of code that is repeated in this > patch that I'll move to a function before I commit. Sounds great. -- c
