Re: [File of the Week] src/objects.c

[chromatic]

On Tuesday 01 May 2007 12:12:35 Kevin Tew wrote:

> This week's file of the week is:
> src/object.c
>
> As Allison says below, no patch is to small.
> typo fixes, spelling fixes, documentation welcome, as well as code
> refactorings.

I missed it last week, but create_deleg_pmc_vtable() has some awkward code:

            if (((void **)delegate_vtable)[i] == ((void**)object_vtable)[i]) {
                if (ro_vtable)
                    ((void **)ro_vtable)[i] = ((void**)deleg_pmc_vtable)[i];
                ((void **)vtable)[i] = ((void**)deleg_pmc_vtable)[i];
            }
            else {
                ((void **)vtable)[i] = ((void**)object_vtable)[i];
                if (ro_vtable)
                    ((void **)ro_vtable)[i] = ((void**)ro_object_vtable)[i];

All those void ** casts bother me.

-- c