On Saturday 09 June 2007 02:40:23 Bram Geron wrote:

> The patch I attached should solve that. In a freshly created context,
> the refcount is zero, and this increases it by one. I think incrementing
> it is slightly better than directly assigning it a refcount of 1,
> because that could cause bugs if we incremented the refcount before for
> some mysterious reason. (far-fetched, I admit.)

Thanks, applied as r19019.

> With the patch, [perl #42790] "[BUG] Tailcall with slurpy argument
> passing causes a memory leak" is solved for me too.

Great!

There are other context memory leaks.  Valgrind is a great source of 
frustration.  I tried calling Parrot_free_context() on ctxp->from_ctx and 
ctxp->to_ctx within Parrot_free_context(), as it made sense to me, but that 
didn't work so well.

If you understand this code well enough to have produced a successful patch 
(and you have), there's other investigation here....

-- c

Reply via email to