On Tuesday 31 July 2007 09:11:05 Paul Cochrane wrote: > Attached is a patch which allows the Sun C compiler on Solaris compile > Parrot. However, I'm *really* not sure if what I've done is correct. > I've tested the patch on Solaris (not all tests pass), on Linux (all > tests pass), and on Windows (all tests pass) but I'd like some code > review to make absolutely sure that I've done the right thing here.
I don't think it's right. If we have pointers to pointers to data we want to use, we have to dereference them fully; we can't stop at the first dereference and say "We're *closer* to the data; let's stop here." > I'll apply the patch once a consensus has been reached. Revert r19938 locally and try make testC again; I bet it fails horribly. -- c
