On Sun Jun 22 19:35:27 2008, coke wrote: > Attached find a first pass at converting our perlcritic.t into using > Test::Perl::Critic. > > This patch: > > - requires Test::Perl::Critic to do anything useful with the test. (We > can add it to > Bundle::Parrot) > - creates a new perlcritic.conf file that represents declaratively a > large chunk of the code we > used to use to manage the policy list. > - removes the ability to list the policies. (you have the conf file) > - removes the ability to specify a specific policy (you can roll your > own with themes) > - removes the ability to specify a directory to run the policies > against (but if we do, let's do it > without File::Find, and just key off the MANIFEST like we do now.) > - keeps the ability to specify a "group" of tests, but calls it a > theme, following the lead set by > Perl::Critic. > - reports each file as a test, not each policy. > > I think the last item there is a big reason we started down the path > we did, but given how > much simpler this script is, I don't think it's worth worrying about. > > I've tested this on Perl::Critic 1.086; I'd be interested to hear > feedback on older versions of > P::C before I apply. (The old version I had installed is no longer > available for easy download > on the CPAN) > > Feedback in general, as well: This is a reduction in features from the > original version, but I > think it's a step forward.
Applied in r28839, closing ticket. Thanks to kid51++ for testing. -- Will "Coke" Coleda
