On Tue, Feb 18, 2014 at 12:02:50PM -0500, Andy Dougherty wrote: > On Tue, Feb 18, 2014 at 03:11:01PM +0000, Nicholas Clark wrote: > > Andy, is it OK to use your Perl 5 static inline probing code in MoarVM? > > Absolutely. Please feel free. Perl 5's Configure script is actually > public domain on purpose to encourage such sharing, so you needn't ask, > though I agree courtesy is almost never inappropriate.
Oh gosh, it does say that. It seems that I've missed actually reading that bit of the comments for years. > You might want to revisit the gcc preferences -- they were designed to > allow Perl 5's cflags.SH to add -ansi (or -c89 or something similar) to > enforce C89 checking. I don't know if MoarVM wants to embrace that > particular constraint. I don't know either. But the "is it gcc?" check seemed to make a nice sanity test for whether the probe compiler code was working at all, so I don't think that it actually costs much to keep it in. And the differing ordering of what "inline" to use costs even less. So I think that it's safe to keep the options open. > Have the appropriate amount of fun, Well, Jonathan has now committed it, and I'm busy with other stuff, so I'm hoping that others might have fun converting macros to functions. Nicholas Clark
