On 03/21/2013 01:40 PM, Patrick R. Michaud wrote:
> On Thu, Mar 21, 2013 at 08:49:42AM +0100, Moritz Lenz wrote:
>> - method sink() {
>> - self.gimme(*, :sink);
>> + method sink(\SELF:) {
>> + SELF.gimme(*, :sink) unless nqp::iscont(SELF);
>> Nil;
>> }
>> }
>>
>>
>> But of course it's not a real fix. Should I apply it?
>
> I think I prefer
>
> method sink(\SELF:) {
> SELF.gimme(*) unless nqp::iscont(SELF);
> Nil;
> }
>
> because I'm not entirely certain that :sink is safe in
> all cases (and it may go away anyway).
Not using :sink isn't safe either:
Test Summary Report
-------------------
t/spec/S04-statements/next.rakudo (Wstat: 0 Tests:
12 Failed: 2)
Failed tests: 8-9
t/spec/S12-introspection/walk.t (Wstat: 0 Tests:
11 Failed: 2)
Failed tests: 6-7
They go away when keeping the :sink.
Cheers,
Moritz
