These tests passed for the most part. I removed the fudging and fixed the last
test: https://github.com/perl6/roast/commit/692d7be0fc
As masak pointed out, that last test is not very specific. (But at least it's
not wrong.)
< bartolin> ^^ could someone review that commit, please? as in: was the last
test wrong (nok 'c3' ~~ &hasstate) ?
* masak reviews
< bartolin> thanks, masak++
< masak> yeah, that change makes a lot of sense.
< bartolin> nice, another ticket can be closed :-)
< masak> the (corrected) test as such is not one I'd've written, but I'm
hard-pressed to explain why not.
< masak> a first stab at explaining why: testing not-c4 is a lot less specific
than testing for c3 (which you know to expect, so might as well test for
it).
< masak> but if you do that, it's quite clear that you're testing nothing new
compared to the c2 test.
< bartolin> *nod*
< masak> this has been masak's mini-course "Don't Write Tests Because You Have
To, Write Tests Because You Have Something To Test" :)
bartolin> this goes into the ticket :-)
