printf format strings

[Bryan C . Warnock]

What are our short- and long-term goals for handling printf formats for
configurable types? 

This fixes the ones not dependent on the answer above.  I'm also wrapping 
some lengthy lines.   And why aren't the coding standards up on dev.perl.org?

-- 
Bryan C. Warnock
[EMAIL PROTECTED]
Index: packfile.c
===================================================================
RCS file: /home/perlcvs/parrot/packfile.c,v
retrieving revision 1.10
diff -u -r1.10 packfile.c
--- packfile.c	2001/10/06 00:57:43	1.10
+++ packfile.c	2001/10/06 17:29:56
@@ -1689,10 +1689,15 @@
         case PFC_STRING:
             printf("    [ 'PFC_STRING', {\n");
             printf("        FLAGS    => 0x%04x,\n", self->string->flags);
-            printf("        ENCODING => %ld,\n",  (long) self->string->encoding->which);
-            printf("        TYPE     => %ld,\n",  (long) self->string->type);
-            printf("        SIZE     => %ld,\n",  (long) self->string->bufused);
-            printf("        DATA     => '%s'\n",  self->string->bufstart); /* TODO: Not a good idea in general */
+            printf("        ENCODING => %ld,\n", 
+                    (long) self->string->encoding->which);
+            printf("        TYPE     => %ld,\n",  
+                    (long) self->string->type);
+            printf("        SIZE     => %ld,\n",  
+                    (long) self->string->bufused);
+            /* TODO: Not a good idea in general */
+            printf("        DATA     => '%s'\n",  
+                    (char *) self->string->bufstart); 
             printf("    } ],\n");
             break;
 
Index: test_main.c
===================================================================
RCS file: /home/perlcvs/parrot/test_main.c,v
retrieving revision 1.14
diff -u -r1.14 test_main.c
--- test_main.c	2001/10/06 00:57:43	1.14
+++ test_main.c	2001/10/06 17:29:56
@@ -46,13 +46,22 @@
         int i;
         time_t foo;
         
-        printf("String %p has length %i: %.*s\n", s, (int) string_length(s), (int) string_length(s), (char *) s->bufstart);
+        printf("String %p has length %i: %.*s\n", (void *) s, 
+                (int) string_length(s), (int) string_length(s), 
+                (char *) s->bufstart);
         string_concat(s, t, 0);
-        printf("String %p has length %i: %.*s\n", s, (int) string_length(s), (int) string_length(s), (char *) s->bufstart);
+        printf("String %p has length %i: %.*s\n", (void *) s, 
+                (int) string_length(s), (int) string_length(s), 
+                (char *) s->bufstart);
         string_chopn(s, 4);
-        printf("String %p has length %i: %.*s\n", s, (int) string_length(s), (int) string_length(s), (char *) s->bufstart);
+        printf("String %p has length %i: %.*s\n", (void *) s, 
+                (int) string_length(s), (int) string_length(s), 
+                (char *) s->bufstart);
         string_chopn(s, 4);
-        printf("String %p has length %i: %.*s\n", s, (int) string_length(s), (int) string_length(s), (char *) s->bufstart);
+        printf("String %p has length %i: %.*s\n", (void *) s, 
+                (int) string_length(s), (int) string_length(s), 
+                (char *) s->bufstart);
+
         foo = time(0);
         for (i = 0; i < 100000000; i++) {
             string_concat(s, t, 0);