On Tue, 15 Jan 2002, Dan Sugalski wrote:
> At 04:39 PM 1/15/2002 +0000, Alex Gough wrote:
> >On Tue, 15 Jan 2002, Simon Glover wrote:
> >
> > > warning: control reaches end of non-void function
> > >
> > > I'm not sure what to do about the former. The latter generally seem to
> > > arise from unimplemented methods. Accordingly, I've added a new
> > > exception, PMC_FN_NOT_IMPLEMENTED, to exception.h, and I'm working on
> > > getting all of the currently unimplemented methods to throw this
> > > exception. Patches below to exception.h and to perlnum.pmc - patches
> > > for the other PMCs will follow shortly.
> >In general we should let things inherit from default.pmc, which can then
> >explode in the correct manner or do something sensible in terms of the
> >other behaviours of the pmc. Adding "not implemented" code to every
> >pmc type is pointless duplication and certainly not the right way to
> >halt compiler warnings.
>
> Definitely. This is the way we should go with methods that are unchanged
> from the parent. (In this case the exception throw)
>
Fair point; I'll patch it this way if I get a chance (which won't, alas,
happen for a couple of days).
Simon
