Is a MANIFEST.SKIP a good idea, even if Configure.pl doesn't check it by default?
Nicholas Clark ----- Forwarded message from Nicholas Clark <[EMAIL PROTECTED]> ----- Mailing-List: contact [EMAIL PROTECTED]; run by ezmlm List-Post: <mailto:[EMAIL PROTECTED]> List-Help: <mailto:[EMAIL PROTECTED]> List-Unsubscribe: <mailto:[EMAIL PROTECTED]> List-Subscribe: <mailto:[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Subject: [PATCH] MANIFEST.SKIP From: Nicholas Clark <[EMAIL PROTECTED]> This patch (context diffs mean that it's atop the Term::ReadLine patch) adds a check for unexpected files not in the MANIFEST to Configure.pl I'm not certain that putting the test in Configure.pl is the right place for it, but I do believe that having an accurate MANIFEST.SKIP and the ability to run perl -MExtUtils::Manifest -e ExtUtils::Manifest::fullcheck (possibly as a Makefile target) is useful. Currently: Not in MANIFEST: include/parrot/rxstacks.h Not in MANIFEST: rxstacks.c Nicholas Clark -- ENOCHOCOLATE http://www.ccl4.org/~nick/CV.html --- /mnt/six/parrot/parrot_readline++/Configure.pl~ Mon Jan 21 17:44:03 2002 +++ Configure.pl Mon Jan 21 19:48:37 2002 @@ -11,7 +11,7 @@ use Config; use Getopt::Long; -use ExtUtils::Manifest qw(manicheck); +use ExtUtils::Manifest qw(fullcheck); use File::Copy; use Term::ReadLine; # The stub is present from earlier than 5.004 use Parrot::BuildUtil; @@ -810,11 +810,10 @@ # sub check_manifest { - print "\n"; - my(@missing)=manicheck(); + my($missing,$extra)=fullcheck(); - if(@missing) { + if(@$missing) { print <<"END"; Ack, some files were missing! I can't continue running @@ -838,6 +837,7 @@ if ($term) { my $type = $term->ReadLine; print <<"END"; + Okay, we found everything. Next you'll need to answer a few questions about your system. You have ${ type} installed, so I'll use that to let --- /dev/null Mon Jul 16 22:57:44 2001 +++ MANIFEST.SKIP Mon Jan 21 20:13:26 2002 @@ -0,0 +1,52 @@ +\.o$ +^\.cvsignore$ +/\.cvsignore$ +^include/parrot/config\.h$ +^include/parrot/platform\.h$ +^Makefile$ +/Makefile$ +^Parrot/Types\.pm$ +^Parrot/Config\.pm$ +^platform\.c$ +^config.opt$ + +^vtable\.ops$ +^include/parrot/vtable\.h$ +^include/parrot/jit_struct\.h$ +^include/parrot/oplib/core_ops\.h$ +^include/parrot/oplib/core_ops_prederef\.h$ + +^core_ops\.c$ +^core_ops_prederef\.c$ +^vtable_ops\.c$ + +^Parrot/Jit\.pm$ +^Parrot/PMC\.pm$ +^Parrot/OpLib/core\.pm$ + +^classes/default\.h$ +^classes/default\.c$ +^classes/intqueue\.h$ +^classes/intqueue\.c$ +^classes/parrotpointer\.h$ +^classes/parrotpointer\.c$ +^classes/perlarray\.h$ +^classes/perlarray\.c$ +^classes/perlhash\.h$ +^classes/perlhash\.c$ +^classes/perlint\.h$ +^classes/perlint\.c$ +^classes/perlnum\.h$ +^classes/perlnum\.c$ +^classes/perlstring\.h$ +^classes/perlstring\.c$ +^classes/perlundef\.h$ +^classes/perlundef\.c$ + +^docs/packfile-c\.pod$ +^docs/packfile-perl\.pod$ +^docs/core_ops\.pod$ + +^test_parrot$ +^pdump$ +^blib/ --- ../parrot/MANIFEST Mon Jan 21 16:42:17 2002 +++ MANIFEST Mon Jan 21 19:34:16 2002 @@ -3,6 +3,7 @@ Configure.pl KNOWN_ISSUES MANIFEST +MANIFEST.SKIP Makefile.in NEWS Parrot/Assembler.pm ----- End forwarded message -----
