On Fri, 1 Feb 2002, Brent Dax wrote:
> Jonathan Stowe:
> # This shuts up the implicit declaration warning in test_main.c :
> #
> # --- config_h.in~ Fri Feb 1 07:39:42 2002
> # +++ config_h.in Fri Feb 1 07:40:06 2002
> # @@ -51,9 +51,10 @@
> # #define INTVAL_FMT "${intvalfmt}"
> # #define FLOATVAL_FMT "${floatvalfmt}"
> #
> # +#endif
> # +
> # ${headers}
> #
> # -#endif
>
> This (part of the) patch is a Really Bad Idea.
>
> While it clears up a warning, it severely pollutes the namespace of any
> program that embeds Parrot. Not just test_main.c, but perl_main.c,
> python_main.c, ruby_main.c, scheme_main.c, and
> some_random_program_that_uses_parrot_on_the_inside_main.c. True,
> HAS_HEADER_FOOs probably aren't something that will differ between
> programs, but it still is a pollution that simply shouldn't be there.
>
OK, got you. Would it be better then if test_main.c had its own config.h,
which is likely to be the case if it was a real language front end ?
/J\
--
Jonathan Stowe |
<http://www.gellyfish.com> | This space for rent
|
