Michael Scott <[EMAIL PROTECTED]> writes: > Here are some tests for the io.h API that should go in t/src/io.t.
Ah yes. I know I submitted one too. I thought it got committed a long time ago but maybe it wasn't. I will try to merge it with your tests and commit a change. In one test you include "../io/io_private.h". I'm not sure if it's a good idea to test implementation details. On one side its better to test as many as you can, on the other side mainly the public API should be tested, the implementation should just work. > Maybe some of the expected results are debatable. > > Should PIO_parse_open_flags think that "<<<<<<<<<" is the same as "<"? No it shouldn't. > Should PIO_fdopen open ok on stdout with invalid flags like ";-)" or ""? I think all invalid flags should be invalid. > Also, successive calls to PIO_seek with SEEK_CUR seem to be broken. I will look at this. > Mike bye boe -- Juergen Boemmels [EMAIL PROTECTED] Fachbereich Physik Tel: ++49-(0)631-205-2817 Universitaet Kaiserslautern Fax: ++49-(0)631-205-3906 PGP Key fingerprint = 9F 56 54 3D 45 C1 32 6F 23 F6 C7 2F 85 93 DD 47
