From: Andy Dougherty <[EMAIL PROTECTED]>
Date: Fri, 27 Apr 2007 10:47:55 -0400 (EDT)
On Fri, 27 Apr 2007, Allison Randal via RT wrote:
> Agreed. I hate yielding compatibility, but it makes sense in this case
> (since we're likely to eventually require that any Perl 5 code in the
> repository be able to run on the Parrot implementation of Perl 5).
Fair enough. I suggest the following patch. (The 5.8.4 version is
arbitrary. It's the oldest 5.8.x I happen to have installed for easy
testing. It should perhaps be replaced with whatever version regular
Parrot contributors are going to be using.)
FWIW, I build Parrot regularly using 5.8.1. Out of curiosity, I tried
it with 5.8.0 (which is the oldest version I have readily available),
and it only needed a trivial tweak (attached), which would allow us to
say "Needs Perl 5.8.x" here. Do we care enough that I should commit
this?
-- Bob Rogers
http://rgrjr.dyndns.org/
* lib/Parrot/Pmc2c/delegate.pm:
+ (body): Minor tweak to make this work in 5.8.0.
Diffs between last version checked in and current workfile(s):
Index: lib/Parrot/Pmc2c/delegate.pm
===================================================================
--- lib/Parrot/Pmc2c/delegate.pm (revision 18352)
+++ lib/Parrot/Pmc2c/delegate.pm (working copy)
@@ -96,9 +96,11 @@
# I think that these will be out by one - NWC
my $l = $self->line_directive( $line, "delegate.c" );
+ # [Leave the space between "${decl}" and the "{"; otherwise Perl 5.8.0
+ # thinks this is a hashref. -- rgr, 29-Apr-07.]
my $cout = <<EOC;
$l
-${decl}{
+${decl} {
STRING *meth = CONST_STRING(interp, "$meth");
PMC *sub = Parrot_find_vtable_meth(interp, pmc, meth);
if (PMC_IS_NULL(sub))
End of diffs.
