# New Ticket Created by  Mike Mattie 
# Please include the string:  [perl #42900]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=42900 >


Hello,

I noticed while debugging my patches to the loader that the message for a 
failure in .load_bytecode was really
horrible. It was something like this:

immc: Couldn't find file %s

At the time I didn't know what immc was, and the message didn't really tell me 
much more than some
deep guts of parrot couldn't load a file anymore.

In this patch I try and clarify things a bit by adding to the message something 
they can associate
with a parrot op , load_bytecode.

Hopefully the message will now be:

immc: "load_bytecode" couldn't find file %s

Which helps alot for a person that is using the API but isn't familiar with the 
architecture.

The one test that failed repeatably was t/op/load_bytecode.t . I fixed that (in 
the patch)
but I still got that mysterious failure in t/perl/Parrot_Docs.t which I can't 
reproduce with
prove.

here is the output:

t/perl/Parrot_Docs...............................
                                                                             
t/perl/Parrot_Docs...............................ok 1/25
                                                                             
t/perl/Parrot_Docs...............................ok 2/25
#     Failed test (t/perl/Parrot_Docs.t at line 61)
Use of uninitialized value in pattern match (m//) at
t/perl/Parrot_Docs.t line 65.

That could be from my copy -R HEAD BASE which is duplicating svn meta-data the 
wrong
way ? not sure.

If your harness is OK, and I haven't broken any error report convention please 
apply.

Cheers,
Mike Mattie - [EMAIL PROTECTED]
--- HEAD/src/packfile.c	2007-05-06 17:58:47.000000000 -0700
+++ rev-18443/src/packfile.c	2007-05-07 05:54:07.000000000 -0700
@@ -3436,7 +3436,7 @@
     path = Parrot_locate_runtime_file_str(interp, file_str, file_type);
     if (!path) {
         real_exception(interp, NULL, E_LibraryNotLoadedError,
-                "Couldn't find file '%Ss'", file_str);
+                "\"load_bytecode\" couldn't find file '%Ss'", file_str);
         return;
     }
     /* remember wo_ext => full_path mapping */
--- BASE/t/op/load_bytecode.t	2007-05-07 06:32:51.000000000 -0700
+++ HEAD/t/op/load_bytecode.t	2007-03-18 05:17:23.000000000 -0700
@@ -35,7 +35,7 @@
         load_bytecode 'no_file_by_this_name'
 .end
 CODE
-/"load_bytecode" couldn't find file 'no_file_by_this_name'/
+/Couldn't find file 'no_file_by_this_name'/
 OUTPUT
 
 # Local Variables:

Attachment: signature.asc
Description: PGP signature

Reply via email to