James Keenan via RT wrote on Sat, Aug 18, 2007 at 06:31:27PM PDT:
> 1. I added a reference to RT 42360 which requests unit tests for the
> SVK portion of Parrot::Revision's code.
>
> 2. Would it be possible to add tests for the git-related code in your
> patch to the following 4 test files:
>
> t//configure/017-revision_no_DEVELOPING.t
> t//configure/018-revision.t
> t//postconfigure/03-revision_no_DEVELOPING.t
> t//postconfigure/04-revision.t
>
> In a part of the Parrot distribution which has long been stable, such as
> this module, any code we add should be accompanied by tests so that we
> maintain high test coverage and quality. Perhaps if we get some tests
> for a git block, we can shame some of our SVK users to write some tests
> for the SVK block referenced in RT 42360.
Reading RT 42360, I didn't see any tests that were SVN-specific, but
just tests for what is returned by $Parrot::Revision::config and
$Parrot::Revision::current. So the current tests already create
different test coverage based on what type of repository they're run
with. When I run the tests with my git repository and my patch applied,
they all pass. I have also forced the tests in all the above test files
to *not* skip, and the tests continue to pass, too. So it seems the
coverage is still high (because it's being covered when I run it w/git).
To show you what I mean, I have attached the test coverage output
(coverage.html and lib-Parrot-Revision-pm.html) for the test files when
running w/a git repository, and when forcing the tests to not skip. Or
am I missing something?
- David
--
"Aliud est de silvestri cacumine videre patriam pacis...et aliud tenere
viam illuc ducentem."
-- St. Augustine, Confessiones, VII, xxi
