On Friday 01 February 2008 15:01:33 [EMAIL PROTECTED] wrote:

> Author: petdance
> Date: Fri Feb  1 15:01:32 2008
> New Revision: 25410
>
> Modified:
>    trunk/include/parrot/warnings.h
>    trunk/src/warnings.c
>
> Log:
> print_pbc_location needs to be PARROT_API for t/src/warnings.t to work

Bug in the test.  Bug in most of the tests in t/src/.

Is there any reason to expose the internals of how bytecode works as part of 
the public API?  According to the documentation of the function:

        Prints the bytecode location of the warning or error to C<PIO_STDERR>.

Is anyone linking against libparrot really going to need to do this?  Is this 
the sort of function we want to support?

        $ nm -l blib/lib/libparrot.so.0.5.2 | wc -l
        16020

Do we really need to export 16,000 symbols?  We ought to be *removing* 
PARROT_API, not adding it.

-- c

Reply via email to