On Fri, 2008-04-18 at 05:10 -0700, James Keenan via RT wrote:
> I'll consider this patch, but, as all the other code in this module has
> corresponding unit tests, we'll have to write a test for it.  It should
> go in whatever t/configure/*.t file holds other tests for
> Parrot::Configure::Options::Test.

I see where you're coming from, but I disagree with the conclusion.  The
behavior that we want to have (and that we want to test) is to not die
at all, but rather do something sane like change this entire behavior to
a codingstd test case failure.

I'm not saving the dying hero, I'm just letting him have some poignant
last words -- but we don't want to consider his death to be the right
thing and to codify that belief in our tests.

(Also, I don't think my failure to implement the best behavior should
keep the patch from going in.  Poignant last words are better than
gibberish, after all.  Sucking less is an iterative process.)


-'f


Reply via email to