On 26 April 2008 chromatic wrote:
> src/key.c:306: warning: switch missing default case
Fixed in 27195.
Just a query, wouldn't:
Index: src/key.c
===================================================================
--- src/key.c (revision 27216)
+++ src/key.c (working copy)
@@ -329,12 +329,14 @@
}
case KEY_start_slice_FLAG:
case KEY_inf_slice_FLAG:
+ {
+ return VTABLE_get_integer(interp, key);
+ }
default:
- break;
+ return VTABLE_get_integer(interp, key);
}
}
- return VTABLE_get_integer(interp, key);
}
be a little better? When I was trying to figure this out before (perl
#52710 - which can be closed now), I was hung up on why there were KEY_*
values being passed in that didn't have KEY_flags values. I was trying to
match the usage of default in:
key_number(PARROT_INTERP, ARGIN(PMC *key))
{
switch (PObj_get_FLAGS(key) & KEY_type_FLAGS) {
....
default:
real_exception(interp, NULL, INVALID_OPERATION, "Key not a
number!\n");
}
At least by leaving it a separate section, not combined w/
start_slice|inf_slice, if it turns out that there's a 'missing' flag or
something. It'll be more obvious??? In any case, the final
return VTABLE_get_integer(interp, key);
shouldn't be needed, right?
a
-------------------
Andy Bach
Systems Mangler
Internet: [EMAIL PROTECTED]
Voice: (608) 261-5738 Fax: 264-5932
"When angry, count to four; when very angry, swear."
Mark Twain
