On Saturday 03 May 2008 20:28:44 [EMAIL PROTECTED] wrote:
> Modified: branches/pdd13pbc/include/parrot/exceptions.h
> ===========================================================================
>=== --- branches/pdd13pbc/include/parrot/exceptions.h (original)
> +++ branches/pdd13pbc/include/parrot/exceptions.h Sat May 3 20:28:44 2008
> @@ -62,6 +62,7 @@
> E_ReferenceError,
> E_SystemError,
> E_MemoryError,
> + E_MalformedPackFileError,
> E_LAST_PYTHON_E = E_MemoryError,
>
> BAD_BUFFER_SIZE,
These are Python-style exceptions, and they're going away in the concurrency
branch. I suggest EXCEPTION_MALFORMED_PACKFILE instead.
> Modified: branches/pdd13pbc/src/pmc/packfile.pmc
> ===========================================================================
>=== --- branches/pdd13pbc/src/pmc/packfile.pmc (original)
> +++ branches/pdd13pbc/src/pmc/packfile.pmc Sat May 3 20:28:44 2008
> @@ -25,6 +25,34 @@
>
> /*
>
> +=item C<void init()>
> +
> +Initialize the structure. (Create a blank PackFile object.)
> +
> +=cut
> +
> +*/
> + VTABLE void init() {
> + PMC_struct_val(SELF) = PackFile_new(interp, 0);
> + }
I'd use PMC_data() for storage instead. I'd love to see the PObj cache struct
member go away. You can also use PMC_data_typed() to avoid the cast
yourself.
-- c
